7 Aug
2022
7 Aug
'22
6:51 a.m.
Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28963 )
Change subject: pySim.transport: Add mechanism for handling for CAT/USAT proactive cmds ......................................................................
Patch Set 4:
(2 comments)
File pySim/transport/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/28963/comment/691fc679_252bd02b PS4, Line 57: receive_fetch Rather decorate with @abc.abstractmethod, no need to raise NotImplementedError.
https://gerrit.osmocom.org/c/pysim/+/28963/comment/f468e171_7a8a7dcf PS4, Line 164: while Could you explain why are you changing 'if' to 'while'?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/28963
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I844504e2fc1b27ce4fc7ede20b2307e698baa0f6
Gerrit-Change-Number: 28963
Gerrit-PatchSet: 4
Gerrit-Owner: laforge laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Sun, 07 Aug 2022 04:51:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment