[XL] Change in osmo-ttcn3-hacks[master]: testenv: add test environment script

Attention is currently required from: daniel, fixeria, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694?usp=email ) Change subject: testenv: add test environment script ...................................................................... Patch Set 2: (4 comments) File _testenv/data/podman/seccomp_profile.json: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/f555f325_8f83… PS2, Line 20: "subArchitectures": [ is this file a modified file from some other source? If yes, then I would appreciate if we can check in the original, unmodified file first, and then add our modifications to it, so we can see them in the changelog and have an easier chance of ever applying our diff on top of a modified upstream at a later point. Also, if it's a modified version of an upstream file, it would explain why we have config about MIPS and S390 in osmocom projects 😊 File _testenv/data/scripts/rename_junit_xml_classname.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/81719487_cac6… PS2, Line 1: #!/bin/sh -e maybe 1-2 line description on top of the file what it does? Yes, rename something - but why and how is it used/neeed in our context? File _testenv/testenv.py: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/ddc794e5_1a8e… PS2, Line 2: import logging please add some kind of copyright statement, license header and summary description to all of the python files here. Choice of license is up to you, copyright would be sysmocom, for anything done during working hours. File _testenv/testenv/osmo_dev.py: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/8ebd60d7_d469… PS2, Line 49: logging.error(testenv.src_dir) I see a some line wrapping that looks like its way before we hit the 120 character max line length of our coding style? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If9f8b79dd6e5b4f06be4e5ff73db97759c3acfb2 Gerrit-Change-Number: 37694 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Aug 2024 08:19:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment