Attention is currently required from: daniel, fixeria, osmith, pespin.

View Change

4 comments:

• File _testenv/data/podman/seccomp_profile.json:

  • Patch Set #2, Line 20: "subArchitectures": [

    is this file a modified file from some other source? If yes, then I would appreciate if we can check in the original, unmodified file first, and then add our modifications to it, so we can see them in the changelog and have an easier chance of ever applying our diff on top of a modified upstream at a later point.

    Also, if it's a modified version of an upstream file, it would explain why we have config about MIPS and S390 in osmocom projects 😊

• File _testenv/data/scripts/rename_junit_xml_classname.sh:

  • Patch Set #2, Line 1: #!/bin/sh -e

    maybe 1-2 line description on top of the file what it does? Yes, rename something - but why and how is it used/neeed in our context?

• File _testenv/testenv.py:

  • Patch Set #2, Line 2: import logging

    please add some kind of copyright statement, license header and summary description to all of the python files here. Choice of license is up to you, copyright would be sysmocom, for anything done during working hours.

• File _testenv/testenv/osmo_dev.py:

  • Patch Set #2, Line 49: logging.error(testenv.src_dir)

    I see a some line wrapping that looks like its way before we hit the 120 character max line length of our coding style?

To view, visit change 37694. To unsubscribe, or for help writing mail filters, visit settings.