Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31482 )
Change subject: add unique_ids_test.c ......................................................................
Patch Set 1:
(4 comments)
File src/osmo-upf/upf.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3951): https://gerrit.osmocom.org/c/osmo-upf/+/31482/comment/5b4d635b_cc8941c3 PS1, Line 91: int upf_pfcp_listen(void) { open brace '{' following function definitions go on the next line
File tests/unique_ids/unique_ids_test.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3951): https://gerrit.osmocom.org/c/osmo-upf/+/31482/comment/07fcbb68_c9a284f5 PS1, Line 60: void select_poll(void) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3951): https://gerrit.osmocom.org/c/osmo-upf/+/31482/comment/9e97574f_10bf3277 PS1, Line 449: #if 1 Consider removing the #if 1 and its #endif
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3951): https://gerrit.osmocom.org/c/osmo-upf/+/31482/comment/d2172965_7ad3de9c PS1, Line 494: static void *fake_nft_ctx = (void*)0x1; "(foo*)" should be "(foo *)"