Attention is currently required from: matanp.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/32686
)
Change subject: cards: Add support for Gialer SIM cards
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File pySim/cards.py:
https://gerrit.osmocom.org/c/pysim/+/32686/comment/3e230f31_80afd147
PS1, Line 1668: def autodetect(kls, scc):
Unfortunately I don't have other sims to check for
false positives (and I couldn't find any document […]
maybe add the ATR as
comment, or simply assume they all have the same ATR?
File pySim/cards.py:
https://gerrit.osmocom.org/c/pysim/+/32686/comment/b6894548_00d3c0a7
PS4, Line 1713: why the '01' is required
this might specify whether it's OP or OPc? Or it might specify the algorithm?
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/32686
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icd2021aec630ac018f66ab565e03112047389e17
Gerrit-Change-Number: 32686
Gerrit-PatchSet: 4
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: matanp <matan1008(a)gmail.com>
Gerrit-Comment-Date: Fri, 12 May 2023 14:42:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: matanp <matan1008(a)gmail.com>
Gerrit-MessageType: comment