Attention is currently required from: laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 )
Change subject: context map: introduce RUA and SCCP FSMs to fix leaks ......................................................................
Patch Set 5:
(2 comments)
File include/osmocom/hnbgw/context_map.h:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/9590d2bc_29e51994 PS5, Line 22: enum map_rua_fsm_event {
not critical, but this is where the ISO/OSI style request/indication naming could be useful to clear […]
(hold on, the PLEASE_DISCONNECT should not be there anymore. Leftover from an intermediate patch state. will fix.)
RUA_EV_RX_ means a RUA PDU has arrived from HNB. SCCP_EV_RX_ means an SCCP PDU has arrived from CN.
the _EV_TX_ means that one FSM asks the other to forward a RANAP PDU to the remote peer.
I am not entirely clear how to apply the OSI terms to the FSM event names. So in the SCCP code, - the SCCP N_DATA towards CN is always sent as an N-Data.Request prim to osmo_sccp_user_sap_down(). - From the CN, we always receive an N-Data.Indication
In the RUA API, these terms apparently are not used. At least I don't see them in the code.
Would this be correct?
RUA HNBGW SCCP CN | --MAP_SCCP_EV_TX_REQUEST----> | --N-Data.Request-> | | <--MAP_RUA_EV_TX_INDICATION-- | <-N-Data.Ind------ |
(I want the "RX" name to be reserved for PDUs from a remote peer, and "TX" for PDU forwarding between internal FSMs.)
File src/osmo-hnbgw/hnbgw_rua.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/bce704c5_aec1ff88 PS5, Line 183: { RUA_ProcedureCode_id_Connect, "id-Connect" },
No, the procdures are not called "id-Connect", but "CONNECT". See the section headlines of 25.468 9. […]
ah ok, was not aware of that!