[M] Change in osmo-bts[master]: all models, HR1 codec: select RTP output format via vty option

Attention is currently required from: laforge, pespin, dexter. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32970 ) Change subject: all models, HR1 codec: select RTP output format via vty option ...................................................................... Patch Set 2: (3 comments) File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/32970/comment/55f41ae9_9ce7aa75 PS1, Line 333: bts->emit_hr_rfc5993 = true; The new patch implements defaults that match previous model-specific behavior. However, I am not using BTS feature flags, instead I have just one switch statement based on bts->variant in just one place where the default is set. Rationale: with the current code there is no inherent property in any BTS model that makes one format or the other more native for that model - instead the internal native format is always TS 101 318 for all models, while RFC 5993 remains an external format only. The "thing" being tested for the purpose of the default setting is not inherent properties of this or that BTS model, but existing behavior deployed in the field. Hence feature flags do not seem appropriate. File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32970/comment/fc7bc115_36fd830e PS1, Line 1705: send_rtp_rfc5993(lchan, fn, msg->data, msg->len); Done File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/32970/comment/23e2a037_da8ed4de PS1, Line 802: DEFUN(cfg_bts_rtp_hr_format, Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I168191874a062429a57904511a1e89e3f588732e Gerrit-Change-Number: 32970 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 May 2023 22:52:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment