Attention is currently required from: laforge, pespin, dexter.

View Change

3 comments:

• File src/common/bts.c:

  • Patch Set #1, Line 333: bts->emit_hr_rfc5993 = true;

    I am not sure if it is wise to have a static default. I am a bit worried about existing deployments. […]

    The new patch implements defaults that match previous model-specific behavior. However, I am not using BTS feature flags, instead I have just one switch statement based on bts->variant in just one place where the default is set. Rationale: with the current code there is no inherent property in any BTS model that makes one format or the other more native for that model - instead the internal native format is always TS 101 318 for all models, while RFC 5993 remains an external format only. The "thing" being tested for the purpose of the default setting is not inherent properties of this or that BTS model, but existing behavior deployed in the field. Hence feature flags do not seem appropriate.

• File src/common/l1sap.c:

  • Patch Set #1, Line 1705: send_rtp_rfc5993(lchan, fn, msg->data, msg->len);

    Good point. […]

    Done

• File src/common/vty.c:

  • Patch Set #1, Line 802: DEFUN(cfg_bts_rtp_hr_format,

    Point taken - I shall look into doing what you suggest.

    Done

To view, visit change 32970. To unsubscribe, or for help writing mail filters, visit settings.