Attention is currently required from: pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31170 )
Change subject: rlcmac: Initial ul_tbf data support ......................................................................
Patch Set 10:
(9 comments)
File include/osmocom/gprs/rlcmac/rlc_window_ul.h:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31170/comment/1b59c661_14e06836 PS10, Line 72: uint16_t ssn, uint16_t *lost, uint16_t *received); weird indent, neither pure tabs nor aligns
File src/rlcmac/coding_scheme.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31170/comment/9af3bbed_4216a0fd PS10, Line 312: default: *need_stuffing = false; break; odd single-line style for switch cases
File src/rlcmac/rlc.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31170/comment/25a4afa8_fd5812b8 PS10, Line 100: (extra blank)
https://gerrit.osmocom.org/c/libosmo-gprs/+/31170/comment/595ef7f2_794a485f PS10, Line 273: (trailing blank)
File src/rlcmac/rlc_window.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31170/comment/31cad603_4bd0eca2 PS10, Line 77: (trailing blank ... just saying because git marks those red for me, seems to be a thing)
File src/rlcmac/rlc_window_ul.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31170/comment/cd3b0837_c833d00a PS10, Line 28: (extra blank)
https://gerrit.osmocom.org/c/libosmo-gprs/+/31170/comment/54ddb22e_b769b45a PS10, Line 357: ()
File src/rlcmac/rlcmac_enc.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31170/comment/deb9580d_df15563a PS10, Line 233: \brief we have AUTOBRIEF, can drop the \brief
File src/rlcmac/tbf_ul_fsm.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31170/comment/8433f1d6_5d652a6a PS10, Line 44: [GPRS_RLCMAC_TBF_UL_ST_FINISHED] = { }, (may omit unset ones)