Attention is currently required from: pespin, fixeria.

View Change

9 comments:

• File include/osmocom/gprs/rlcmac/rlc_window_ul.h:

  • Patch Set #10, Line 72: uint16_t ssn, uint16_t *lost, uint16_t *received);

    weird indent, neither pure tabs nor aligns

• File src/rlcmac/coding_scheme.c:

  • Patch Set #10, Line 312: default: *need_stuffing = false; break;

    odd single-line style for switch cases

• File src/rlcmac/rlc.c:

  • Patch Set #10, Line 100:

    (extra blank)

  • Patch Set #10, Line 273:

    (trailing blank)

• File src/rlcmac/rlc_window.c:

  • Patch Set #10, Line 77:

    (trailing blank ... just saying because git marks those red for me, seems to be a thing)

• File src/rlcmac/rlc_window_ul.c:

  • Patch Set #10, Line 28:

    (extra blank)

  • Patch Set #10, Line 357:

    ()

• File src/rlcmac/rlcmac_enc.c:

  • Patch Set #10, Line 233: \brief

    we have AUTOBRIEF, can drop the \brief

• File src/rlcmac/tbf_ul_fsm.c:

  • Patch Set #10, Line 44: [GPRS_RLCMAC_TBF_UL_ST_FINISHED] = { },

    (may omit unset ones)

To view, visit change 31170. To unsubscribe, or for help writing mail filters, visit settings.