21 Sep
2022
21 Sep
'22
8:02 p.m.
Attention is currently required from: neels, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 )
Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git
......................................................................
Patch Set 2:
(6 comments)
File src/llc/llc_pdu.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/df71591c_ac7c1ae1
PS2, Line 80: void osmo_gprs_llc_pdu_hdr_dump_buf(const struct osmo_gprs_llc_pdu_decoded
*pdu,
Ack, will do in the next patch set.
Done
https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/066162ca_fcad0f43
PS2, Line 144: addr[0] |= pdu->sapi & 0x0f;
Ack
Done
https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/36b3be82_eb6cd1a2
PS2, Line 166: OSMO_ASSERT(pdu->sack.len > 0);
hmm, mildly disagree with OSMO_ASSERT() in a library
function, would be more polite to return an err […]
Done
https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/48b67f10_1820e698
PS2, Line 293: check_len(sizeof(*addr), "missing Address field");
addr being a uint8_t*, sizeof(*addr) is a very
elaborate and possibly confusing way to write "1". […]
Done
https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/bc5ce49e_b540743d
PS2, Line 326: check_len(sizeof(*ctrl), "missing Control field");
s/sizeof(*ctrl)/1
Done
File tests/llc_pdu_codec/pdu_codec_test.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/345325ad_425f053a
PS2, Line 66: struct msgb *msg = msgb_alloc(1024, "LLC-PDU");
... so that the code looks more like Pascal ;) […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d
Gerrit-Change-Number: 29402
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Sep 2022 18:02:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment