Attention is currently required from: neels, pespin.

View Change

6 comments:

• File src/llc/llc_pdu.c:

  • Patch Set #2, Line 80: void osmo_gprs_llc_pdu_hdr_dump_buf(const struct osmo_gprs_llc_pdu_decoded *pdu,

    Ack, will do in the next patch set.

    Done

  • Patch Set #2, Line 144: addr[0] |= pdu->sapi & 0x0f;

    Ack

    Done

  • Patch Set #2, Line 166: OSMO_ASSERT(pdu->sack.len > 0);

    hmm, mildly disagree with OSMO_ASSERT() in a library function, would be more polite to return an err […]

    Done

  • Patch Set #2, Line 293: check_len(sizeof(*addr), "missing Address field");

    addr being a uint8_t*, sizeof(*addr) is a very elaborate and possibly confusing way to write "1". […]

    Done

  • Patch Set #2, Line 326: check_len(sizeof(*ctrl), "missing Control field");

    s/sizeof(*ctrl)/1

    Done

• File tests/llc_pdu_codec/pdu_codec_test.c:

  • Patch Set #2, Line 66: struct msgb *msg = msgb_alloc(1024, "LLC-PDU");

    ... so that the code looks more like Pascal ;) […]

    Done

To view, visit change 29402. To unsubscribe, or for help writing mail filters, visit settings.