Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/37393?usp=email )
Change subject: support RAB Assignment in cn_ranap_rx_*_msg_co() ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-iuh/+/37393/comment/5e12c63c_18a273d4 PS2, Line 20: Procedure", but doesn't
My humble conclusion is to just accept all the variants that an implementation could sensibly choose […]
The way how its specified in the ASN.1 syntax: ``` rAB-Assignment RANAP-ELEMENTARY-PROCEDURE ::= { INITIATING MESSAGE RAB-AssignmentRequest OUTCOME RAB-AssignmentResponse PROCEDURE CODE id-RAB-Assignment CRITICALITY reject } ```
The way how I read this that the RAB assignment procedure should never have a SUCCESSFUL OUTCOME or an UNUSUCCESSFUL OUTCOME, but always _only_ OUTCOME. RAB-assinment, sRVCCPreparation and ueRadioCapabilityMatch are the only three procedures in the RANAP-PDU-Descriptions that have this.
I'm not saying any of this as an argument to change your code - I'm just stating it to clarify what the spec says.