Attention is currently required from: laforge.
matanp has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/32686 )
Change subject: cards: Add support for Gialer SIM cards
......................................................................
Patch Set 4:
(2 comments)
File pySim/cards.py:
https://gerrit.osmocom.org/c/pysim/+/32686/comment/ab910fa8_c7a48886
PS1, Line 1668: def autodetect(kls, scc):
maybe add the ATR as comment, or simply assume they
all have the same ATR?
Seems like it has a unique
https://pcsc-tools.apdu.fr/smartcard_list.txt - I will check it and update, thanks a lot!
File pySim/cards.py:
https://gerrit.osmocom.org/c/pysim/+/32686/comment/d798324a_3ff4236f
PS4, Line 1713: why the '01' is required
this might specify whether it's OP or OPc? Or it
might specify the algorithm?
From their programming software, programming OP
calculate and burns OPc. I will check the algorithm idea, thanks!
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/32686
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icd2021aec630ac018f66ab565e03112047389e17
Gerrit-Change-Number: 32686
Gerrit-PatchSet: 4
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 12 May 2023 15:06:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: matanp <matan1008(a)gmail.com>
Gerrit-MessageType: comment