osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27953 )
Change subject: bts_trx_vty: adjust TSC warning message ......................................................................
bts_trx_vty: adjust TSC warning message
Since 2019, libosmocore aborts when vty commands return CMD_WARNING (a0c8195ad37292ab800a6c777fc28383995b4b64). Don't tell the user that BCC will be used as fallback because unless libosmocore is really old, it will stop here.
I found this while changing related code to only do this check after BTS reported its features, see next patch.
Related: SYS#5922, OS#5538 Change-Id: I041150c9ce27caca6029ed54444562bb6cdcc57a --- M src/osmo-bsc/bts_trx_vty.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/53/27953/1
diff --git a/src/osmo-bsc/bts_trx_vty.c b/src/osmo-bsc/bts_trx_vty.c index 27bba2c..eac6639 100644 --- a/src/osmo-bsc/bts_trx_vty.c +++ b/src/osmo-bsc/bts_trx_vty.c @@ -318,8 +318,7 @@ struct gsm_bts_trx_ts *ts = vty->index;
if (!osmo_bts_has_feature(&ts->trx->bts->features, BTS_FEAT_MULTI_TSC)) { - vty_out(vty, "%% This BTS does not support a TSC != BCC, " - "falling back to BCC%s", VTY_NEWLINE); + vty_out(vty, "%% This BTS does not support a TSC != BCC%s", VTY_NEWLINE); ts->tsc = -1; return CMD_WARNING; }