Attention is currently required from: fixeria, pespin.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/30683 )
Change subject: SMPP: refactor ref counting code
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/30683/comment/d3aaf1f3_748fa2b3
PS1, Line 9: single-use static function to simplify
What's wrong with having this static function? The
compiler will highly likely inline it anyway. […]
There's nothing wrong with the
function. But the changes in subsequent patch make it effectively pointless so I'd
rather get rid of it before to make follow-up patch easier to review.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/30683
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9cb530991f54aa78edaa885f1242f63c705b6fcb
Gerrit-Change-Number: 30683
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 14 Jan 2023 18:07:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment