Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646?usp=email )
Change subject: stp: NOTIFY expectancy fixes
......................................................................
Patch Set 1:
(1 comment)
File stp/STP_Tests_M3UA.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646/comment/968af7cf_dadc…
:
PS1, Line 798: f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE,
rctxB));
: f_M3UA_exp(0, tr_M3UA_DAVA({*}, rctxA));
: f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE,
rctxA));
: f_M3UA_exp(0, tr_M3UA_DAVA({*}, rctxB));
Acknowledged
Just for completeness, I guess most
of those tests had the "rctx passing" as "TODO" because ttcn3 failed
to properly decode the NOTIFY messages and hence wouldn't match if expecting a given
rctx. That's fixed after the patch I submitted upstream for
titan.ProtocolModules.M3UA.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3a56b4fcb8c119a31815f3175db2d7899fbfddd7
Gerrit-Change-Number: 39646
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 03 Mar 2025 09:37:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>