Attention is currently required from: pespin.
daniel has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40294?usp=email )
Change subject: m3ua: Discard rx MSUs for non-active AS
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/m3ua.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40294/comment/1df0c92c_07137…
:
PS1, Line 625: if (rc) {
I thought our linter explicitly flagged braces in single if statements, also the
(optically more complex) if-else in line 617 is without braces.
(I don't really care for enforcing that rule, just pointing it out)
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40294?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibd3c85b9c5ac24fe1447c82b1f2cff4453105b84
Gerrit-Change-Number: 40294
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 13 May 2025 13:53:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes