Attention is currently required from: fixeria, osmith.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35124?usp=email )
Change subject: Add GSMTAP encapsulation of RLP frames in CSD NT mode ......................................................................
Patch Set 6:
(4 comments)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/35124/comment/cd2e5146_6136d7a8 PS6, Line 1854: if (!inst || !trx->bts->gsmtap.rlp)
We also need to check `if (lchan->csd_mode == LCHAN_CSD_M_NT)`, otherwise we would be emitting garba […]
Done
https://gerrit.osmocom.org/c/osmo-bts/+/35124/comment/7468b140_31128147 PS6, Line 1866: 2x
Actually it's `4x36bit` for TCH/H2.4. […]
Done
https://gerrit.osmocom.org/c/osmo-bts/+/35124/comment/0ab2c337_6d368a94 PS6, Line 1867: TCH/H 14.4
TCH/F, not half-rate.
Done
https://gerrit.osmocom.org/c/osmo-bts/+/35124/comment/9b562d2d_e4bb0b2d PS6, Line 1879: } else {
I think it's fine to have it enabled in general. […]
Done