Attention is currently required from: laforge, tnt.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/34554?usp=email )
Change subject: Automatically reset RIFO on underrun/overflow
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
ping? @andreas@eversberg.eu ? This has been waiting for feedback for almost 2 months now.
I have no idea how for a strategy when to reset the RIFO buffer. A single frame that is out of range causes a reset in this patchset. How can we determine, if that frame is an outlier or if both ends became out of sync and a reset is required? Defining some threshold for frames out of sync is not a good solution, because then we have several frame drops and unstable link before we reset.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-e1d/+/34554?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Id7ccbfbdb288990c01f185dec79a1022a68b4748
Gerrit-Change-Number: 34554
Gerrit-PatchSet: 3
Gerrit-Owner: jolly
andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: manawyrm
osmocom.account@tbspace.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Reviewer: tnt
tnt@246tNt.com
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: tnt
tnt@246tNt.com
Gerrit-Comment-Date: Mon, 18 Dec 2023 08:58:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Gerrit-MessageType: comment