Attention is currently required from: osmith.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/37011?usp=email )
Change subject: add contrib/saip-tool.py
......................................................................
Patch Set 4:
(2 comments)
File contrib/saip-tool.py:
https://gerrit.osmocom.org/c/pysim/+/37011/comment/ab0eec01_409010f0
PS3, Line 99: #pp.pprint(pe.decoded[d])
: #if pe.type in ['akaParameter',
'pinCodes', 'pukCodes']:
: # pp.pprint(pe.decoded)
do you want to keep this?
Done
https://gerrit.osmocom.org/c/pysim/+/37011/comment/8bc93f0b_8f99a276
PS3, Line 161: else:
: parser.print_help(sys.stderr)
: sys.exit(2)
this can be removed since opts. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/37011?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I396bcd594e0628dfc26bd90233317a77e2f91b20
Gerrit-Change-Number: 37011
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 09 Jun 2024 10:19:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment