Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38107?usp=email )
Change subject: libvlr: replace direct call of paging_expired() into a callback ......................................................................
Patch Set 2:
(1 comment)
File src/libmsc/sgs_iface.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38107/comment/3ceff42d_21b91a81?usp=... : PS2, Line 473: int sgs_iface_tx_paging(struct vlr_subscr *vsub, enum sgsap_service_ind serv_ind)
Can we also please rename this to have _cb in it? and also remove the "tx" part of it since it's now […]
@pespin as alternative, I could add a second callback to the SGS/VLR? I don't have a strong opinion which one is "better". I feel like decoupling things which shouldn't be merged in the first place.