Attention is currently required from: osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31062 )
Change subject: Introduce netdev API
......................................................................
Patch Set 5:
(5 comments)
File src/core/netdev.c:
https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/3165e326_301d2eb3
PS5, Line 61: )
missing : for consistency with other comments
Ack
https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/a3bc32ce_44973d6e
PS5, Line 199: /* find the netdev for the netdev (if any) */
I find this line more confusing than helpful. Maybe
remove it? […]
This was wrong indeed, I'm simply removing it.
https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/67f549db_4279ea4b
PS5, Line 247: recounted
refcounted
Ack
https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/651143fc_25fea661
PS5, Line 394: }
Looks like error handling for the !ifname case is
missing here
No, that's fine, we simply want to update the ifname if we find it.
If no ifname is found we don't care since we identify ifaces by ifindex now.
https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/94f29c3b_cd08e000
PS5, Line 437: osmo_nedev
osmo_netdev
Ack
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31062
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7a00c0445a89e088676a4897061b65196d9197f1
Gerrit-Change-Number: 31062
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Jan 2023 15:06:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment