Attention is currently required from: osmith.

View Change

5 comments:

• File src/core/netdev.c:

  • Patch Set #5, Line 61: )

    missing : for consistency with other comments

    Ack

  • Patch Set #5, Line 199: /* find the netdev for the netdev (if any) */

    I find this line more confusing than helpful. Maybe remove it? […]

    This was wrong indeed, I'm simply removing it.

  • Patch Set #5, Line 247: recounted

    refcounted

    Ack

  • Patch Set #5, Line 394: }

    Looks like error handling for the !ifname case is missing here

    No, that's fine, we simply want to update the ifname if we find it. If no ifname is found we don't care since we identify ifaces by ifindex now.

  • Patch Set #5, Line 437: osmo_nedev

    osmo_netdev

    Ack

To view, visit change 31062. To unsubscribe, or for help writing mail filters, visit settings.