Attention is currently required from: laforge, fixeria, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30946 )
Change subject: gsm_utils: improve gsm_gsmtime2fn()
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/30946/comment/0af8d98d_17ed1489
PS2, Line 11: functions, so lets use OSMO_MOD_FLR() instead. Also arange the formula
arrange
Done
File src/gsm/gsm_utils.c:
https://gerrit.osmocom.org/c/libosmocore/+/30946/comment/e4b3b4af_6bf0f6c2
PS2, Line 893: TS 04.08
Let's better use the new spec. numbers: TS 44.008, TS 45.002. TS 48.058.
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30946
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibf94bca8223f1f7858a6dd67bf27de0ab6feab20
Gerrit-Change-Number: 30946
Gerrit-PatchSet: 3
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 12 Jan 2023 14:33:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment