Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30986 )
Change subject: socket.h: Introduce API osmo_sockaddr_netmask_to_prefixlen()
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
File src/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/3993ed4e_ed15d8a0
PS2, Line 1306:
cosmetic: no need for a space
Done
https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/533d126a_2da27274
PS2, Line 1323:
cosmetic: no need for a space
Done
File tests/socket/socket_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/d7059695_59e1d04e
PS2, Line 420: chcking
checking, same below
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30986
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I75e75e251c6776801fffdde745aebedf21c68799
Gerrit-Change-Number: 30986
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Jan 2023 09:57:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment