neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31429 )
Change subject: sccp_sap_up(): ignore PCSTATE.ind ......................................................................
sccp_sap_up(): ignore PCSTATE.ind
Silence the error log about "unknown" PCSTATE prim.
Todo / coming up: instead of ignoring, detect a Destination Unavailable from prim->u.pcstate and disconnect all conns with that particular CN link.
Depends: libosmo-sccp If381f537ab91af1feef7f0e51921217f27e18e6a Change-Id: I547387a5cc14ccb506be04ac785e6807fc4e6a96 --- M TODO-RELEASE M src/osmo-hnbgw/hnbgw_cn.c 2 files changed, 21 insertions(+), 0 deletions(-)
Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved
diff --git a/TODO-RELEASE b/TODO-RELEASE index 84cc2ea..cec63db 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -9,3 +9,4 @@ #library what description / commit summary line osmo-hnbgw cfg config deprecated: 'sccp cr max-payload-len <0-999999>' libosmo-sigtran >=1.7.0 Ensure SCCP CR max payload length of 130 bytes is enforced. + Uses osmo_scu_prim_hdr_name_c() diff --git a/src/osmo-hnbgw/hnbgw_cn.c b/src/osmo-hnbgw/hnbgw_cn.c index 731c758..856bf79 100644 --- a/src/osmo-hnbgw/hnbgw_cn.c +++ b/src/osmo-hnbgw/hnbgw_cn.c @@ -430,6 +430,10 @@ case OSMO_PRIM(OSMO_SCU_PRIM_N_DISCONNECT, PRIM_OP_INDICATION): rc = handle_cn_disc_ind(cnlink, &prim->u.disconnect, oph); break; + case OSMO_PRIM(OSMO_SCU_PRIM_N_PCSTATE, PRIM_OP_INDICATION): + LOGP(DMAIN, LOGL_DEBUG, "Ignoring prim %s from SCCP USER SAP\n", + osmo_scu_prim_hdr_name_c(OTC_SELECT, oph)); + break; default: LOGP(DMAIN, LOGL_ERROR, "Received unknown prim %u from SCCP USER SAP\n",