laforge has posted comments on this change by laforge. (
https://gerrit.osmocom.org/c/pysim/+/38047?usp=email )
Change subject: pySim.commands: use _checksw during get_data() method
......................................................................
Patch Set 4:
(1 comment)
File pySim/commands.py:
https://gerrit.osmocom.org/c/pysim/+/38047/comment/fc05b02c_8a699b73?usp=em… :
PS3, Line 798: data, sw = self.send_apdu_checksw('%02xca%04x00' % (cla,
tag))
maybe put a spec ref on top of the method? Something
like: […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/38047?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic784bf0c30b22e5e83843aa6694e2706b4b2ac48
Gerrit-Change-Number: 38047
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 10 Sep 2024 18:40:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>