Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email )
Change subject: Introduce tests/osmo-config-merge testsuite ......................................................................
Patch Set 4:
(5 comments)
File tests/osmo-config-merge/Makefile.am:
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/b1b79b57_d68da1eb?u... : PS4, Line 25: } >'$(srcdir)/package.m4'
I'd try to remove it and see if it still works
Done
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/965705f5_dd99afb0?u... : PS4, Line 46: [ -e /proc/cpuinfo ] && cat /proc/cpuinfo
Acknowledged
Done
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/9b3ecb3a_f8b9646a?u... : PS4, Line 47: $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS)
Acknowledged
Done
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/f300cbf2_dcc2b90f?u... : PS4, Line 51: $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS)
Acknowledged
Done
File tests/osmo-config-merge/atlocal.in:
PS4:
Yes, otherwise it failed when generating stuff iirc at configure time.
Done