- gerrit-log - lists.osmocom.org

Change in pysim[master]: contrib/jenkins.sh: speed up pylint by running multiple processes
by pespin 30 Aug '22

30 Aug '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29240 ) Change subject: contrib/jenkins.sh: speed up pylint by running multiple processes ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I76d1696c27ddcab358526f807c4a0a7f0d4c85d4 Gerrit-Change-Number: 29240 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Aug 2022 11:54:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in pysim[master]: contrib/jenkins.sh: pylint v2.15 is unstable, pin v2.14.5
by pespin 30 Aug '22

30 Aug '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29239 ) Change subject: contrib/jenkins.sh: pylint v2.15 is unstable, pin v2.14.5 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie29be6ec6631ff2b3d8cd6b2dd9ac0ed8f505e4f Gerrit-Change-Number: 29239 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Aug 2022 11:54:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in pysim[master]: contrib/jenkins.sh: install dependencies from requirements.txt
by pespin 30 Aug '22

30 Aug '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29237 ) Change subject: contrib/jenkins.sh: install dependencies from requirements.txt ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I99af496e9a3758ea624ca484f4fbc51b262ffaf4 Gerrit-Change-Number: 29237 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Aug 2022 11:52:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in pysim[master]: contrib/jenkins.sh: execute this script with -x and -e
by pespin 30 Aug '22

30 Aug '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29236 ) Change subject: contrib/jenkins.sh: execute this script with -x and -e ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I13af70ef770936bec00b050b6c4f988e53ee2833 Gerrit-Change-Number: 29236 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Aug 2022 11:52:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in pysim[master]: README.md: update installation instructions for Debian
by pespin 30 Aug '22

30 Aug '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29235 ) Change subject: README.md: update installation instructions for Debian ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icefa33570a34960a4fff145f3c1b6585d867605c Gerrit-Change-Number: 29235 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Aug 2022 11:51:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in pysim[master]: README.md: update git URLs (git -> https; gitea)
by pespin 30 Aug '22

30 Aug '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29234 ) Change subject: README.md: update git URLs (git -> https; gitea) ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia86979f656557e442b0f432b0646aa7661c293e9 Gerrit-Change-Number: 29234 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Aug 2022 11:51:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD
by pespin 30 Aug '22

30 Aug '22

Attention is currently required from: neels, laforge, fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Patch Set 15: (7 comments) File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/99187a07_486bf644 PS15, Line 642: /* optional: importance */ why is this line removed here? this is non related. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/22584621_ed05b35e PS15, Line 600: if ( > in whihc situation would we have a zero-length opt_data_cache? Ack https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/95f59ccb_f6e0401e PS15, Line 606: } else remove curly braces in the if. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/76465829_27cd148a PS15, Line 630: if (xua_drop_data_check(prim, SCCP_MAX_DATA, "cache overrun")) ...check_drop(), otherwise it's not clear what you are checking and it's confusing since you actually check for drop and return the opposite to keep it. Actually, since you call this function _keep(), it would make sense to reverse the loginc on the xua_drop_data_check() function... I would even drop the function completely tbh. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/1e4a2119_e4a3eef7 PS15, Line 635: LOGP(DLSCCP, LOGL_ERROR, "replacing unsent %u bytes of optional data cache with %s optional data\n", NOTICE https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/fba00b9f_9b6214fd PS15, Line 639: msgb_alloc(SCCP_MAX_DATA, "SCCP optional data cache for CR/CC/RLSD"); > If we ever should run into memory leaks, it would be better to use msgb_alloc_c(conn) to attach this […] Ack https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/d53cddbe_6bbb5c85 PS15, Line 784: xua_msg_add_sccp_addr(xua, SUA_IEI_DEST_ADDR, &conn->calling_addr); why is this line removed here? this is non related. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 15 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Aug 2022 11:49:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

Change in osmo-hlr[master]: Set working directory in systemd service file
by pespin 30 Aug '22

30 Aug '22

Attention is currently required from: osmith, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29225 ) Change subject: Set working directory in systemd service file ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I40b5d50470cb55ca94af5e17f21658181a02d4c2 Gerrit-Change-Number: 29225 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Aug 2022 11:38:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ggsn[master]: Set working directory in systemd service file
by pespin 30 Aug '22

30 Aug '22

Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/29223 ) Change subject: Set working directory in systemd service file ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Are these directories created automatically? or are they needed to be created during package installation? -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/29223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idffc115c21cac77f6f43356333de538ba549fc6a Gerrit-Change-Number: 29223 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Aug 2022 11:37:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ggsn[master]: Ignore .deb build byproducts
by pespin 30 Aug '22

30 Aug '22

Attention is currently required from: fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/29224 ) Change subject: Ignore .deb build byproducts ...................................................................... Patch Set 2: (1 comment) File .gitignore: https://gerrit.osmocom.org/c/osmo-ggsn/+/29224/comment/edce9888_df78ed9f PS2, Line 27: # debian > I suggest to move your new entries here, so that we have all debian stuff in one place. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/29224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iec63ef5ea0acfc5e6621054926be15ae4754d65d Gerrit-Change-Number: 29224 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Aug 2022 11:36:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log