pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40626?usp=email )
Change subject: sccp: Avoid setting default local HNBGW PC as default remote PC
......................................................................
sccp: Avoid setting default local HNBGW PC as default remote PC
It makes no sense to set the remote PC of MSC/SGSN to the default local
HNBGW PC. Instead, set it to the default remote PC of the pool (sgsn vs msc),
as already done in "else" code path in hnbgw_cnlink_start_or_restart()
calling osmo_sccp_make_addr_pc_ssn().
Change-Id: I43b9ab7a06bcaa8bea91f9f54fca0993a67340d7
---
M src/osmo-hnbgw/cnlink.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/26/40626/1
diff --git a/src/osmo-hnbgw/cnlink.c b/src/osmo-hnbgw/cnlink.c
index 0bd2b3d..ea53ee0 100644
--- a/src/osmo-hnbgw/cnlink.c
+++ b/src/osmo-hnbgw/cnlink.c
@@ -456,7 +456,7 @@
/* Instead of comparing whether the address book entry names are different, actually resolve the
* resulting SCCP address, and only restart the cnlink if the resulting address changed. */
- resolve_addr_name(&remote_addr, &ss7, cnlink->vty.remote_addr_name, NULL, DEFAULT_PC_HNBGW);
+ resolve_addr_name(&remote_addr, &ss7, cnlink->vty.remote_addr_name, NULL, cnlink->pool->default_remote_pc);
if (osmo_sccp_addr_cmp(&remote_addr, &cnlink->remote_addr, OSMO_SCCP_ADDR_T_PC | OSMO_SCCP_ADDR_T_SSN))
changed = true;
} else if (cnlink->vty.remote_addr_name != cnlink->use.remote_addr_name) {
@@ -509,7 +509,7 @@
* in a specific cs7 instance. If it is not set, leave ss7 == NULL to use cs7 instance 0. */
if (cnlink->use.remote_addr_name) {
if (resolve_addr_name(&cnlink->remote_addr, &ss7, cnlink->use.remote_addr_name, cnlink->name,
- DEFAULT_PC_HNBGW)) {
+ cnlink->pool->default_remote_pc)) {
LOG_CNLINK(cnlink, DCN, LOGL_ERROR, "cannot initialize SCCP: there is no SCCP address named '%s'\n",
cnlink->use.remote_addr_name);
return -ENOENT;
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40626?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I43b9ab7a06bcaa8bea91f9f54fca0993a67340d7
Gerrit-Change-Number: 40626
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40592?usp=email )
Change subject: hnbgw: Introduce test TC_stat_stp_sctp_disconnected
......................................................................
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40592?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I079f2da09ff8d52e614ff6f5d267cd5429e4eb58
Gerrit-Change-Number: 40592
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 08 Jul 2025 14:41:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40623?usp=email )
Change subject: bsc: Avoid running TC_stat_msc_sctp_disconnected in latest
......................................................................
bsc: Avoid running TC_stat_msc_sctp_disconnected in latest
The osmo-stp in latest release, aside from not yet implementing the
"shutdown" cmd (which is known and hence test was expected to fail
there), has a side effect of ending up with a broken state after
restarting the ASP during got_parent() VTY node exit, where ASP is
ends up in ASP_DOWN and AS in AS_ACTIVE. This generates failures in all
tests after this one._
Change-Id: Icce4ec089b300f418e957ab67464759c782811a4
Related: OS#5917
Related: SYS#7501
Fixes: 40c73568c77ee3747a02fce2cf031d723a938207
---
M bsc/BSC_Tests.ttcn
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index d246b90..3dc2298 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -12701,7 +12701,12 @@
execute( TC_stat_num_bts_connected_1() );
execute( TC_stat_num_bts_connected_2() );
execute( TC_stat_num_bts_connected_3() );
- execute( TC_stat_msc_sctp_disconnected() );
+ /* This "nightly" if can be removed once libosmo-sigtran (osmo-stp) > 2.1.0 is released.
+ * Currently released osmo-stp 2.1.0 ends up in in broken AS-ACTIVE+ASP-DOWN state when
+ * restarting the ASP after exiting the related asp node through VTY: */
+ if (Misc_Helpers.f_osmo_repo_is("nightly")) {
+ execute( TC_stat_msc_sctp_disconnected() );
+ }
execute( TC_ctrl() );
if (mp_bssap_cfg[0].transport == BSSAP_TRANSPORT_SCCPlite_SERVER) {
execute( TC_ctrl_location() );
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40623?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icce4ec089b300f418e957ab67464759c782811a4
Gerrit-Change-Number: 40623
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40623?usp=email )
Change subject: bsc: Avoid running TC_stat_msc_sctp_disconnected in latest
......................................................................
bsc: Avoid running TC_stat_msc_sctp_disconnected in latest
The osmo-stp in latest release, aside from not yet implementing the
"shutdown" cmd (which is known and hence test was expected to fail
there), has a side effect of ending up with a broken state after
restarting the ASP during got_parent() VTY node exit, where ASP is
ends up in ASP_DOWN and AS in AS_ACTIVE. This generates failures in all
tests after this one._
Change-Id: Icce4ec089b300f418e957ab67464759c782811a4
Related: OS#5917
Related: SYS#7501
Fixes: 40c73568c77ee3747a02fce2cf031d723a938207
---
M bsc/BSC_Tests.ttcn
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/40623/1
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index d246b90..3dc2298 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -12701,7 +12701,12 @@
execute( TC_stat_num_bts_connected_1() );
execute( TC_stat_num_bts_connected_2() );
execute( TC_stat_num_bts_connected_3() );
- execute( TC_stat_msc_sctp_disconnected() );
+ /* This "nightly" if can be removed once libosmo-sigtran (osmo-stp) > 2.1.0 is released.
+ * Currently released osmo-stp 2.1.0 ends up in in broken AS-ACTIVE+ASP-DOWN state when
+ * restarting the ASP after exiting the related asp node through VTY: */
+ if (Misc_Helpers.f_osmo_repo_is("nightly")) {
+ execute( TC_stat_msc_sctp_disconnected() );
+ }
execute( TC_ctrl() );
if (mp_bssap_cfg[0].transport == BSSAP_TRANSPORT_SCCPlite_SERVER) {
execute( TC_ctrl_location() );
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40623?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icce4ec089b300f418e957ab67464759c782811a4
Gerrit-Change-Number: 40623
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>