July 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-remsim[master]: bankd: implicit remove a client mapping when creating a new mapping

by lynxis lazus

Attention is currently required from: Hoernchen, laforge, lynxis lazus. Hello Hoernchen, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/40570?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: bankd: implicit remove a client mapping when creating a new mapping ...................................................................... bankd: implicit remove a client mapping when creating a new mapping After a desynchronisation between the server and bankd happen (e.g. restart the server), the server might request a mapping between a client slot and a bankd slot while the bankd still has a different mapping for the same client slot. Example before this commit: * server -> bankd: New Mapping (client 1/0, bankd 1/0) * server <- bankd: Ack * Restart server * server -> bankd: New Mapping (client 1/0, bankd 2/0) * server <- bankd: Reject (commit change to Ack) Previous the second mapping got rejected, while the server had no chance of knowing or asking the bankd about the old mapping. Related: SYS#7470 Change-Id: Iae3f86a6e695e2d6580151b203df1dd0e2db625b --- M src/bankd/bankd_main.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/70/40570/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/40570?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Iae3f86a6e695e2d6580151b203df1dd0e2db625b Gerrit-Change-Number: 40570 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 5 days

1
0
0 0

[M] Change in pysim[master]: smdpp: less verbose by default

by laforge

Attention is currently required from: Hoernchen, dexter, lynxis lazus. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40468?usp=email ) Change subject: smdpp: less verbose by default ...................................................................... Patch Set 11: (1 comment) File osmo-smdpp.py: https://gerrit.osmocom.org/c/pysim/+/40468/comment/a91458ea_95a41cde?usp=em… : PS6, Line 370: logger.debug("Tx JSON: %s" % json.dumps(output)[:200]) > Done I still see % being used and no "if clause". I think @lynxis point was to either move from % to comma or use the if-clause? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I04a72b8f52417862d4dcba1f0743700dd942ef49 Gerrit-Change-Number: 40468 Gerrit-PatchSet: 11 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Jul 2025 18:41:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 5 days

1
0
0 0

[M] Change in libosmo-sigtran[master]: as: Avoid adding dyn route when IPA AS becomes active

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40580?usp=email ) Change subject: as: Avoid adding dyn route when IPA AS becomes active ...................................................................... as: Avoid adding dyn route when IPA AS becomes active It makes no sense to do so nowadays: * ASP role: the routing-key PC points to a local PC, and hence it's not really used during routing. * SG role: This would only make sense if we somehow supported dynamic IP AS, which we don't support (only IPA ASP). Hence, the AS is always configured and hence the user is responsible of filling the routing table with an appropriate entry towards the peer's DPC. Change-Id: I8997d40f2a779734432b40d27f9345d9a739d36f --- M src/xua_as_fsm.c 1 file changed, 0 insertions(+), 78 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/80/40580/1 diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c index 71049d5..7d8e302 100644 --- a/src/xua_as_fsm.c +++ b/src/xua_as_fsm.c @@ -265,7 +265,6 @@ struct osmo_timer_list t_r; struct llist_head queued_xua_msgs; } recovery; - bool ipa_route_created; }; static void fill_notify_statchg_pars(const struct osmo_fsm_inst *fi, struct osmo_xlm_prim_notify *npar) @@ -291,79 +290,6 @@ } } -/* is the given AS one with a single ASP of IPA type? */ -static bool is_single_ipa_asp(struct osmo_ss7_as *as) -{ - unsigned int asp_count = 0; - int i; - - for (i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { - struct osmo_ss7_asp *asp = as->cfg.asps[i]; - if (!asp) - continue; - asp_count++; - if (asp->cfg.proto != OSMO_SS7_ASP_PROT_IPA) - return false; - } - if (asp_count == 1) - return true; - return false; -} - -static void ipa_add_route(struct osmo_fsm_inst *fi) -{ - struct xua_as_fsm_priv *xafp = (struct xua_as_fsm_priv *) fi->priv; - struct osmo_ss7_as *as = xafp->as; - struct osmo_ss7_instance *inst = as->inst; - - if (ss7_route_table_find_route_by_dpc_mask(inst->rtable_system, - as->cfg.routing_key.pc, 0xffffff, - true)) - return; - - /* As opposed to M3UA, there is no RKM and we have to implicitly - * automatically add a dynamic route once an IPA connection has come up */ - if (ss7_route_create(inst->rtable_system, as->cfg.routing_key.pc, 0xffffff, true, as->cfg.name)) - xafp->ipa_route_created = true; -} - -static void ipa_del_route(struct osmo_fsm_inst *fi) -{ - struct xua_as_fsm_priv *xafp = (struct xua_as_fsm_priv *) fi->priv; - struct osmo_ss7_as *as = xafp->as; - struct osmo_ss7_instance *inst = as->inst; - struct osmo_ss7_route *rt; - - /* don't delete a route if we added none */ - if (!xafp->ipa_route_created) - return; - - /* find the route which we have created if we ever reached ipa_asp_fsm_wait_id_ack2 */ - rt = ss7_route_table_find_route_by_dpc_mask(inst->rtable_system, - as->cfg.routing_key.pc, 0xffffff, - true); - /* no route found, bail out */ - if (!rt) { - LOGPFSML(fi, LOGL_NOTICE, "Attempting to delete route for this IPA AS, but cannot " - "find route for DPC %s. Did you manually delete it?\n", - osmo_ss7_pointcode_print(inst, as->cfg.routing_key.pc)); - return; - } - - /* route points to different AS, bail out */ - if (rt->dest.as != as) { - LOGPFSML(fi, LOGL_NOTICE, "Attempting to delete route for this IPA ASP, but found " - "route for DPC %s points to different AS (%s)\n", - osmo_ss7_pointcode_print(inst, as->cfg.routing_key.pc), rt->dest.as->cfg.name); - return; - } - - ss7_route_destroy(rt); - xafp->ipa_route_created = false; -} - - - /* is any other ASP in this AS in state != DOWN? */ static bool check_any_other_asp_not_down(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp_cmp) { @@ -583,16 +509,12 @@ /* continue below */ break; case XUA_AS_S_ACTIVE: - if (is_single_ipa_asp(as)) - ipa_add_route(fi); /* continue below */ break; case XUA_AS_S_PENDING: /* continue below */ break; case XUA_AS_S_DOWN: - if (is_single_ipa_asp(as)) - ipa_del_route(fi); /* RFC4666 sec 4.3.2 AS States: If we end up here, it means no ASP is ACTIVE or INACTIVE, meaning no ASP can have already configured the traffic mode -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40580?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8997d40f2a779734432b40d27f9345d9a739d36f Gerrit-Change-Number: 40580 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[S] Change in libosmo-sigtran[master]: ss7_vty: Avoid adding rote to local PC in role ASP

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40579?usp=email ) Change subject: ss7_vty: Avoid adding rote to local PC in role ASP ...................................................................... ss7_vty: Avoid adding rote to local PC in role ASP This commit basically reverts b4f1b2cb8bd404f08601dc8ca700b672a455846c from ~4 years ago. In ASP role, the routing-key is configured with a local PC, since that's what's announced during RKM towards the SG. Hence, it makes no sense adding a route pointing to a local PCm because the M3UA routing decisions first check if the DPC is local, and only then otherwise tries to route it. Change-Id: Ic602de42e37c4579f530823bb41e0a8193ce73bb --- M src/ss7_as_vty.c M src/ss7_vty.c M src/ss7_vty.h 3 files changed, 1 insertion(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/79/40579/1 diff --git a/src/ss7_as_vty.c b/src/ss7_as_vty.c index 6ea170e..0b0ddc1 100644 --- a/src/ss7_as_vty.c +++ b/src/ss7_as_vty.c @@ -288,7 +288,6 @@ { struct osmo_ss7_as *as = vty->index; struct osmo_ss7_routing_key *rkey = &as->cfg.routing_key; - struct osmo_ss7_route *rt; int pc; if (as->cfg.proto == OSMO_SS7_ASP_PROT_IPA && atoi(rcontext) != 0) { @@ -303,34 +302,12 @@ return CMD_WARNING; } - /* When libosmo-sigtran is used in ASP role, the VTY routing table node - * (config-cs7-rt) is not available. However, when we add a routing key - * to an AS we still have to put a matching dynamic route into the routing - * table. This is done automatically by first removing the old dynamic route - * (users may change the routing key via VTY during runtime) and then - * putting a new dynamic route (see below). */ - if (cs7_role == CS7_ROLE_ASP) { - rt = ss7_route_table_find_route_by_dpc_mask(as->inst->rtable_system, - rkey->pc, 0xffffff, - true); - if (rt) - ss7_route_destroy(rt); - } - rkey->pc = pc; rkey->context = atoi(rcontext); /* FIXME: input validation */ rkey->si = si ? get_string_value(mtp_si_vals, si) : 0; /* FIXME: input validation */ rkey->ssn = ssn ? atoi(ssn) : 0; /* FIXME: input validation */ - /* automatically add new dynamic route (see also comment above) */ - if (cs7_role == CS7_ROLE_ASP) { - if (!ss7_route_create(as->inst->rtable_system, rkey->pc, 0xffffff, true, as->cfg.name)) { - vty_out(vty, "Cannot create route (pc=%s, linkset=%s) to AS %s", dpc, as->cfg.name, VTY_NEWLINE); - return CMD_WARNING; - } - } - return CMD_SUCCESS; } diff --git a/src/ss7_vty.c b/src/ss7_vty.c index 9916185..a8869d4 100644 --- a/src/ss7_vty.c +++ b/src/ss7_vty.c @@ -75,7 +75,7 @@ * Core CS7 Configuration ***********************************************************************/ -enum cs7_role_t cs7_role; +static enum cs7_role_t cs7_role; void *g_ctx; static struct cmd_node cs7_node = { diff --git a/src/ss7_vty.h b/src/ss7_vty.h index 18dc5a6..3bafffd 100644 --- a/src/ss7_vty.h +++ b/src/ss7_vty.h @@ -18,7 +18,6 @@ }; extern void *g_ctx; -extern enum cs7_role_t cs7_role; extern const struct value_string ipproto_vals[]; #define CS7_STR "ITU-T Signaling System 7\n" -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic602de42e37c4579f530823bb41e0a8193ce73bb Gerrit-Change-Number: 40579 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[XS] Change in libosmo-sigtran[master]: cosmetic: Fix typo in comment

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40578?usp=email ) Change subject: cosmetic: Fix typo in comment ...................................................................... cosmetic: Fix typo in comment Change-Id: Ide34bf01230fd416c8192a90474039e2f41cb6cd --- M src/ss7_vty.c M src/xua_snm.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/78/40578/1 diff --git a/src/ss7_vty.c b/src/ss7_vty.c index a3f1a34..9916185 100644 --- a/src/ss7_vty.c +++ b/src/ss7_vty.c @@ -1334,7 +1334,7 @@ llist_for_each_entry(as, &inst->as_list, list) ss7_vty_write_one_as(vty, as, show_dyn_config); - /* now dump everything that is relevent for the SG role */ + /* now dump everything that is relevant for the SG role */ if (cs7_role == CS7_ROLE_SG) { /* dump routes, as their target ASs exist */ diff --git a/src/xua_snm.c b/src/xua_snm.c index 6bbeec7..04568d2 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -167,7 +167,7 @@ rt = ss7_route_table_find_route_by_dpc_mask_as(s7i->rtable_system, pc, 0xffffff, as, true); if (!rt) { /* No dynamic fully qualified route found. Add dynamic fully - * squalified route and mark it as (un)available: */ + * qualified route and mark it as (un)available: */ rt = ss7_route_create(s7i->rtable_system, pc, 0xffffff, true, as->cfg.name); if (!rt) { LOGPAS(as, DLSS7, LOGL_ERROR, "Unable to create dynamic route for pc=%u=%s status=%s\n", -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ide34bf01230fd416c8192a90474039e2f41cb6cd Gerrit-Change-Number: 40578 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[M] Change in pysim[master]: smdpp: less verbose by default

by Hoernchen

Attention is currently required from: dexter, laforge, lynxis lazus. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40468?usp=email ) Change subject: smdpp: less verbose by default ...................................................................... Patch Set 11: (4 comments) File osmo-smdpp.py: https://gerrit.osmocom.org/c/pysim/+/40468/comment/a6b29ec5_52efdc65?usp=em… : PS6, Line 112: #print("Using nameConstraints parsing for variant O certificate") > Should this debug? Or not could you drop the line? Done https://gerrit.osmocom.org/c/pysim/+/40468/comment/353ab3c0_75e9a30d?usp=em… : PS6, Line 117: #print("Using GSMA permittedEins parsing for newer certificate variant") > Should this debug? Or not could you drop the line? Done https://gerrit.osmocom.org/c/pysim/+/40468/comment/cdcf06dd_b9df7316?usp=em… : PS6, Line 362: #logger.debug("Rx JSON: %s" % json.dumps(content)) > logger. […] Done https://gerrit.osmocom.org/c/pysim/+/40468/comment/662ef91a_bf689b6b?usp=em… : PS6, Line 370: logger.debug("Tx JSON: %s" % json.dumps(output)[:200]) > Is this an expensive operations because the object is huge (json.dumps)? […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I04a72b8f52417862d4dcba1f0743700dd942ef49 Gerrit-Change-Number: 40468 Gerrit-PatchSet: 11 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Jul 2025 15:50:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 5 days

1
0
0 0

[XS] Change in pysim[master]: x509 cert: fix weird cert check

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40524?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: x509 cert: fix weird cert check ...................................................................... x509 cert: fix weird cert check Change-Id: I18beab0e1b24579724704c4141a2c457b2d4cf99 --- M pySim/esim/x509_cert.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/24/40524/7 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40524?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I18beab0e1b24579724704c4141a2c457b2d4cf99 Gerrit-Change-Number: 40524 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[M] Change in pysim[master]: smdpp: less verbose by default

by Hoernchen

Attention is currently required from: Hoernchen, dexter, laforge. Hello Jenkins Builder, dexter, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40468?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: smdpp: less verbose by default ...................................................................... smdpp: less verbose by default Those data blobs are huge. Change-Id: I04a72b8f52417862d4dcba1f0743700dd942ef49 --- M osmo-smdpp.py M pySim/esim/bsp.py M pySim/esim/es8p.py 3 files changed, 86 insertions(+), 50 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/68/40468/11 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I04a72b8f52417862d4dcba1f0743700dd942ef49 Gerrit-Change-Number: 40468 Gerrit-PatchSet: 11 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[S] Change in pysim[master]: smdpp: verify cert chain

by Hoernchen

Attention is currently required from: Hoernchen, dexter. Hello Jenkins Builder, dexter, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40469?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: smdpp: verify cert chain ...................................................................... smdpp: verify cert chain Change-Id: I1e4e4b1b032dc6a8b7d15bd80d533a50fe0cff15 --- M osmo-smdpp.py 1 file changed, 20 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/69/40469/12 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40469?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1e4e4b1b032dc6a8b7d15bd80d533a50fe0cff15 Gerrit-Change-Number: 40469 Gerrit-PatchSet: 12 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[S] Change in pysim[master]: smdpp: map test mode matching id to existing profile for convenience

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40576?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: smdpp: map test mode matching id to existing profile for convenience ...................................................................... smdpp: map test mode matching id to existing profile for convenience Either that, or we have to create actual files we can serve. Change-Id: I6c8c08343678e9a3b978bc9c43a9b56a8d832d10 --- M osmo-smdpp.py 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/76/40576/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6c8c08343678e9a3b978bc9c43a9b56a8d832d10 Gerrit-Change-Number: 40576 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025