June 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: stp: Expect and answer M3UA BEAT from IUT

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40462?usp=email ) Change subject: stp: Expect and answer M3UA BEAT from IUT ...................................................................... stp: Expect and answer M3UA BEAT from IUT This fixes tests failing with newer versions of libosmo-sigtran where HEARTBEAT procedure is enabled by default. Change-Id: Idb70acde0683bc053db20781ce4926fbc318f51f --- M stp/STP_Tests_M3UA.ttcn 1 file changed, 17 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 2f452de..7b78a72 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -140,6 +140,15 @@ } } +private altstep as_m3ua_beat_answer(integer idx, template M3UA_Heartbeat_Data hbd := *) runs on RAW_M3UA_CT { + var M3UA_RecvFrom rx; + [] M3UA[idx].receive(t_M3UA_RecvFrom(tr_M3UA_BEAT(hbd))) -> value rx { + log("[", idx, "] Answering M3UA BEAT ", rx); + f_M3UA_send(idx, ts_M3UA_BEAT_ACK(rx.msg.m3UA_BEAT.messageParameters.heartbeat_Data)); + repeat; + } +} + friend function f_M3UA_send(integer idx, template (present) PDU_M3UA msg, integer stream := 0) runs on RAW_M3UA_CT { if (g_m3ua_configs[idx].use_tcp) { @@ -149,14 +158,16 @@ } } -friend function f_M3UA_exp(integer idx, template (present) PDU_M3UA msg) runs on RAW_M3UA_CT { +friend function f_M3UA_exp(integer idx, template (present) PDU_M3UA msg, + float timeout_val := 5.0, boolean answer_beat := true) runs on RAW_M3UA_CT { var M3UA_RecvFrom rx; - timer T := 5.0; + timer T := timeout_val; T.start; alt { [] M3UA[idx].receive(t_M3UA_RecvFrom(msg)) { setverdict(pass); } + [answer_beat] as_m3ua_beat_answer(idx); [] M3UA[idx].receive(t_M3UA_RecvFrom(?)) -> value rx { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Received unexpected M3UA[", idx, "] ", rx, @@ -315,6 +326,7 @@ } friend function f_init_m3ua(boolean ignore_ssnm := true, + boolean answer_beat := true, template (omit) M3uaConfigs m3ua_configs := omit) runs on RAW_M3UA_CT { @@ -332,6 +344,9 @@ if (not g_m3ua_configs[i].is_server) { map(self:M3UA[i], system:M3UA_CODEC_PT); } + if (answer_beat) { + activate(as_m3ua_beat_answer(i)); + } } activate(as_m3ua_sctp()); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40462?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idb70acde0683bc053db20781ce4926fbc318f51f Gerrit-Change-Number: 40462 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 days, 22 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: IPA_Emulation.ttcn: Add call to support dis/enabling CCM management

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40471?usp=email ) Change subject: IPA_Emulation.ttcn: Add call to support dis/enabling CCM management ...................................................................... IPA_Emulation.ttcn: Add call to support dis/enabling CCM management This allows eg. a user to let the Emulation do the inital handshake, and then pass control of eg. IPA PING/PONG messages directly to the user afterwards. Change-Id: If68e0ba36c3a56f021dd50aadf2156ddc696b816 --- M library/IPA_Emulation.ttcnpp 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/IPA_Emulation.ttcnpp b/library/IPA_Emulation.ttcnpp index 07fefe5..2df598a 100644 --- a/library/IPA_Emulation.ttcnpp +++ b/library/IPA_Emulation.ttcnpp @@ -291,8 +291,10 @@ }; signature IPA_CFG_disconnect(inout IPL4asp_Types.Result res); +signature IPA_CFG_chg_ccm_enabled(in boolean res); type port IPA_CFG_PT procedure { inout IPA_CFG_disconnect; + inout IPA_CFG_chg_ccm_enabled; } with { extension "internal" }; function f_ipa_cfg_disconnect(IPA_CFG_PT pt, inout IPL4asp_Types.Result res) { @@ -300,6 +302,11 @@ [] pt.getreply(IPA_CFG_disconnect:{?}) -> param (res) {}; } } +function f_ipa_cfg_chg_ccm_enabled(IPA_CFG_PT pt, boolean ccm_enabled) { + pt.call(IPA_CFG_chg_ccm_enabled:{ccm_enabled}) { + [] pt.getreply(IPA_CFG_chg_ccm_enabled:{ccm_enabled}); + } +} /* Function to use to connect as client to a remote IPA Server */ function f_connect(charstring remote_host, IPL4asp_Types.PortNumber remote_port, @@ -701,6 +708,7 @@ var octetstring payload; var ASP_IPA_Unitdata ipa_ud; var IPL4asp_Types.Result res; + var boolean cfg_chg_ccm_enabled; #ifdef IPA_EMULATION_CTRL var CtrlMessage ctrl_msg; #endif @@ -934,6 +942,11 @@ CFG_PORT.reply(IPA_CFG_disconnect:{res}); } + [] CFG_PORT.getcall(IPA_CFG_chg_ccm_enabled:{?})-> param(cfg_chg_ccm_enabled) { + g_ccm_enabled := cfg_chg_ccm_enabled; + CFG_PORT.reply(IPA_CFG_chg_ccm_enabled:{cfg_chg_ccm_enabled}); + } + } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40471?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If68e0ba36c3a56f021dd50aadf2156ddc696b816 Gerrit-Change-Number: 40471 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 days, 22 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: stp: IPA: Introduce test TC_clnt_beat_timeout

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40475?usp=email ) Change subject: stp: IPA: Introduce test TC_clnt_beat_timeout ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40475?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5a41857dbd9f0bfe40a3a539aaed8361bc29fd6b Gerrit-Change-Number: 40475 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jun 2025 08:27:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 days, 22 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: stp: IPA: Introduce test TC_beat_timeout

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40473?usp=email ) Change subject: stp: IPA: Introduce test TC_beat_timeout ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40473?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6f16915238d7762faf1c63fdeccca7e4a5f20893 Gerrit-Change-Number: 40473 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jun 2025 08:27:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 days, 22 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: IPA: Introduce test TC_beat

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40472?usp=email ) Change subject: stp: IPA: Introduce test TC_beat ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40472?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d762fb4780aaa9931c3841cce69da6ee95529f3 Gerrit-Change-Number: 40472 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jun 2025 08:27:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 days, 22 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: IPA_Emulation.ttcn: Add call to support dis/enabling CCM management

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40471?usp=email ) Change subject: IPA_Emulation.ttcn: Add call to support dis/enabling CCM management ...................................................................... Patch Set 2: (1 comment) File library/IPA_Emulation.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40471/comment/ef08d517_78c9… : PS2, Line 945: cfg_chg_ccm_enabled > Do you really need a local variable here? Why not passing `g_ccm_enabled`? No idea, but I prefer explicitly setting it through :=, it becomes clear what it's doing and how the var can be modified. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40471?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If68e0ba36c3a56f021dd50aadf2156ddc696b816 Gerrit-Change-Number: 40471 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jun 2025 08:27:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

6 days, 22 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: IPA_Emulation.ttcn: Add call to support dis/enabling CCM management

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40471?usp=email ) Change subject: IPA_Emulation.ttcn: Add call to support dis/enabling CCM management ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40471?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If68e0ba36c3a56f021dd50aadf2156ddc696b816 Gerrit-Change-Number: 40471 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jun 2025 08:26:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 days, 22 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Expect and answer M3UA BEAT from IUT

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40462?usp=email ) Change subject: stp: Expect and answer M3UA BEAT from IUT ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40462?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idb70acde0683bc053db20781ce4926fbc318f51f Gerrit-Change-Number: 40462 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jun 2025 08:09:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 days, 22 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: IPA: Introduce test TC_beat

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40472?usp=email ) Change subject: stp: IPA: Introduce test TC_beat ...................................................................... Patch Set 3: (1 comment) File stp/STP_Tests_IPA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40472/comment/30415499_c440… : PS3, Line 495: var IpaCcmMsgtype ipa_ping_msg := IPAC_MSGT_PING; : v > I'd agree. […] Indeed, otherwise titan compiler says it doesn't know about that symbol. I have already run into this several time, that's why I'm using an intermediate variable. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40472?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d762fb4780aaa9931c3841cce69da6ee95529f3 Gerrit-Change-Number: 40472 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jun 2025 08:09:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

6 days, 22 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Introduce test TC_(m3ua_tcp(clnt_))beat_timeout

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40474?usp=email ) Change subject: stp: Introduce test TC_(m3ua_tcp(clnt_))beat_timeout ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40474?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie0c430b7992881e8ae506fe6434f06946f8f6278 Gerrit-Change-Number: 40474 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jun 2025 21:19:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2025