May 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[pespin/rel-2.1.0]: sccp_sclc.c: Fix potential memory leak

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40395?usp=email ) Change subject: sccp_sclc.c: Fix potential memory leak ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/rel-2.1.0 Gerrit-Change-Id: Ic5f52911cab2dfe0477caa543390067d51dba3b5 Gerrit-Change-Number: 40395 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

3 weeks, 5 days

1
0
0 0

[XS] Change in libosmo-sigtran[pespin/rel-2.1.0]: sccp_scoc: Match local conn by src_ref, not dest_ref

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40396?usp=email ) Change subject: sccp_scoc: Match local conn by src_ref, not dest_ref ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/rel-2.1.0 Gerrit-Change-Id: I7c94faea6e446097b54143055d05d7f9d19afede Gerrit-Change-Number: 40396 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

3 weeks, 5 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: deps: Depend on osmocom fork of forge.etsi.org nas.git

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40385?usp=email ) Change subject: deps: Depend on osmocom fork of forge.etsi.org nas.git ...................................................................... deps: Depend on osmocom fork of forge.etsi.org nas.git This module provides types, templates and functions to operate NG NAS (5G). A fork is needed because: * Upstream code doesn't compile against eclipse titan (A PR has been submitted upstream and we should eventually be able to compile ttcn3 code just fine in that regard). * Some system/external functions need to be implemented, such as fx_GetSystemTime(). We currently do that in our fork. Related: SYS#7073 Change-Id: I004fc26e5d691ee7e3be984e28f5516e2b55258c --- M deps/Makefile 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/deps/Makefile b/deps/Makefile index 0c5a033..b4a411a 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -69,7 +69,8 @@ OSMOGERRIT_REPOS= osmo-uecups -OSMOGITEA_REPOS= titan.ProtocolModules.BSSMAP \ +OSMOGITEA_REPOS= nas \ + titan.ProtocolModules.BSSMAP \ titan.ProtocolModules.MAP \ titan.TestPorts.AF_PACKET \ titan.TestPorts.USB @@ -84,6 +85,7 @@ # Do not put references to branches here, except for local testing: this breaks the caching # logic of docker containers, which only invalidate their cached ttcn3 dependencies if this # file changed. +nas_commit= 205e24167517500ba2d49322dfa1754ab8a0fc43 titan.Libraries.TCCUsefulFunctions_commit= R.35.B-6-gb3687da titan.ProtocolEmulations.M3UA_commit= b58f92046e48a7b1ed531e243a2319ebca53bf4c titan.ProtocolEmulations.SCCP_commit= 750a3e836831e58eae59d4757ef5d0c759f9ca5d -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40385?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I004fc26e5d691ee7e3be984e28f5516e2b55258c Gerrit-Change-Number: 40385 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Initial support encoding NG NAS UL messages

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40386?usp=email ) Change subject: 5gc: Initial support encoding NG NAS UL messages ...................................................................... 5gc: Initial support encoding NG NAS UL messages Change-Id: Id59564114cf18ae745e3e385e2c91779a453e545 --- M 5gc/C5G_Tests.ttcn M 5gc/gen_links.sh M 5gc/regen_makefile.sh A library/NG_NAS_Functions.ttcn 4 files changed, 85 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/5gc/C5G_Tests.ttcn b/5gc/C5G_Tests.ttcn index 823d216..62553fc 100644 --- a/5gc/C5G_Tests.ttcn +++ b/5gc/C5G_Tests.ttcn @@ -29,6 +29,12 @@ import from NGAP_Functions all; import from NGAP_Emulation all; +import from NG_NAS_Common all; +import from NG_NAS_MsgContainers all; +import from NAS_CommonTemplates all; +import from NG_NAS_Templates all; +import from NG_NAS_Functions all; + /* (maximum) number of emulated eNBs */ const integer NUM_NGRAN := 1; @@ -240,6 +246,9 @@ private function f_register() runs on ConnHdlr { var template (value) UserLocationInformation p_ueLocInf; var template (value) NGAP_PDU tx_pdu; + var template (value) NG_NAS_UL_Message_Type nas_ul_msg; + var NAS_PDU nas_pdu; + p_ueLocInf := m_uPTransportLayerInformation_userLocationInformationNR( m_userLocationInformationNR( @@ -248,9 +257,16 @@ )); + nas_ul_msg := cs_NG_REGISTRATION_REQUEST(cs_RegistrationType(tsc_NG_RegistrationInitial, '1'B), + tsc_NasKsi_NoKey, + '0'B, + cs_NG_MobileIdentitySUCI('0000'B /* Type IMSI */, + '00f110214300014444330302'O)); + nas_pdu := enc_NG_NAS_UL_Message_Type(valueof(nas_ul_msg)); + tx_pdu := m_ngap_initMsg(m_n2_initialUeMessage(g_pars.c5g_idx, - '7e004179000d0109f1500000000079890040642e02f070'O, /* Registration request */ + nas_pdu, /* Registration request */ p_ueLocInf, mo_Signalling)); diff --git a/5gc/gen_links.sh b/5gc/gen_links.sh index b86d4ed..2cab445 100755 --- a/5gc/gen_links.sh +++ b/5gc/gen_links.sh @@ -18,6 +18,44 @@ FILES="IPL4asp_Functions.ttcn IPL4asp_PT.cc IPL4asp_PT.hh IPL4asp_PortType.ttcn IPL4asp_Types.ttcn IPL4asp_discovery.cc IPL4asp_protocol_L234.hh" gen_links $DIR $FILES +#################### +# NG_NAS start +#################### +DIR=$BASEDIR/nas/ccsrc/Externals +FILES="common_ext.cc " +gen_links $DIR $FILES + +DIR=$BASEDIR/nas/ttcn/Lib3GPP/Common +FILES="CommonDefs.ttcn " +gen_links $DIR $FILES + +DIR=$BASEDIR/nas/ttcn/Lib3GPP/PicsPixit +FILES="EUTRA_NR_Parameters.ttcn NAS_5GC_Parameters.ttcn Parameters.ttcn " +gen_links $DIR $FILES + +DIR=$BASEDIR/nas/ttcn/Lib3GPP/CommonIP +FILES="CommonIP.ttcn LoopbackIP_PacketFilterTest.ttcn LoopbackIP.ttcn " +gen_links $DIR $FILES + +DIR=$BASEDIR/nas/ttcn/Lib3GPP/EPS_NAS +FILES="EPS_NAS_LoopBack_TypeDefs.ttcn EPS_NAS_TypeDefs.ttcn " +gen_links $DIR $FILES + +DIR=$BASEDIR/nas/ttcn/Lib3GPP/Common4G5G +FILES="Common4G5G_LoopBack.ttcn Common4G5G.ttcn EUTRA_NR_SecurityFunctions.ttcn " +gen_links $DIR $FILES + +DIR=$BASEDIR/nas/ttcn/Lib3GPP/NAS +FILES="NAS_AuthenticationCommon.ttcn NAS_AuxiliaryDefsAndFunctions.ttcn NAS_CommonTemplates.ttcn NAS_CommonTypeDefs.ttcn SMS_Templates.ttcn SMS_TypeDefs.ttcn " +gen_links $DIR $FILES + +DIR=$BASEDIR/nas/ttcn/Lib3GPP/NG_NAS +FILES="EAP_TypeDefs.ttcn NG_NAS_Common.ttcn NG_NAS_MsgContainers.ttcn NG_NAS_Templates.ttcn NG_NAS_TypeDefs.ttcn NG_V2X_MsgContainers.ttcn NG_V2X_TypeDefs.ttcn " +gen_links $DIR $FILES +#################### +# NG_NAS end +#################### + DIR=../library/ngap FILES="NGAP_CommonDataTypes.asn NGAP_Constants.asn NGAP_Containers.asn NGAP_IEs.asn NGAP_PDU_Contents.asn NGAP_PDU_Descriptions.asn " FILES+="NGAP_EncDec.cc NGAP_Types.ttcn NGAP_Pixits.ttcn NGAP_Templates.ttcn " @@ -28,6 +66,7 @@ FILES+="SCTP_Templates.ttcn " FILES+="DNS_Helpers.ttcn " FILES+="NGAP_CodecPort.ttcn NGAP_CodecPort_CtrlFunctDef.cc NGAP_CodecPort_CtrlFunct.ttcn NGAP_Functions.ttcn NGAP_Emulation.ttcn " +FILES+="NG_NAS_Functions.ttcn " gen_links $DIR $FILES gen_links_finish diff --git a/5gc/regen_makefile.sh b/5gc/regen_makefile.sh index 583f48a..44f7a56 100755 --- a/5gc/regen_makefile.sh +++ b/5gc/regen_makefile.sh @@ -8,6 +8,7 @@ IPL4asp_PT.cc IPL4asp_discovery.cc Native_FunctionDefs.cc + common_ext.cc NGAP_CodecPort_CtrlFunctDef.cc NGAP_EncDec.cc TCCConversion.cc diff --git a/library/NG_NAS_Functions.ttcn b/library/NG_NAS_Functions.ttcn new file mode 100644 index 0000000..4f0e4da --- /dev/null +++ b/library/NG_NAS_Functions.ttcn @@ -0,0 +1,28 @@ +module NG_NAS_Functions { + +/* (C) 2025 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +import from NG_NAS_MsgContainers all; +import from NG_NAS_TypeDefs all; +import from EAP_TypeDefs all; + +external function enc_NG_NAS_UL_Message_Type(in NG_NAS_UL_Message_Type pdu) return octetstring +with { extension "prototype(convert)" extension "encode(RAW)" } + +external function dec_NG_NAS_UL_Message_Type(in octetstring stream) return NG_NAS_UL_Message_Type +with { extension "prototype(convert)" extension "decode(RAW)" } + +external function enc_NG_NAS_DL_Message_Type(in NG_NAS_DL_Message_Type pdu) return octetstring +with { extension "prototype(convert)" extension "encode(RAW)" } + +external function dec_NG_NAS_DL_Message_Type(in octetstring stream) return NG_NAS_DL_Message_Type +with { extension "prototype(convert)" extension "decode(RAW)" } + +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id59564114cf18ae745e3e385e2c91779a453e545 Gerrit-Change-Number: 40386 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Initial support encoding NG NAS UL messages

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40386?usp=email ) Change subject: 5gc: Initial support encoding NG NAS UL messages ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id59564114cf18ae745e3e385e2c91779a453e545 Gerrit-Change-Number: 40386 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 May 2025 14:39:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 5 days

1
0
0 0

[XS] Change in libosmo-sigtran[pespin/rel-2.1.0]: snm: Fix generating wrong format in 'affected PCs' log string

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40393?usp=email ) Change subject: snm: Fix generating wrong format in 'affected PCs' log string ...................................................................... snm: Fix generating wrong format in 'affected PCs' log string The previous code wrongly added an extra ", " string between each element. (cherry picked from commit b8a27a9b09babdf219e76347e89b66a9214f7b08) Change-Id: Ie6c9712055731125d0d14b946cc525463796a0f7 --- M src/xua_snm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/93/40393/1 diff --git a/src/xua_snm.c b/src/xua_snm.c index 36fe3c7..971380b 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -59,7 +59,7 @@ uint8_t mask = _aff_pc >> 24; /* append point code + mask */ - out = talloc_asprintf_append(out, "%s%s/%u, ", i == 0 ? "" : ", ", + out = talloc_asprintf_append(out, "%s%s/%u", i == 0 ? "" : ", ", osmo_ss7_pointcode_print(s7i, pc), mask); } return out; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/rel-2.1.0 Gerrit-Change-Id: Ie6c9712055731125d0d14b946cc525463796a0f7 Gerrit-Change-Number: 40393 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[S] Change in libosmo-sigtran[pespin/rel-2.1.0]: ipa: Fix asp_id/SLS unset in tcp-server mode

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40394?usp=email ) Change subject: ipa: Fix asp_id/SLS unset in tcp-server mode ...................................................................... ipa: Fix asp_id/SLS unset in tcp-server mode Commit changing the value set to asp_id (used to derive SLS) for IPA conns only updated the asp_id value on the stream_cli code path, but not on the stream_srv one. As a result, on IPA conns with an underlaying TCP server conn, asp_id and SLS was always 0. Fixes: 2c9ba16 "ipa: Use pseudo-random number for SLS in IPA->M3UA direction (cherry picked from commit a3232c4b7ba8d90f852211c987a4a438c8970aa6) Change-Id: I4e8e8d58e9425fc6fce5e4e15a79e86ff4518270 --- M src/osmo_ss7_asp.c M src/osmo_ss7_xua_srv.c 2 files changed, 10 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/94/40394/1 diff --git a/src/osmo_ss7_asp.c b/src/osmo_ss7_asp.c index d81d25c..57ebc82 100644 --- a/src/osmo_ss7_asp.c +++ b/src/osmo_ss7_asp.c @@ -945,8 +945,8 @@ rc = ss7_asp_apply_primary_address(asp); } else { if (asp->cfg.proto == OSMO_SS7_ASP_PROT_IPA) { - /* we use the lower 4 bits of the asp_id feld as SLS; let's initialize it here from a - * pseudo-random value */ + /* we use the lower 4 bits of the asp_id field as SLS; + * let's initialize it here from a pseudo-random value */ asp->asp_id = rand() & 0xf; } } diff --git a/src/osmo_ss7_xua_srv.c b/src/osmo_ss7_xua_srv.c index 4962bfd..35e360f 100644 --- a/src/osmo_ss7_xua_srv.c +++ b/src/osmo_ss7_xua_srv.c @@ -61,7 +61,7 @@ * SS7 xUA Server ***********************************************************************/ -/* server has accept()ed a new SCTP association, let's find the ASP for +/* Server has accept()ed a new SCTP association / TCP connection, let's find the ASP for * it (if any) */ static int xua_accept_cb(struct osmo_stream_srv_link *link, int fd) { @@ -177,9 +177,15 @@ * data */ osmo_stream_srv_set_data(srv, asp); - if (oxs->cfg.trans_proto == IPPROTO_SCTP) { + if (asp->cfg.trans_proto == IPPROTO_SCTP) { rc = ss7_asp_apply_peer_primary_address(asp); rc = ss7_asp_apply_primary_address(asp); + } else { + if (asp->cfg.proto == OSMO_SS7_ASP_PROT_IPA) { + /* we use the lower 4 bits of the asp_id field as SLS; + * let's initialize it here from a pseudo-random value */ + asp->asp_id = rand() & 0xf; + } } /* send M-SCTP_ESTABLISH.ind to Layer Manager */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40394?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/rel-2.1.0 Gerrit-Change-Id: I4e8e8d58e9425fc6fce5e4e15a79e86ff4518270 Gerrit-Change-Number: 40394 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[XS] Change in libosmo-sigtran[pespin/rel-2.1.0]: sccp_sclc.c: Fix potential memory leak

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40395?usp=email ) Change subject: sccp_sclc.c: Fix potential memory leak ...................................................................... sccp_sclc.c: Fix potential memory leak If data_ie is not found, msgb will be leaked. (cherry picked from commit a9271575181accf1476131e3a32a9272317efd40) Change-Id: Ic5f52911cab2dfe0477caa543390067d51dba3b5 --- M src/sccp_sclc.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/95/40395/1 diff --git a/src/sccp_sclc.c b/src/sccp_sclc.c index 186efbd..6196d35 100644 --- a/src/sccp_sclc.c +++ b/src/sccp_sclc.c @@ -159,7 +159,7 @@ struct osmo_scu_prim *prim; struct osmo_scu_unitdata_param *param; struct xua_msg_part *data_ie = xua_msg_find_tag(xua, SUA_IEI_DATA); - struct msgb *upmsg = sccp_msgb_alloc(__func__); + struct msgb *upmsg; struct osmo_sccp_user *scu; uint32_t protocol_class; @@ -168,6 +168,7 @@ return -1; } + upmsg = sccp_msgb_alloc(__func__); /* fill primitive */ prim = (struct osmo_scu_prim *) msgb_put(upmsg, sizeof(*prim)); param = &prim->u.unitdata; @@ -208,7 +209,7 @@ struct osmo_scu_prim *prim; struct osmo_scu_notice_param *param; struct xua_msg_part *data_ie = xua_msg_find_tag(xua, SUA_IEI_DATA); - struct msgb *upmsg = sccp_msgb_alloc(__func__); + struct msgb *upmsg; struct osmo_sccp_user *scu; if (!data_ie) { @@ -216,6 +217,7 @@ return -1; } + upmsg = sccp_msgb_alloc(__func__); /* fill primitive */ prim = (struct osmo_scu_prim *) msgb_put(upmsg, sizeof(*prim)); param = &prim->u.notice; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/rel-2.1.0 Gerrit-Change-Id: Ic5f52911cab2dfe0477caa543390067d51dba3b5 Gerrit-Change-Number: 40395 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[S] Change in libosmo-sigtran[pespin/rel-2.1.0]: Bump version: 2.1.0.5-b3d1 → 2.1.1

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40398?usp=email ) Change subject: Bump version: 2.1.0.5-b3d1 → 2.1.1 ...................................................................... Bump version: 2.1.0.5-b3d1 → 2.1.1 Change-Id: I680d638e11f899a1d3fe381c0efb6fa2eea6d324 --- M debian/changelog M src/Makefile.am 2 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/98/40398/1 diff --git a/debian/changelog b/debian/changelog index d76c2e0..6959407 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,13 @@ +libosmo-sigtran (2.1.1) unstable; urgency=medium + + * snm: Fix generating wrong format in 'affected PCs' log string + * ipa: Fix asp_id/SLS unset in tcp-server mode + * sccp_sclc.c: Fix potential memory leak + * sccp_scoc: Match local conn by src_ref, not dest_ref + * asp: Avoid double-free of received msg if conn is teared down + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Wed, 28 May 2025 16:36:29 +0200 + libosmo-sigtran (2.1.0) unstable; urgency=medium [ Andreas Eversberg ] diff --git a/src/Makefile.am b/src/Makefile.am index ced19f1..79c8d37 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -35,7 +35,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=11:0:0 +LIBVERSION=11:1:0 libosmo_sigtran_la_SOURCES = \ ipa.c \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40398?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/rel-2.1.0 Gerrit-Change-Id: I680d638e11f899a1d3fe381c0efb6fa2eea6d324 Gerrit-Change-Number: 40398 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[XS] Change in libosmo-sigtran[pespin/rel-2.1.0]: sccp_scoc: Match local conn by src_ref, not dest_ref

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40396?usp=email ) Change subject: sccp_scoc: Match local conn by src_ref, not dest_ref ...................................................................... sccp_scoc: Match local conn by src_ref, not dest_ref SCRC Routing Failure is dispatched when a local SCCP Connection Oriented message fails to be routed to a peer. Hence, in order to figure out if the msg belons to a local conn, we need to use the src_ref (the sender), not the dst_ref (the peer's id). As a result, event SCOC_E_RCOC_ROUT_FAIL_IND was potentially being set to the wrong connection FSM. (cherry picked from commit 0a5161a0a8922a383e9478340a46c139428ed343) Change-Id: I7c94faea6e446097b54143055d05d7f9d19afede --- M src/sccp_scoc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/96/40396/1 diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index c11dddf..0b6bd98 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -1545,7 +1545,7 @@ xua_hdr_dump(xua, &xua_dialect_sua)); /* try to dispatch to connection FSM (if any) */ - conn_id = xua_msg_get_u32(xua, SUA_IEI_DEST_REF); + conn_id = xua_msg_get_u32(xua, SUA_IEI_SRC_REF); conn = conn_find_by_id(inst, conn_id); if (conn) { osmo_fsm_inst_dispatch(conn->fi, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/rel-2.1.0 Gerrit-Change-Id: I7c94faea6e446097b54143055d05d7f9d19afede Gerrit-Change-Number: 40396 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2025