May 2025 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo-s1gw[master]: s1ap_proxy: use Global-ENB-ID as logging prefix

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40384?usp=email ) Change subject: s1ap_proxy: use Global-ENB-ID as logging prefix ...................................................................... s1ap_proxy: use Global-ENB-ID as logging prefix Change-Id: Ib3584237e60274c0276e750728b2bb2950f376a4 --- M src/s1ap_proxy.erl 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/84/40384/1 diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 1ebbf7c..85a2e80 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -171,6 +171,11 @@ %% private API %% ------------------------------------------------------------------ +-spec set_logging_prefix(string()) -> ok. +set_logging_prefix(Prefix) when is_list(Prefix) -> + logger:set_process_metadata(#{prefix => Prefix}). + + -spec erab_uid(erab_id(), proxy_state()) -> erab_uid(). erab_uid(ERABId, #proxy_state{mme_ue_id = MmeUeId, enb_ue_id = EnbUeId}) -> @@ -606,12 +611,13 @@ #'Global-ENB-ID'{'pLMNidentity' = PLMNId, 'eNB-ID' = ENBId} = C, S0) -> %% store PLMNId/ENBId - %% TODO: use that as a context for logging S1 = S0#proxy_state{plmn_id = parse_plmn_id(PLMNId), enb_id = parse_enb_id(ENBId)}, ?LOG_INFO("Global-ENB-ID: PLMN-ID=~p, eNB-ID=~p", [S1#proxy_state.plmn_id, S1#proxy_state.enb_id]), + %% use that as a context for logging + set_logging_prefix("eNB " ++ genb_id_str(S1)), {{ok, C}, S1}; %% E-RAB SETUP REQUEST related IEs -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib3584237e60274c0276e750728b2bb2950f376a4 Gerrit-Change-Number: 40384 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: use eclipse-titan 11 in Dockerfile

by fixeria

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40381?usp=email ) Change subject: testenv: use eclipse-titan 11 in Dockerfile ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I660dd6ca93a54087b1d41787c4ed2b64a3ad0437 Gerrit-Change-Number: 40381 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 27 May 2025 16:12:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: log_merge.sh: Merge all logs if no test cases are found

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40383?usp=email ) Change subject: log_merge.sh: Merge all logs if no test cases are found ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifc68e42022e8b2990d3c5221b3901f255e4e759b Gerrit-Change-Number: 40383 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 May 2025 16:08:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: log_merge.sh: Merge all logs if no test cases are found

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40383?usp=email ) Change subject: log_merge.sh: Merge all logs if no test cases are found ...................................................................... log_merge.sh: Merge all logs if no test cases are found This can happen for instance if titan exits with an error during startup even before starting any test. In that scenario, titan still writes stuff to a file (eg. C5G_Tests--efc28eab6a6d-hc-1305.log). Let's try to make everything logged available in that case, so user can debug what went wrong. Change-Id: Ifc68e42022e8b2990d3c5221b3901f255e4e759b --- M log_merge.sh 1 file changed, 15 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/40383/1 diff --git a/log_merge.sh b/log_merge.sh index 65a3003..edc780c 100755 --- a/log_merge.sh +++ b/log_merge.sh @@ -51,16 +51,21 @@ TEST_CASES=$(ls -1 $LOG_FILES | awk 'BEGIN { FS = "-" } { print $2 }' | sort | uniq) -for t in $TEST_CASES; do - PREFIX="$BASE_NAME-$t" - OUTPUT="$(get_new_prefix "$PREFIX").merged" - if [ -e "$OUTPUT" ]; then - >&2 echo "log_merge: ERROR: file already exists: $OUTPUT" - exit 1 - fi - ttcn3_logmerge $PREFIX-*.log > "$OUTPUT" - echo "Generated $OUTPUT" -done +if [ -n "$TEST_CASES" ]; then + for t in $TEST_CASES; do + PREFIX="$BASE_NAME-$t" + OUTPUT="$(get_new_prefix "$PREFIX").merged" + if [ -e "$OUTPUT" ]; then + >&2 echo "log_merge: ERROR: file already exists: $OUTPUT" + exit 1 + fi + ttcn3_logmerge $PREFIX-*.log > "$OUTPUT" + echo "Generated $OUTPUT" + done +else + echo "Couldn't find test cases! Merging erverything" + ttcn3_logmerge $LOG_FILES > "$BASE_NAME.merged" +fi if [ "$2" = "--rm" ]; then echo "Removing Input log files !!!" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifc68e42022e8b2990d3c5221b3901f255e4e759b Gerrit-Change-Number: 40383 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: library/s1ap: split PDU specific API to S1AP_Functions.ttcn

by osmith

osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848?usp=email ) Change subject: library/s1ap: split PDU specific API to S1AP_Functions.ttcn ...................................................................... Patch Set 4: (1 comment) File library/S1AP_Utils.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848/comment/4c8a6637_296b… : PS1, Line 1: module S1AP_Utils { > Thank you, @osmith@sysmocom.de! I am wondering if we could maybe run `rmlinks. […] since https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40032 running `rmlinks.sh` is not needed anymore. the build dir now gets deleted at the start of ttcn3 jenkins jobs, so this type of error should not happen anymore. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id3ba089140093490abd0307addeb5d7287dc5894 Gerrit-Change-Number: 39848 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 May 2025 15:01:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[S] Change in osmo-ci[master]: OBS: update_obs_eclipse_titan: update

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40382?usp=email ) Change subject: OBS: update_obs_eclipse_titan: update ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40382?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6580ce81e092299850f177110e130ac1847e05a7 Gerrit-Change-Number: 40382 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 May 2025 14:39:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[S] Change in osmo-ci[master]: OBS: update_obs_eclipse_titan: update

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40382?usp=email ) Change subject: OBS: update_obs_eclipse_titan: update ...................................................................... OBS: update_obs_eclipse_titan: update * Set the branch as argument instead of hardcoding it. * Don't use --version-append, the ~osmocom part will be added to debian/changelog instead when pushing new versions. * Add usage description. Change-Id: I6580ce81e092299850f177110e130ac1847e05a7 --- M scripts/obs/update_obs_eclipse_titan.sh 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/82/40382/1 diff --git a/scripts/obs/update_obs_eclipse_titan.sh b/scripts/obs/update_obs_eclipse_titan.sh index 6efb7c6..2439777 100755 --- a/scripts/obs/update_obs_eclipse_titan.sh +++ b/scripts/obs/update_obs_eclipse_titan.sh @@ -3,7 +3,15 @@ DIR="$(realpath "$(dirname "$0")")" PROJ="$1" GIT_URL="https://gitea.osmocom.org/osmith/titan.core" -CHECKOUT="osmocom/9.0.0" +CHECKOUT="$2" + +if [ $# != 2 ]; then + echo "usage:" + echo " update_obs_eclipse_titan.sh PROJ CHECKOUT" + echo "example:" + echo " update_obs_eclipse_titan.sh home:osmith:latest osmocom/11.0.0" + exit 1 +fi prepare_git_repo() { cd "$DIR" @@ -27,7 +35,6 @@ --allow-unknown-package \ --git-skip-checkout \ --git-skip-fetch \ - --version-append "~osmocom" \ "$PROJ" \ eclipse-titan } -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40382?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6580ce81e092299850f177110e130ac1847e05a7 Gerrit-Change-Number: 40382 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: use eclipse-titan 11 in Dockerfile

by pespin

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40381?usp=email ) Change subject: testenv: use eclipse-titan 11 in Dockerfile ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I660dd6ca93a54087b1d41787c4ed2b64a3ad0437 Gerrit-Change-Number: 40381 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 May 2025 13:59:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: use eclipse-titan 11 in Dockerfile

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40381?usp=email ) Change subject: testenv: use eclipse-titan 11 in Dockerfile ...................................................................... testenv: use eclipse-titan 11 in Dockerfile Install eclipse-titan from osmocom:nightly instead of osmocom:latest, which now has version 11. Once we ensured everything works as expected, we will upgrade the version in osmocom:latest too. Change-Id: I660dd6ca93a54087b1d41787c4ed2b64a3ad0437 --- M _testenv/data/podman/Dockerfile 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/81/40381/1 diff --git a/_testenv/data/podman/Dockerfile b/_testenv/data/podman/Dockerfile index 097fdc4..8b8432c 100644 --- a/_testenv/data/podman/Dockerfile +++ b/_testenv/data/podman/Dockerfile @@ -4,7 +4,7 @@ # Arguments used after FROM must be specified again ARG OSMOCOM_REPO_TESTSUITE_MIRROR="https://downloads.osmocom.org" -ARG OSMOCOM_REPO="$OSMOCOM_REPO_TESTSUITE_MIRROR/packages/osmocom:/latest/Debian_12/" +ARG OSMOCOM_REPO="$OSMOCOM_REPO_TESTSUITE_MIRROR/packages/osmocom:/nightly/Debian_12/" # Copy from common dir COPY obs.key /obs.key @@ -121,9 +121,9 @@ pip3 install ./osmo-python-tests --break-system-packages && \ rm -rf osmo-python-tests -# Add eclipse-titan from osmocom:latest, invalidate cache when :latest changes +# Add eclipse-titan from osmocom:nightly, invalidate cache when :nightly changes RUN echo "deb [signed-by=/obs.key] $OSMOCOM_REPO ./" \ - > /etc/apt/sources.list.d/osmocom-latest.list + > /etc/apt/sources.list.d/osmocom-nightly.list ADD $OSMOCOM_REPO/Release /tmp/Release RUN set -x && \ apt-get update && \ @@ -131,7 +131,7 @@ eclipse-titan \ && \ apt-get clean && \ - rm /etc/apt/sources.list.d/osmocom-latest.list + rm /etc/apt/sources.list.d/osmocom-nightly.list # Add mongodb for open5gs-hss. Using the package from bullseye since bookworm # mongodb-org package is not available. Furthermore, manually install required -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I660dd6ca93a54087b1d41787c4ed2b64a3ad0437 Gerrit-Change-Number: 40381 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[L] Change in ...osmo-s1gw[master]: enft_kpi: retrieve per-eNB traffic counters

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email ) Change subject: enft_kpi: retrieve per-eNB traffic counters ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I498d2854447a2d53d2abddd38652f3e2bbb1fbdd Gerrit-Change-Number: 40281 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 27 May 2025 13:24:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

3 weeks, 6 days

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2025