May 2025 - gerrit-log - lists.osmocom.org

[L] Change in ...osmo-s1gw[master]: enft_kpi: retrieve per-eNB traffic counters

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email ) Change subject: enft_kpi: retrieve per-eNB traffic counters ...................................................................... Patch Set 8: (7 comments) File config/sys.config: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/0c8815a5_9177… : PS8, Line 24: %% {enft_kpi_enable, true}, %% whether to enable the NFT KPI module (default: false) where does the "e" from "enft" come from? At first sight looks like "nft" would be much more comprehensive for users. File include/s1gw_metrics.hrl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/2ede2696_17ee… : PS8, Line 40: %% NOTE: these counters shall not be listed in ?S1GW_COUNTERS, So simply this can be announced as "Per-eNB counters"? File rebar.config: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/f9b9d83c_c1ed… : PS8, Line 13: {git, "https://gitea.osmocom.org/vyanitskiy/enftables.git", {branch, "fixeria/json"}}}, can we have this in a "osmocom/master" or "master" branch instead? File src/enft_kpi.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/56cb0edb_175c… : PS8, Line 142: R1 = [nft_expr_match_ip_proto("udp", ?OP_NEQ), nft_expr_accept()], sounds like you may want to introduce atoms in the nft lib to express OP_NEQ and OP_EQ instead. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/7cb1115d_f696… : PS8, Line 145: nft_cmd_add_chain(TName, "gtpu-ul", "prerouting"), may make sense to have this strings as defines, to avoid potential typos. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/cd3ecb1f_23cf… : PS8, Line 341: case enb_add_nft_counters(ES0#{addr => Addr}, Cfg) of fyi this can take some time, and afaict you are doing it synchronously (handle_call), which means the caller (probably handling SCTP traffic) will become stuck for a while waiting for this. It's fine for now but can become a problem later. Also it's fine if the the caller of this call is per-session I guess. File src/osmo_s1gw_sup.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/486338f6_4571… : PS8, Line 81: EnftKpi = {enft_kpi, {enft_kpi, start_link, [enft_kpi_cfg()]}, I?m still wondering why this is called "enft" but above it's called "Pfcp" and not "Epfcp" or "Sctp" vs "Esctp". -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I498d2854447a2d53d2abddd38652f3e2bbb1fbdd Gerrit-Change-Number: 40281 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 May 2025 11:44:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 weeks, 5 days

1
0
0 0

[S] Change in ...osmo-s1gw[master]: s1ap_proxy: use Global-ENB-ID as logging prefix

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40384?usp=email ) Change subject: s1ap_proxy: use Global-ENB-ID as logging prefix ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib3584237e60274c0276e750728b2bb2950f376a4 Gerrit-Change-Number: 40384 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 May 2025 11:28:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 5 days

1
0
0 0

[S] Change in ...osmo-s1gw[master]: s1ap_proxy: use Global-ENB-ID as logging prefix

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40384?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: s1ap_proxy: use Global-ENB-ID as logging prefix ...................................................................... s1ap_proxy: use Global-ENB-ID as logging prefix Change-Id: Ib3584237e60274c0276e750728b2bb2950f376a4 --- M src/s1ap_proxy.erl 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/84/40384/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib3584237e60274c0276e750728b2bb2950f376a4 Gerrit-Change-Number: 40384 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[L] Change in ...osmo-s1gw[master]: enft_kpi: retrieve per-eNB traffic counters

by fixeria

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: enft_kpi: retrieve per-eNB traffic counters ...................................................................... enft_kpi: retrieve per-eNB traffic counters Change-Id: I498d2854447a2d53d2abddd38652f3e2bbb1fbdd Related: SYS#7307 --- M config/sys.config M debian/control M include/s1gw_metrics.hrl M rebar.config M rebar.lock A src/enft_kpi.erl M src/osmo_s1gw.app.src M src/osmo_s1gw_sup.erl M src/s1ap_proxy.erl M test/s1ap_proxy_test.erl 10 files changed, 686 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/81/40281/8 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I498d2854447a2d53d2abddd38652f3e2bbb1fbdd Gerrit-Change-Number: 40281 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[L] Change in ...osmo-s1gw[master]: enft_kpi: retrieve per-eNB traffic counters

by fixeria

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: enft_kpi: retrieve per-eNB traffic counters ...................................................................... enft_kpi: retrieve per-eNB traffic counters Change-Id: I498d2854447a2d53d2abddd38652f3e2bbb1fbdd Related: SYS#7307 --- M config/sys.config M debian/control M include/s1gw_metrics.hrl M rebar.config M rebar.lock A src/enft_kpi.erl M src/osmo_s1gw.app.src M src/osmo_s1gw_sup.erl M src/s1ap_proxy.erl M test/s1ap_proxy_test.erl 10 files changed, 692 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/81/40281/7 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I498d2854447a2d53d2abddd38652f3e2bbb1fbdd Gerrit-Change-Number: 40281 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: use eclipse-titan 11 in Dockerfile

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40381?usp=email ) Change subject: testenv: use eclipse-titan 11 in Dockerfile ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'm away from tomorrow until Monday, so I'll wait with merge until Monday as there might be some fal […] (unresolve comment) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I660dd6ca93a54087b1d41787c4ed2b64a3ad0437 Gerrit-Change-Number: 40381 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 28 May 2025 09:09:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: use eclipse-titan 11 in Dockerfile

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40381?usp=email ) Change subject: testenv: use eclipse-titan 11 in Dockerfile ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm away from tomorrow until Monday, so I'll wait with merge until Monday as there might be some fallout. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I660dd6ca93a54087b1d41787c4ed2b64a3ad0437 Gerrit-Change-Number: 40381 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 28 May 2025 08:57:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 weeks, 5 days

1
0
0 0

[S] Change in osmo-ci[master]: OBS: update_obs_eclipse_titan: update

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40382?usp=email ) Change subject: OBS: update_obs_eclipse_titan: update ...................................................................... OBS: update_obs_eclipse_titan: update * Set the branch as argument instead of hardcoding it. * Don't use --version-append, the ~osmocom part will be added to debian/changelog instead when pushing new versions. * Add usage description. Change-Id: I6580ce81e092299850f177110e130ac1847e05a7 --- M scripts/obs/update_obs_eclipse_titan.sh 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/scripts/obs/update_obs_eclipse_titan.sh b/scripts/obs/update_obs_eclipse_titan.sh index 6efb7c6..2439777 100755 --- a/scripts/obs/update_obs_eclipse_titan.sh +++ b/scripts/obs/update_obs_eclipse_titan.sh @@ -3,7 +3,15 @@ DIR="$(realpath "$(dirname "$0")")" PROJ="$1" GIT_URL="https://gitea.osmocom.org/osmith/titan.core" -CHECKOUT="osmocom/9.0.0" +CHECKOUT="$2" + +if [ $# != 2 ]; then + echo "usage:" + echo " update_obs_eclipse_titan.sh PROJ CHECKOUT" + echo "example:" + echo " update_obs_eclipse_titan.sh home:osmith:latest osmocom/11.0.0" + exit 1 +fi prepare_git_repo() { cd "$DIR" @@ -27,7 +35,6 @@ --allow-unknown-package \ --git-skip-checkout \ --git-skip-fetch \ - --version-append "~osmocom" \ "$PROJ" \ eclipse-titan } -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40382?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6580ce81e092299850f177110e130ac1847e05a7 Gerrit-Change-Number: 40382 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: log_merge.sh: Merge all logs if no test cases are found

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40383?usp=email ) Change subject: log_merge.sh: Merge all logs if no test cases are found ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File log_merge.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40383/comment/a2e38fc9_3f65… : PS1, Line 66: echo "Couldn't find test cases! Merging erverything" ```suggestion >&2 echo "log_merge: WARNING: Couldn't find logs for test cases! Merging everything" ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifc68e42022e8b2990d3c5221b3901f255e4e759b Gerrit-Change-Number: 40383 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 May 2025 08:45:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

3 weeks, 5 days

1
0
0 0

[S] Change in osmo-ci[master]: OBS: update_obs_eclipse_titan: update

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40382?usp=email ) Change subject: OBS: update_obs_eclipse_titan: update ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40382?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6580ce81e092299850f177110e130ac1847e05a7 Gerrit-Change-Number: 40382 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 May 2025 07:20:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 5 days

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2025