March 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-mgw[master]: mgw: Validate CallID before updating endp->x_osmo_ign

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39715?usp=email ) Change subject: mgw: Validate CallID before updating endp->x_osmo_ign ...................................................................... mgw: Validate CallID before updating endp->x_osmo_ign This allows already starting to mark a clear line in CRCX handling function between *read-only parsing + validation* and *read-write allocation and update* of objects. This in turn will allow further clean up on the second mentioned step. Change-Id: Ia41f7383171bb24f48297456935c633536aa7b05 --- M src/libosmo-mgcp/mgcp_msg.c M src/libosmo-mgcp/mgcp_protocol.c 2 files changed, 22 insertions(+), 11 deletions(-) Approvals: pespin: Looks good to me, approved daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/src/libosmo-mgcp/mgcp_msg.c b/src/libosmo-mgcp/mgcp_msg.c index ebaa32a..2269a66 100644 --- a/src/libosmo-mgcp/mgcp_msg.c +++ b/src/libosmo-mgcp/mgcp_msg.c @@ -276,10 +276,6 @@ if (!endp) return -1; - /* Accept any CallID for "X-Osmo-IGN: C" */ - if (endp->x_osmo_ign & MGCP_X_OSMO_IGN_CALLID) - return 0; - if (!callid) return -1; if (!endp->callid) diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index ce397c8..b985a1b 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -928,12 +928,14 @@ } } - /* Update endp->x_osmo_ign: */ - endp->x_osmo_ign |= hpars->x_osmo_ign; - /* Check if this endpoint already serves a call, if so, check if the - * callids match up so that we are sure that this is our call */ - if (endp->callid && mgcp_verify_call_id(endp, hpars->callid)) { + * callids match up so that we are sure that this is our call. + * Do check only if endpoint was (or is by current CRCX) configured + * to explicitly ignore it ("X-Osmo-IGN: C"). + */ + if (endp->callid && + !((endp->x_osmo_ign | hpars->x_osmo_ign) & MGCP_X_OSMO_IGN_CALLID) && + mgcp_verify_call_id(endp, hpars->callid)) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: already seized by other call (%s)\n", endp->callid); @@ -949,6 +951,14 @@ } } + /******************************************************************* + * Allocate and update endpoint and conn. + * From here on below we start updating endpoing and creating conn: + *******************************************************************/ + + /* Update endp->x_osmo_ign: */ + endp->x_osmo_ign |= hpars->x_osmo_ign; + if (!endp->callid) { /* Claim endpoint resources. This will also set the callid, * creating additional connections will only be possible if @@ -1122,7 +1132,11 @@ return create_err_response(rq->trunk, NULL, -rc, "MDCX", pdata->trans); } - if (hpars->callid && mgcp_verify_call_id(endp, hpars->callid) < 0) { + /* If a CallID is provided during MDCX, validate (unless endp was explicitly configured to ignore it + * through "X-Osmo-IGN: C") that it matches the one previously set. */ + if (hpars->callid && + !(endp->x_osmo_ign & MGCP_X_OSMO_IGN_CALLID) && + mgcp_verify_call_id(endp, hpars->callid) < 0) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_INVALID_CALLID)); return create_err_response(endp, endp, 516, "MDCX", pdata->trans); } @@ -1328,7 +1342,8 @@ rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_UNHANDLED_PARAM)); return create_err_response(rq->trunk, NULL, 539, "DLCX", pdata->trans); } - if (mgcp_verify_call_id(endp, hpars->callid) != 0) { + if (!(endp->x_osmo_ign & MGCP_X_OSMO_IGN_CALLID) && + mgcp_verify_call_id(endp, hpars->callid) != 0) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_INVALID_CALLID)); return create_err_response(endp, endp, 516, "DLCX", pdata->trans); } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39715?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia41f7383171bb24f48297456935c633536aa7b05 Gerrit-Change-Number: 39715 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months

1
0
0 0

[S] Change in osmo-mgw[master]: mgw: Delay osmux trunk setup to point where it is really needed

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39716?usp=email ) Change subject: mgw: Delay osmux trunk setup to point where it is really needed ...................................................................... mgw: Delay osmux trunk setup to point where it is really needed This way code is simplified by putting all osmux code together. Change-Id: I27f7355ee99f1781fc2034a23c7cca756fb203d2 --- M src/libosmo-mgcp/mgcp_osmux.c M src/libosmo-mgcp/mgcp_protocol.c 2 files changed, 17 insertions(+), 25 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, approved fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index 31f128a..620220f 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -495,6 +495,9 @@ int ret, fd; struct mgcp_config *cfg = trunk->cfg; + if (cfg->osmux.initialized) + return 0; + /* So far we only support running on one trunk: */ OSMO_ASSERT(trunk == mgcp_trunk_by_num(cfg, MGCP_TRUNK_VIRTUAL, MGCP_VIRT_TRUNK_ID)); @@ -507,19 +510,19 @@ ret = mgcp_create_bind(cfg->osmux.local_addr_v4, cfg->osmux.local_port, cfg->endp_dscp, cfg->endp_priority); if (ret < 0) { - LOGP(DOSMUX, LOGL_ERROR, "Cannot bind OSMUX IPv4 socket to %s:%u\n", - cfg->osmux.local_addr_v4, cfg->osmux.local_port); + LOGPTRUNK(trunk, DOSMUX, LOGL_ERROR, "Cannot bind OSMUX IPv4 socket to %s:%u\n", + cfg->osmux.local_addr_v4, cfg->osmux.local_port); goto out_free_v4; } fd = ret; ret = osmo_iofd_register(osmux_fd_v4, fd); if (ret < 0) { - LOGP(DOSMUX, LOGL_ERROR, "Cannot register OSMUX IPv4 socket %s\n", osmo_sock_get_name2(fd)); + LOGPTRUNK(trunk, DOSMUX, LOGL_ERROR, "Cannot register OSMUX IPv4 socket %s\n", osmo_sock_get_name2(fd)); close(fd); goto out_free_v4; } - LOGP(DOSMUX, LOGL_INFO, "OSMUX IPv4 socket listening on %s\n", osmo_sock_get_name2(fd)); + LOGPTRUNK(trunk, DOSMUX, LOGL_INFO, "OSMUX IPv4 socket listening on %s\n", osmo_sock_get_name2(fd)); } osmux_fd_v6 = osmo_iofd_setup(trunk, -1, "osmux_fd_v6", OSMO_IO_FD_MODE_RECVFROM_SENDTO, &osmux_ioops, trunk); @@ -531,8 +534,8 @@ ret = mgcp_create_bind(cfg->osmux.local_addr_v6, cfg->osmux.local_port, cfg->endp_dscp, cfg->endp_priority); if (ret < 0) { - LOGP(DOSMUX, LOGL_ERROR, "Cannot bind OSMUX IPv6 socket to [%s]:%u\n", - cfg->osmux.local_addr_v6, cfg->osmux.local_port); + LOGPTRUNK(trunk, DOSMUX, LOGL_ERROR, "Cannot bind OSMUX IPv6 socket to [%s]:%u\n", + cfg->osmux.local_addr_v6, cfg->osmux.local_port); goto out_free_v6; } fd = ret; @@ -543,9 +546,10 @@ close(fd); goto out_free_v6; } - LOGP(DOSMUX, LOGL_INFO, "OSMUX IPv6 socket listening on %s\n", osmo_sock_get_name2(fd)); + LOGPTRUNK(trunk, DOSMUX, LOGL_INFO, "OSMUX IPv6 socket listening on %s\n", osmo_sock_get_name2(fd)); } cfg->osmux.initialized = true; + LOGPTRUNK(trunk, DOSMUX, LOGL_NOTICE, "OSMUX socket has been set up\n"); return 0; out_free_v6: @@ -557,6 +561,7 @@ osmo_iofd_free(osmux_fd_v4); osmux_fd_v4 = NULL; out: + LOGPTRUNK(trunk, DOSMUX, LOGL_ERROR, "Cannot init OSMUX\n"); return -1; } diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index b985a1b..35d0811 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -702,20 +702,6 @@ codec->frame_duration_den; } -static int mgcp_trunk_osmux_init_if_needed(struct mgcp_trunk *trunk) -{ - if (trunk->cfg->osmux.initialized) - return 0; - - if (osmux_init(trunk) < 0) { - LOGPTRUNK(trunk, DOSMUX, LOGL_ERROR, "Cannot init OSMUX\n"); - return -3; - } - LOGPTRUNK(trunk, DOSMUX, LOGL_NOTICE, "OSMUX socket has been set up\n"); - - return 0; -} - /* Apply parsed SDP information stored in struct mgcp_parse_sdp to conn_rtp: */ static int handle_sdp(struct mgcp_conn_rtp *conn, struct mgcp_request_data *rq) { @@ -905,10 +891,6 @@ return create_err_response(endp, endp, 517, "CRCX", pdata->trans); } - /* Make sure osmux is setup: */ - if (hpars->remote_osmux_cid != MGCP_PARSE_HDR_PARS_OSMUX_CID_UNSET) - mgcp_trunk_osmux_init_if_needed(trunk); - /* Check if we are able to accept the creation of another connection */ if (mgcp_endp_is_full(endp)) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, @@ -990,6 +972,11 @@ /* If X-Osmux (remote CID) was received, alloc next avail CID as local CID */ if (hpars->remote_osmux_cid != MGCP_PARSE_HDR_PARS_OSMUX_CID_UNSET) { + /* Make sure osmux is setup: */ + if (osmux_init(trunk) < 0) { + rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_NO_OSMUX)); + goto error2; + } if (osmux_init_conn(conn_rtp) < 0) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_NO_OSMUX)); goto error2; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39716?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I27f7355ee99f1781fc2034a23c7cca756fb203d2 Gerrit-Change-Number: 39716 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: Store Command as enum in struct mgcp_request_data

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39717?usp=email ) Change subject: mgw: Store Command as enum in struct mgcp_request_data ...................................................................... mgw: Store Command as enum in struct mgcp_request_data This simplifies code further, and will simpify more code since we'll have some easy way to check for the command we are in during a request. Change-Id: I2d4b5ddb93376b59413b34c9668c41157ab05497 --- M include/osmocom/mgcp/mgcp.h M include/osmocom/mgcp/mgcp_protocol.h M src/libosmo-mgcp/mgcp_protocol.c 3 files changed, 67 insertions(+), 76 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/include/osmocom/mgcp/mgcp.h b/include/osmocom/mgcp/mgcp.h index 4dff4d0..41eee42 100644 --- a/include/osmocom/mgcp/mgcp.h +++ b/include/osmocom/mgcp/mgcp.h @@ -50,11 +50,6 @@ struct mgcp_config; struct mgcp_trunk; struct mgcp_rtp_end; - -#define MGCP_ENDP_CRCX 1 -#define MGCP_ENDP_DLCX 2 -#define MGCP_ENDP_MDCX 3 - /* * what to do with the msg? * - continue as usual? diff --git a/include/osmocom/mgcp/mgcp_protocol.h b/include/osmocom/mgcp/mgcp_protocol.h index 427fe5f..4fed248 100644 --- a/include/osmocom/mgcp/mgcp_protocol.h +++ b/include/osmocom/mgcp/mgcp_protocol.h @@ -8,6 +8,18 @@ #include <osmocom/mgcp/mgcp_common.h> #include <osmocom/mgcp/mgcp_codec.h> +enum mgcp_verb { + MGCP_VERB_CRCX, + MGCP_VERB_MDCX, + MGCP_VERB_DLCX, + MGCP_VERB_AUEP, + MGCP_VERB_RQNT, + MGCP_VERB_RSIP, +}; +extern const struct value_string mgcp_verb_names[]; +static inline const char *mgcp_verb_name(enum mgcp_verb val) +{ return get_value_string(mgcp_verb_names, val); } + #define MGCP_PARSE_SDP_PTIME_UNSET (-1) #define MGCP_PARSE_SDP_MAXPTIME_UNSET (-1) diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 35d0811..36d9ebf 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -59,6 +59,16 @@ return debug_last_endpoint_name; } +const struct value_string mgcp_verb_names[] = { + { MGCP_VERB_CRCX, "CRCX" }, + { MGCP_VERB_MDCX, "MDCX" }, + { MGCP_VERB_DLCX, "DLCX" }, + { MGCP_VERB_AUEP, "AUEP" }, + { MGCP_VERB_RSIP, "RSIP" }, + { MGCP_VERB_RQNT, "RQNT" }, + {} +}; + const struct value_string mgcp_connection_mode_strs[] = { { MGCP_CONN_NONE, "none" }, { MGCP_CONN_RECV_SEND, "sendrecv" }, @@ -81,7 +91,8 @@ /* Request data passed to the request handler */ struct mgcp_request_data { - /* request name (e.g. "MDCX") */ + enum mgcp_verb verb; + /* Verb string (e.g. "MDCX") */ char name[4+1]; /* parsing results from the MGCP header (trans id, endpoint name ...) */ @@ -103,55 +114,12 @@ int mgcp_cause; }; -/* Request handler specification, here we specify an array with function - * pointers to the various MGCP requests implemented below */ -struct mgcp_request { - /* request name (e.g. "MDCX") */ - char *name; - - /* function pointer to the request handler */ - struct msgb *(*handle_request)(struct mgcp_request_data *data); - - /* a human readable name that describes the request */ - char *debug_name; -}; - static struct msgb *handle_audit_endpoint(struct mgcp_request_data *data); static struct msgb *handle_create_con(struct mgcp_request_data *data); static struct msgb *handle_delete_con(struct mgcp_request_data *data); static struct msgb *handle_modify_con(struct mgcp_request_data *data); static struct msgb *handle_rsip(struct mgcp_request_data *data); static struct msgb *handle_noti_req(struct mgcp_request_data *data); -static const struct mgcp_request mgcp_requests[] = { - { .name = "AUEP", .handle_request = handle_audit_endpoint, .debug_name = "AuditEndpoint" }, - { - .name = "CRCX", - .handle_request = handle_create_con, - .debug_name = "CreateConnection", - }, - { - .name = "DLCX", - .handle_request = handle_delete_con, - .debug_name = "DeleteConnection", - }, - { - .name = "MDCX", - .handle_request = handle_modify_con, - .debug_name = "ModifiyConnection", - }, - { - .name = "RQNT", - .handle_request = handle_noti_req, - .debug_name = "NotificationRequest", - }, - - /* SPEC extension */ - { - .name = "RSIP", - .handle_request = handle_rsip, - .debug_name = "ReSetInProgress", - }, -}; /* Initalize transcoder */ static int setup_rtp_processing(struct mgcp_endpoint *endp, @@ -356,7 +324,7 @@ struct rate_ctr_group *rate_ctrs = cfg->ratectr.mgcp_general_ctr_group; struct mgcp_parse_data pdata; struct mgcp_request_data rq; - int rc, i, code, handled = 0; + int rc, code; struct msgb *resp = NULL; char *data; @@ -385,12 +353,23 @@ return NULL; } - - /* Parse message, extract endpoint name and transaction identifier and request name etc. */ + /* Initialize parsing data. */ memset(&pdata, 0, sizeof(pdata)); memset(&rq, 0, sizeof(rq)); pdata.cfg = cfg; + + /* Parse command name: */ memcpy(rq.name, (const char *)&msg->l2h[0], sizeof(rq.name)-1); + rc = get_string_value(mgcp_verb_names, rq.name); + if (rc < 0) { + LOGP(DLMGCP, LOGL_ERROR, "%s: failed to parse command name in MCGP message\n", rq.name); + rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_FAIL_MSG_PARSE)); + rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_MSGS_UNHANDLED)); + return create_err_response(cfg, NULL, 504, rq.name, "000000"); + } + rq.verb = rc; + + /* Parse message, extract endpoint name and transaction identifier and request name etc. */ msg->l3h = &msg->l2h[4]; data = mgcp_strline((char *)msg->l3h, &pdata.save); rc = mgcp_parse_header(&pdata, data); @@ -443,31 +422,36 @@ } } - /* Find an appropriate handler for the current request and execute it */ - for (i = 0; i < ARRAY_SIZE(mgcp_requests); i++) { - if (strcmp(mgcp_requests[i].name, rq.name) == 0) { - /* Execute request handler */ - if (rq.endp) - LOGP(DLMGCP, LOGL_INFO, - "%s: executing request handler \"%s\" for endpoint resource \"%s\"\n", rq.name, - mgcp_requests[i].debug_name, rq.endp->name); - else - LOGP(DLMGCP, LOGL_INFO, - "%s: executing request handler \"%s\" for trunk resource of endpoint \"%s\"\n", - rq.name, mgcp_requests[i].debug_name, pdata.epname); - resp = mgcp_requests[i].handle_request(&rq); - handled = 1; - break; - } + /* Execute request handler */ + if (rq.endp) + LOGP(DLMGCP, LOGL_INFO, "%s: executing request handler for endpoint resource \"%s\"\n", + rq.name, rq.endp->name); + else + LOGP(DLMGCP, LOGL_INFO, "%s: executing request handler for trunk resource of endpoint \"%s\"\n", + rq.name, pdata.epname); + switch (rq.verb) { + case MGCP_VERB_AUEP: + resp = handle_audit_endpoint(&rq); + break; + case MGCP_VERB_CRCX: + resp = handle_create_con(&rq); + break; + case MGCP_VERB_DLCX: + resp = handle_delete_con(&rq); + break; + case MGCP_VERB_MDCX: + resp = handle_modify_con(&rq); + break; + case MGCP_VERB_RQNT: + resp = handle_noti_req(&rq); + break; + case MGCP_VERB_RSIP: + resp = handle_rsip(&rq); + break; + default: + OSMO_ASSERT(0); } - - /* Check if the MGCP request was handled and increment rate counters accordingly. */ - if (handled) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_MSGS_HANDLED)); - } else { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_MSGS_UNHANDLED)); - LOGP(DLMGCP, LOGL_ERROR, "MSG with type: '%.4s' not handled\n", &msg->l2h[0]); - } + rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_MSGS_HANDLED)); return resp; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2d4b5ddb93376b59413b34c9668c41157ab05497 Gerrit-Change-Number: 39717 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: Allocate req and pdata with talloc

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39722?usp=email ) Change subject: mgw: Allocate req and pdata with talloc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2b971d0c8268f4c0a30b84b54a2e5f16ada4ecdb Gerrit-Change-Number: 39722 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Mar 2025 12:17:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[XS] Change in osmo-mgw[master]: mgw: Add backpointer from pdata to req to have context available

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39720?usp=email ) Change subject: mgw: Add backpointer from pdata to req to have context available ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39720?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I464258ca1a8817d58ae5c5426dfc3b7cee6763d3 Gerrit-Change-Number: 39720 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Mar 2025 12:17:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: Store Command as enum in struct mgcp_request_data

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39717?usp=email ) Change subject: mgw: Store Command as enum in struct mgcp_request_data ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2d4b5ddb93376b59413b34c9668c41157ab05497 Gerrit-Change-Number: 39717 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Mar 2025 12:17:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[S] Change in osmo-mgw[master]: mgw: Validate CallID before updating endp->x_osmo_ign

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39715?usp=email ) Change subject: mgw: Validate CallID before updating endp->x_osmo_ign ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39715?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia41f7383171bb24f48297456935c633536aa7b05 Gerrit-Change-Number: 39715 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Mar 2025 12:17:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[M] Change in pysim[master]: [2/7] personalization: refactor ConfigurableParameter, Iccid, Imsi

by neels

Attention is currently required from: fixeria. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email ) Change subject: [2/7] personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 4: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/ade6f2a3_1c874123?usp=em… : PS4, Line 42: Subclasses have to implement the apply_val() classmethods > when i tried to detect whether a class is abstract, it didn't work. […] (re "it didn't work": in two ways: i could not get is_abstract() to return True, and also it turned out that what i planned to probe the abstract-ness for will not work out, because some "abstract" classes actually implement the function with generic parts that subclasses call. So the "semantic" abstractness concept in the end actually needs to be a boolean flag. Simplest, easiest.) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Mar 2025 12:08:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months

1
0
0 0

[M] Change in pysim[master]: [2/7] personalization: refactor ConfigurableParameter, Iccid, Imsi

by neels

Attention is currently required from: fixeria. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email ) Change subject: [2/7] personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 4: (2 comments) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/02568da7_49ca10eb?usp=em… : PS4, Line 40: This class is abstract, you will only use subclasses in practice. > This is exactly what `abc.ABC` is for. […] (let's keep one of the two conversations; closing this one) https://gerrit.osmocom.org/c/pysim/+/39742/comment/c0e6db77_0254e4db?usp=em… : PS4, Line 42: Subclasses have to implement the apply_val() classmethods > ... and this would have been obvious if you just defined it as follows: […] when i tried to detect whether a class is abstract, it didn't work. I think i tried introspect.isabstract() or similar. There is no need to enforce the abstractness. It's fine to call the abstract method, even. it is only "semantically" abstract, not in the strict language sense, like in C++ where a function pointer is actually NULL. In the code I'm working with, there are tons of abstract methods, but i see no abc. If I don't need enforcing, it doesn't work as is_abstract(), and i can just write "abstract" in the comment, then i can reduce this code cruft without any disadvantage. right? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Mar 2025 11:59:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: Allocate req and pdata with talloc

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39722?usp=email ) Change subject: mgw: Allocate req and pdata with talloc ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2b971d0c8268f4c0a30b84b54a2e5f16ada4ecdb Gerrit-Change-Number: 39722 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Mar 2025 10:42:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025