March 2025 - gerrit-log - lists.osmocom.org

[L] Change in osmo-mgw[master]: mgw: Split MGCP LocalConnectionOptions parsing from updating endpoint

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39723?usp=email ) Change subject: mgw: Split MGCP LocalConnectionOptions parsing from updating endpoint ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39723?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: If75731fb92329dca6d092ffc7ff17cb354d28c0d Gerrit-Change-Number: 39723 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Mar 2025 10:12:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[XS] Change in docker-playground[master]: debian-bookworm-build: add linting tools

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/39763?usp=email ) Change subject: debian-bookworm-build: add linting tools ...................................................................... debian-bookworm-build: add linting tools Prepare for being able to run these linting tools in CI. * clang-format gets used for osmo-asf4-dfu * ruff gets used for testenv in osmo-ttcn3-hacks Related: osmo-asf4-dfu I9768bc2590ca5306ee19d3276f0953c6b0b6f926 Related: osmo-ttcn3-hacks 157897523e54762ec3739cd7842c7b5f5d724ac2 Change-Id: I0a287b991a3efa50090587739529f95de32225bc --- M debian-bookworm-build/Dockerfile 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian-bookworm-build/Dockerfile b/debian-bookworm-build/Dockerfile index 3efbc6e..8fbc9d3 100644 --- a/debian-bookworm-build/Dockerfile +++ b/debian-bookworm-build/Dockerfile @@ -61,6 +61,7 @@ bzip2 \ ca-certificates \ ccache \ + clang-format \ cmake \ coccinelle \ cppcheck \ @@ -180,6 +181,7 @@ 'git+https://github.com/podshumok/python-smpplib.git' \ 'pydbus' \ 'pysispm' \ + 'ruff' \ 'sphinx' \ 'sphinxcontrib-napoleon' \ -r /tmp/pysim_requirements.txt -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0a287b991a3efa50090587739529f95de32225bc Gerrit-Change-Number: 39763 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months

1
0
0 0

[XS] Change in docker-playground[master]: debian-bookworm-build: add linting tools

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/39763?usp=email ) Change subject: debian-bookworm-build: add linting tools ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0a287b991a3efa50090587739529f95de32225bc Gerrit-Change-Number: 39763 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Mar 2025 10:07:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[XS] Change in docker-playground[master]: debian-bookworm-build: add linting tools

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/39763?usp=email ) Change subject: debian-bookworm-build: add linting tools ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0a287b991a3efa50090587739529f95de32225bc Gerrit-Change-Number: 39763 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Mar 2025 09:58:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: deps: Update titan.ProtocolModules.M3UA to upstream master

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39764?usp=email ) Change subject: deps: Update titan.ProtocolModules.M3UA to upstream master ...................................................................... deps: Update titan.ProtocolModules.M3UA to upstream master MR contained in our fork was merged [1], so we can use upstream again. [1] https://gitlab.eclipse.org/eclipse/titan/titan.ProtocolModules.M3UA/-/merge… This patch doesn't contain an update hash because it was merged as fast-forward so the commit hash now in master HEAD did not change from the one in our repo fork branch. Change-Id: Icf411559d3ba5bc699d8a66d7c42e7034392a9e6 --- M deps/Makefile 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/39764/1 diff --git a/deps/Makefile b/deps/Makefile index 61daa48..9e0229f 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -34,6 +34,7 @@ titan.ProtocolModules.JSON_v07_2006 \ titan.ProtocolModules.L2TP \ titan.ProtocolModules.LLC_v7.1.0 \ + titan.ProtocolModules.M3UA \ titan.ProtocolModules.MobileL3_v13.4.0 \ titan.ProtocolModules.SMPP \ titan.ProtocolModules.TCP \ @@ -65,8 +66,7 @@ OSMOGITHUB_REPOS= titan.TestPorts.SCTPasp \ titan.TestPorts.MTP3asp \ titan.ProtocolEmulations.SCCP \ - titan.ProtocolModules.BSSGP_v13.0.0 \ - titan.ProtocolModules.M3UA + titan.ProtocolModules.BSSGP_v13.0.0 OSMOGERRIT_REPOS= osmo-uecups -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39764?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icf411559d3ba5bc699d8a66d7c42e7034392a9e6 Gerrit-Change-Number: 39764 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months

1
0
0 0

[S] Change in aram-applet[master]: AccessRuleMaster: allow locking of STORE DATA commands

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/aram-applet/+/39615?usp=email ) Change subject: AccessRuleMaster: allow locking of STORE DATA commands ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: I did not check the spec, but assuming processData can only be accessed by the secure domain (so with additional authentication) as it was explained, this should work. -- To view, visit https://gerrit.osmocom.org/c/aram-applet/+/39615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: aram-applet Gerrit-Branch: master Gerrit-Change-Id: I86437844585c22fc4280cc48b99edbb56e3159db Gerrit-Change-Number: 39615 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Mar 2025 07:54:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[L] Change in osmo-asf4-dfu[master]: clang-format

by osmith

Attention is currently required from: Hoernchen, laforge. osmith has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39470?usp=email ) Change subject: clang-format ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Patchset: PS2: > I'd say this needs some more explanation and possibly integration? What is the purpose of the file? […] * pre-commit hook is there now * server side: needs clang-format added to the docker container first: https://gerrit.osmocom.org/c/docker-playground/+/39763, I can adjust contrib/jenkins.sh in a follow-up patch after both are merged so we don't need to block here File contrib/pre-commit-hook: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39470/comment/562950a5_998dabd… : PS3, Line 1: #!/usr/bin/env bash maybe make this executable? -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39470?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I9768bc2590ca5306ee19d3276f0953c6b0b6f926 Gerrit-Change-Number: 39470 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 11 Mar 2025 07:33:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

4 months

1
0
0 0

[XS] Change in docker-playground[master]: debian-bookworm-build: add linting tools

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/39763?usp=email ) Change subject: debian-bookworm-build: add linting tools ...................................................................... debian-bookworm-build: add linting tools Prepare for being able to run these linting tools in CI. * clang-format gets used for osmo-asf4-dfu * ruff gets used for testenv in osmo-ttcn3-hacks Related: osmo-asf4-dfu I9768bc2590ca5306ee19d3276f0953c6b0b6f926 Related: osmo-ttcn3-hacks 157897523e54762ec3739cd7842c7b5f5d724ac2 Change-Id: I0a287b991a3efa50090587739529f95de32225bc --- M debian-bookworm-build/Dockerfile 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/63/39763/1 diff --git a/debian-bookworm-build/Dockerfile b/debian-bookworm-build/Dockerfile index 3efbc6e..8fbc9d3 100644 --- a/debian-bookworm-build/Dockerfile +++ b/debian-bookworm-build/Dockerfile @@ -61,6 +61,7 @@ bzip2 \ ca-certificates \ ccache \ + clang-format \ cmake \ coccinelle \ cppcheck \ @@ -180,6 +181,7 @@ 'git+https://github.com/podshumok/python-smpplib.git' \ 'pydbus' \ 'pysispm' \ + 'ruff' \ 'sphinx' \ 'sphinxcontrib-napoleon' \ -r /tmp/pysim_requirements.txt -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0a287b991a3efa50090587739529f95de32225bc Gerrit-Change-Number: 39763 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months

1
0
0 0

[XS] Change in osmo-ggsn[master]: gtp: Send RAT type IE in update context request if present

by laforge

Attention is currently required from: daniel, lynxis lazus. laforge has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/39700?usp=email ) Change subject: gtp: Send RAT type IE in update context request if present ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39700?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idbabd123838b88cb0a2407480ca5fab10312a547 Gerrit-Change-Number: 39700 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Mar 2025 19:45:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[L] Change in ...logger_gsmtap[master]: Initial commit

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/39552?usp=email ) Change subject: Initial commit ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: can you simply set it manually to V+1? I guess the second or third commit should then add some build verfication? -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/39552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: I30fad55b6e9d8d9f975de4deb2f97c1e98ae5c5e Gerrit-Change-Number: 39552 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Mar 2025 19:45:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025