February 2025 - gerrit-log - lists.osmocom.org

[XS] Change in aram-applet[master]: gradlew: fix "Unrecognized option: --add-opens"

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/aram-applet/+/39583?usp=email ) Change subject: gradlew: fix "Unrecognized option: --add-opens" ...................................................................... gradlew: fix "Unrecognized option: --add-opens" Comment out the code that causes the following errors during build: + ./gradlew test Unrecognized option: --add-opens Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit. The build did not abort but this is distracting. Change-Id: I788e44cfe20ba6a331e8247677ecb5a526c433f7 --- M gradlew 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/gradlew b/gradlew index 17a9170..f03a59b 100755 --- a/gradlew +++ b/gradlew @@ -162,9 +162,10 @@ APP_ARGS=$(save "$@") # Collect all arguments for the java command, following the shell quoting and substitution rules -if $JAVACMD --add-opens java.base/java.lang=ALL-UNNAMED -version ; then - DEFAULT_JVM_OPTS="--add-opens java.base/java.lang=ALL-UNNAMED $DEFAULT_JVM_OPTS" -fi +# NOTE: commented out as this doesn't work with openjdk-8 +# if $JAVACMD --add-opens java.base/java.lang=ALL-UNNAMED -version ; then +# DEFAULT_JVM_OPTS="--add-opens java.base/java.lang=ALL-UNNAMED $DEFAULT_JVM_OPTS" +# fi eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS" -- To view, visit https://gerrit.osmocom.org/c/aram-applet/+/39583?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: aram-applet Gerrit-Branch: master Gerrit-Change-Id: I788e44cfe20ba6a331e8247677ecb5a526c433f7 Gerrit-Change-Number: 39583 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[S] Change in aram-applet[master]: README: update after setting up gerrit and jenkins

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/aram-applet/+/39584?usp=email ) Change subject: README: update after setting up gerrit and jenkins ...................................................................... README: update after setting up gerrit and jenkins Change-Id: Ia27839881c0c739f58835ed883079b3ea60cb0e1 --- M README.md 1 file changed, 24 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/README.md b/README.md index b11c171..e6fb5f3 100644 --- a/README.md +++ b/README.md @@ -1,11 +1,23 @@ # ARAM Applet -[![Build Status](https://travis-ci.org/bertrandmartel/aram-applet.svg?branch=master)… -[![Coverage Status](https://coveralls.io/repos/github/bertrandmartel/aram-applet/badge.svg?branch=master)](https://coveralls.io/github/bertrandmartel/aram-applet?branch=master) - JavaCard implementation of Global Platform Access Rule Application Master (ARA-M) applet according to [Secure Element Access Control v1.1](https://globalplatform.org/specs-library/secure-element-access-contro… specification. +## Contributing + +The git repository for this project is at: +https://gitea.osmocom.org/sim-card/aram-applet + +This project was forked from: +https://github.com/bertrandmartel/aram-applet + +We use Gerrit for patch submission and review. See the +[Osmocom wiki](https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit) +for details. + +The current patch queue for aram-applet can be seen at: +https://gerrit.osmocom.org/#/q/project:aram-applet+status:open + ## What is this ? ARA-M is an application (typically present on a SIM card) which manages access rules that are enforced by an Access Control Enforcer (typically present on [Android device](https://github.com/seek-for-android/pool/wiki)). @@ -49,7 +61,7 @@ #### Prepare the repository ```bash -git clone git@github.com:bertrandmartel/aram-applet.git +git clone https://gitea.osmocom.org/sim-card/aram-applet cd aram-applet git submodule update --init ``` @@ -64,6 +76,9 @@ * Older JDK versions are available here: <https://www.oracle.com/de/java/technologies/javase/jdk11-archive-downloads.…> +Find the pre-built applet of current master as artifact in the +[Osmocom Jenkins](https://jenkins.osmocom.org/jenkins/job/master-aram-applet/lastSuc…. + ```bash JAVA_HOME=/path/to/your/jdk1.8.0_421/ ./gradlew build ``` @@ -146,4 +161,8 @@ ## License -The MIT License (MIT) Copyright (c) 2017 Bertrand Martel \ No newline at end of file +The MIT License (MIT) + +Copyright (c) 2017 Bertrand Martel + +Copyright (c) 2025 sysmocom - s.f.m.c. GmbH -- To view, visit https://gerrit.osmocom.org/c/aram-applet/+/39584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: aram-applet Gerrit-Branch: master Gerrit-Change-Id: Ia27839881c0c739f58835ed883079b3ea60cb0e1 Gerrit-Change-Number: 39584 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[XS] Change in aram-applet[master]: gradlew: fix "Unrecognized option: --add-opens"

by dexter

Attention is currently required from: osmith. dexter has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/aram-applet/+/39583?usp=email ) Change subject: gradlew: fix "Unrecognized option: --add-opens" ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I noticed this, yes its indeed distracting. I am glad you found a solution. -- To view, visit https://gerrit.osmocom.org/c/aram-applet/+/39583?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: aram-applet Gerrit-Branch: master Gerrit-Change-Id: I788e44cfe20ba6a331e8247677ecb5a526c433f7 Gerrit-Change-Number: 39583 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Feb 2025 16:08:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months, 2 weeks

1
0
0 0

[XS] Change in aram-applet[master]: contrib/jenkins.sh: new script

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/aram-applet/+/39582?usp=email ) Change subject: contrib/jenkins.sh: new script ...................................................................... contrib/jenkins.sh: new script Add a CI script for https://jenkins.osmocom.org. Change-Id: If486aba5e455b2635714b91ccdc03b5153ee73d8 --- A contrib/jenkins.sh 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved dexter: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh new file mode 100755 index 0000000..cb67e3c --- /dev/null +++ b/contrib/jenkins.sh @@ -0,0 +1,7 @@ +#!/bin/sh -ex + +# Build and run tests +./gradlew build + +# Build "aram/build/javacard/applet.cap" +./gradlew buildJavaCard -- To view, visit https://gerrit.osmocom.org/c/aram-applet/+/39582?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: aram-applet Gerrit-Branch: master Gerrit-Change-Id: If486aba5e455b2635714b91ccdc03b5153ee73d8 Gerrit-Change-Number: 39582 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[S] Change in aram-applet[master]: README: update after setting up gerrit and jenkins

by osmith

Attention is currently required from: dexter, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/aram-applet/+/39584?usp=email ) Change subject: README: update after setting up gerrit and jenkins ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File README.md: https://gerrit.osmocom.org/c/aram-applet/+/39584/comment/b86fdca6_c461ae24?… : PS1, Line 165: > Maybe reformat this? […] Done -- To view, visit https://gerrit.osmocom.org/c/aram-applet/+/39584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: aram-applet Gerrit-Branch: master Gerrit-Change-Id: Ia27839881c0c739f58835ed883079b3ea60cb0e1 Gerrit-Change-Number: 39584 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Feb 2025 16:08:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[S] Change in aram-applet[master]: README: update after setting up gerrit and jenkins

by osmith

Attention is currently required from: dexter, osmith, pespin. Hello Jenkins Builder, dexter, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/aram-applet/+/39584?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Code-Review+2 by dexter, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: README: update after setting up gerrit and jenkins ...................................................................... README: update after setting up gerrit and jenkins Change-Id: Ia27839881c0c739f58835ed883079b3ea60cb0e1 --- M README.md 1 file changed, 24 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/aram-applet refs/changes/84/39584/2 -- To view, visit https://gerrit.osmocom.org/c/aram-applet/+/39584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: aram-applet Gerrit-Branch: master Gerrit-Change-Id: Ia27839881c0c739f58835ed883079b3ea60cb0e1 Gerrit-Change-Number: 39584 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[XS] Change in aram-applet[master]: contrib/jenkins.sh: new script

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/aram-applet/+/39582?usp=email ) Change subject: contrib/jenkins.sh: new script ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/aram-applet/+/39582/comment/191b29af_29345280?… : PS1, Line 7: ./gradlew buildJavaCard > ./gradlew build is not enough? For me it was working like this. setting JAVA_HOME is not needed here as openjdk is installed as debian package. -- To view, visit https://gerrit.osmocom.org/c/aram-applet/+/39582?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: aram-applet Gerrit-Branch: master Gerrit-Change-Id: If486aba5e455b2635714b91ccdc03b5153ee73d8 Gerrit-Change-Number: 39582 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Feb 2025 16:07:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[S] Change in upf-benchmark[master]: testsuites/gtplab-sysmo2025/tunmap: Improve function allocating TRX s...

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39575?usp=email ) Change subject: testsuites/gtplab-sysmo2025/tunmap: Improve function allocating TRX src IP addresses ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/upf-benchmark/+/39575/comment/e37c9462_b7e5820… : PS2, Line 8: > Yes, it's simply a proper implementaton of the function, the previous one was a quick one which was […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39575?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: Ie57b1933f37b3903b043ac36cbc570fecdf4e352 Gerrit-Change-Number: 39575 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Feb 2025 16:03:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[XS] Change in aram-applet[master]: contrib/jenkins.sh: new script

by dexter

Attention is currently required from: osmith. dexter has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/aram-applet/+/39582?usp=email ) Change subject: contrib/jenkins.sh: new script ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/aram-applet/+/39582/comment/becb9cf0_f49fbb80?… : PS1, Line 7: ./gradlew buildJavaCard ./gradlew build is not enough? For me it was working like this. -- To view, visit https://gerrit.osmocom.org/c/aram-applet/+/39582?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: aram-applet Gerrit-Branch: master Gerrit-Change-Id: If486aba5e455b2635714b91ccdc03b5153ee73d8 Gerrit-Change-Number: 39582 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Feb 2025 14:56:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months, 2 weeks

1
0
0 0

[XS] Change in osmo-upf[master]: up_peer: Increase up/cp seid hashtable sizes

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/39579?usp=email ) Change subject: up_peer: Increase up/cp seid hashtable sizes ...................................................................... up_peer: Increase up/cp seid hashtable sizes During a 200K session setup, this can still take quite a noticeable amount of time (20% of a full CPU) during session creation. Change-Id: I424778a4c75000fb67ba4725a6a3e3e91a80fc76 --- M include/osmocom/upf/up_peer.h 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/include/osmocom/upf/up_peer.h b/include/osmocom/upf/up_peer.h index be5dd52..559b87c 100644 --- a/include/osmocom/upf/up_peer.h +++ b/include/osmocom/upf/up_peer.h @@ -63,8 +63,8 @@ struct osmo_use_count use_count; struct osmo_use_count_entry use_count_buf[5]; - DECLARE_HASHTABLE(sessions_by_up_seid, 6); - DECLARE_HASHTABLE(sessions_by_cp_seid, 6); + DECLARE_HASHTABLE(sessions_by_up_seid, 10); + DECLARE_HASHTABLE(sessions_by_cp_seid, 10); }; struct up_peer *up_peer_find_or_add(struct up_endpoint *up_ep, const struct osmo_sockaddr *remote_addr); -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I424778a4c75000fb67ba4725a6a3e3e91a80fc76 Gerrit-Change-Number: 39579 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025