February 2025 - gerrit-log - lists.osmocom.org

[S] Change in dahdi-linux[master]: drivers/dahdi: fix MAX redefine

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email ) Change subject: drivers/dahdi: fix MAX redefine ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: failure against linux master is expected until last patch of this series -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: If048523ac2c69b1251fdee758a2cd3e14f8e617c Gerrit-Change-Number: 39591 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Feb 2025 12:12:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months, 2 weeks

1
0
0 0

[S] Change in dahdi-linux[master]: drivers/dahdi: fix MAX redefine

by osmith

Attention is currently required from: osmith. osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email ) Change subject: drivers/dahdi: fix MAX redefine ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: If048523ac2c69b1251fdee758a2cd3e14f8e617c Gerrit-Change-Number: 39591 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: jobs/master-builds-dahdi: add branch, mail params

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39595?usp=email ) Change subject: jobs/master-builds-dahdi: add branch, mail params ...................................................................... jobs/master-builds-dahdi: add branch, mail params Change-Id: I87727e730c5b0190dbf16469301c3f81aa8462e2 --- M jobs/master-builds-dahdi.yml 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/95/39595/1 diff --git a/jobs/master-builds-dahdi.yml b/jobs/master-builds-dahdi.yml index f72076f..d6e2bfd 100644 --- a/jobs/master-builds-dahdi.yml +++ b/jobs/master-builds-dahdi.yml @@ -36,6 +36,16 @@ <br/><br/> <b>Auto-generated using Jenkins Job Builder. DO NOT EDIT MANUALLY!</b> + parameters: + - string: + name: BRANCH + description: dahdi-linux.git branch + default: 'master' + - string: + name: EMAIL_NOTIFICATIONS + description: For failed build notifications, set to empty to disable + default: 'jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org' + scm: # Let jenkins clone the big linux repository and keep it between builds # (wipe-workspace is false). Clone dahdi-linux with code from gerrit in @@ -62,7 +72,8 @@ rm -rf dahdi-linux git clone \ --depth=1 \ - https://gerrit.osmocom.org/dahdi-linux + https://gerrit.osmocom.org/dahdi-linux \ + -b "$BRANCH" git -C dahdi-linux log --oneline docker run \ @@ -79,7 +90,7 @@ - 'GNU C Compiler 4 (gcc)' resolve-relative-paths: true - email: - recipients: 'jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org' + recipients: '$EMAIL_NOTIFICATIONS' send-to-individuals: true # vim: expandtab tabstop=2 shiftwidth=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39595?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I87727e730c5b0190dbf16469301c3f81aa8462e2 Gerrit-Change-Number: 39595 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[S] Change in dahdi-linux[master]: drivers/dahdi: fix MAX redefine

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email ) Change subject: drivers/dahdi: fix MAX redefine ...................................................................... drivers/dahdi: fix MAX redefine Fix for this error with current linux master: CC [M] oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_channel.o wctdm24xxp/base.c: In function 'wait_access': wctdm24xxp/base.c:1504: error: "MAX" redefined [-Werror] 1504 | #define MAX 10 /* attempts */ | In file included from /linux/include/linux/kernel.h:28, from wctdm24xxp/base.c:41: /linux/include/linux/minmax.h:330: note: this is the location of the previous definition 330 | #define MAX(a,b) __cmp(max,a,b) Change-Id: If048523ac2c69b1251fdee758a2cd3e14f8e617c --- M drivers/dahdi/wcaxx-base.c M drivers/dahdi/wctdm24xxp/base.c 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/91/39591/1 diff --git a/drivers/dahdi/wcaxx-base.c b/drivers/dahdi/wcaxx-base.c index d3d0777..a54188d 100644 --- a/drivers/dahdi/wcaxx-base.c +++ b/drivers/dahdi/wcaxx-base.c @@ -1050,16 +1050,16 @@ unsigned char data = 0; int count = 0; - #define MAX 10 /* attempts */ + #define MAX_ATTEMPTS 10 /* Wait for indirect access */ - while (count++ < MAX) { + while (count++ < MAX_ATTEMPTS) { data = wcaxx_getreg(wc, mod, I_STATUS); if (!data) return 0; } - if (count > (MAX-1)) { + if (count > (MAX_ATTEMPTS - 1)) { dev_notice(&wc->xb.pdev->dev, " ##### Loop error (%02x) #####\n", data); } diff --git a/drivers/dahdi/wctdm24xxp/base.c b/drivers/dahdi/wctdm24xxp/base.c index 9725d3c..5de4ae8 100644 --- a/drivers/dahdi/wctdm24xxp/base.c +++ b/drivers/dahdi/wctdm24xxp/base.c @@ -1501,16 +1501,16 @@ unsigned char data = 0; int count = 0; - #define MAX 10 /* attempts */ + #define MAX_ATTEMPTS 10 /* Wait for indirect access */ - while (count++ < MAX) { + while (count++ < MAX_ATTEMPTS) { data = wctdm_getreg(wc, mod, I_STATUS); if (!data) return 0; } - if (count > (MAX-1)) { + if (count > (MAX_ATTEMPTS - 1)) { dev_notice(&wc->vb.pdev->dev, " ##### Loop error (%02x) #####\n", data); } -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: If048523ac2c69b1251fdee758a2cd3e14f8e617c Gerrit-Change-Number: 39591 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[S] Change in dahdi-linux[master]: drivers/dahdi: fix always true cond

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email ) Change subject: drivers/dahdi: fix always true cond ...................................................................... drivers/dahdi: fix always true cond Remvoe these checks as they are not useful. For example, wc->xb gets allocated together with wc. With these removed, the code behaves the same as before. Fix for these warnings with current linux master: wcte43x-base.c: In function 't43x_init_one': wcte43x-base.c:3517:13: warning: the comparison will always evaluate as 'true' for the address of 'xb' will never be NULL [-Waddress] 3517 | if (&wc->xb) | ^ wcte43x-base.c:141:21: note: 'xb' declared here 141 | struct wcxb xb; | ^~ xpp/xbus-core.c: In function 'xbus_check_unique': xpp/xbus-core.c:116:13: warning: the comparison will always evaluate as 'true' for the address of 'label' will never be NULL [-Waddress] 116 | if (xbus->label && *(xbus->label)) { | ^~~~ etc. Change-Id: I33ee446a32de3bb8d9fe966a2989994bf4bbd806 --- M drivers/dahdi/dahdi-base.c M drivers/dahdi/dahdi_dynamic_ethmf.c M drivers/dahdi/wcte13xp-base.c M drivers/dahdi/wcte43x-base.c M drivers/dahdi/xpp/xbus-core.c 5 files changed, 7 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/93/39593/1 diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index 43948bd..0aa1de7 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -952,12 +952,8 @@ if (!s) return -ENODEV; - if (s->name) - seq_printf(sfile, "Span %d: %s ", s->spanno, s->name); - if (s->desc) - seq_printf(sfile, "\"%s\"", s->desc); - else - seq_printf(sfile, "\"\""); + seq_printf(sfile, "Span %d: %s ", s->spanno, s->name); + seq_printf(sfile, "\"%s\"", s->desc); if (dahdi_is_sync_master(s)) seq_printf(sfile, " (MASTER)"); @@ -993,9 +989,7 @@ for (x = 0; x < s->channels; x++) { struct dahdi_chan *chan = s->chans[x]; - if (chan->name) - seq_printf(sfile, "\t%4d %s ", chan->channo, - chan->name); + seq_printf(sfile, "\t%4d %s ", chan->channo, chan->name); if (chan->sig) { if (chan->sig == DAHDI_SIG_SLAVE) diff --git a/drivers/dahdi/dahdi_dynamic_ethmf.c b/drivers/dahdi/dahdi_dynamic_ethmf.c index f98280c..998d962 100644 --- a/drivers/dahdi/dahdi_dynamic_ethmf.c +++ b/drivers/dahdi/dahdi_dynamic_ethmf.c @@ -535,7 +535,7 @@ kfree(z->msgbuf); kfree(z); } else { - if (z && z->span && z->span->name) { + if (z && z->span) { printk(KERN_ERR "Cannot find interface for %s\n", z->span->name); } diff --git a/drivers/dahdi/wcte13xp-base.c b/drivers/dahdi/wcte13xp-base.c index cfbdd4a..8ceee67 100644 --- a/drivers/dahdi/wcte13xp-base.c +++ b/drivers/dahdi/wcte13xp-base.c @@ -2701,8 +2701,7 @@ return 0; fail_exit: - if (&wc->xb) - wcxb_release(&wc->xb); + wcxb_release(&wc->xb); free_wc(wc); return res; diff --git a/drivers/dahdi/wcte43x-base.c b/drivers/dahdi/wcte43x-base.c index d164a69..0c7fbaf 100644 --- a/drivers/dahdi/wcte43x-base.c +++ b/drivers/dahdi/wcte43x-base.c @@ -3514,8 +3514,7 @@ return 0; fail_exit: - if (&wc->xb) - wcxb_release(&wc->xb); + wcxb_release(&wc->xb); if (debug) dev_info(&wc->xb.pdev->dev, "***At fail_exit in init_one***\n"); diff --git a/drivers/dahdi/xpp/xbus-core.c b/drivers/dahdi/xpp/xbus-core.c index e08e2d6..8514d1e 100644 --- a/drivers/dahdi/xpp/xbus-core.c +++ b/drivers/dahdi/xpp/xbus-core.c @@ -113,7 +113,7 @@ { if (!xbus) return -ENOENT; - if (xbus->label && *(xbus->label)) { + if (xbus->label) { xbus_t *xbus_old; XBUS_DBG(DEVICES, xbus, "Checking LABEL='%s'\n", xbus->label); -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I33ee446a32de3bb8d9fe966a2989994bf4bbd806 Gerrit-Change-Number: 39593 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[XS] Change in dahdi-linux[master]: drivers/dahdi/wct4xxp: fix inline not at beginning

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39592?usp=email ) Change subject: drivers/dahdi/wct4xxp: fix inline not at beginning ...................................................................... drivers/dahdi/wct4xxp: fix inline not at beginning Fix for this error with current linux master: wct4xxp/base.c:1157:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration] 1157 | static void inline t4_hdlc_xmit_fifo(struct t4 *wc, unsigned int span, struct t4_span *ts) | ^~~~~~ Change-Id: Ic77d94271e7844ea2e06ccd001156d90f321367e --- M drivers/dahdi/wct4xxp/base.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/92/39592/1 diff --git a/drivers/dahdi/wct4xxp/base.c b/drivers/dahdi/wct4xxp/base.c index 9d5b9a9..c61c7a7 100644 --- a/drivers/dahdi/wct4xxp/base.c +++ b/drivers/dahdi/wct4xxp/base.c @@ -1154,7 +1154,7 @@ return 0; } -static void inline t4_hdlc_xmit_fifo(struct t4 *wc, unsigned int span, struct t4_span *ts) +static inline void t4_hdlc_xmit_fifo(struct t4 *wc, unsigned int span, struct t4_span *ts) { int res, i; unsigned int size = 32; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ic77d94271e7844ea2e06ccd001156d90f321367e Gerrit-Change-Number: 39592 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[XS] Change in dahdi-linux[master]: drivers/dahdi/Kbuild: fix 'No rule to make target'

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39594?usp=email ) Change subject: drivers/dahdi/Kbuild: fix 'No rule to make target' ...................................................................... drivers/dahdi/Kbuild: fix 'No rule to make target' Add a workaround for this error with current linux master: make[4]: *** No rule to make target 'vpmadt032_loader/vpmadt032_x86_64.o', needed by 'dahdi_vpmadt032_loader.o'. Stop. Change-Id: I653318e158caf133bf4c81cd04da0adec14ed0d8 --- M drivers/dahdi/Kbuild 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/94/39594/1 diff --git a/drivers/dahdi/Kbuild b/drivers/dahdi/Kbuild index c3ec58e..4d05f12 100644 --- a/drivers/dahdi/Kbuild +++ b/drivers/dahdi/Kbuild @@ -146,6 +146,12 @@ endif endif +# FIXME: This workaround should not be necessary, but for some reason the rule +# '$(obj)/%: $(src)/%_shipped' from linux.git scripts/Makefile.lib doesn't +# cover this anymore. +vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o: $(src)/vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o_shipped + $(call cmd,copy) + ############################################################################### # HPEC Support ############################################################################### -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I653318e158caf133bf4c81cd04da0adec14ed0d8 Gerrit-Change-Number: 39594 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 2 weeks

1
0
0 0

[M] Change in upf-benchmark[master]: testsuites/gtplab-sysmo2025/tunend: Initial eupf setup

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39590?usp=email ) Change subject: testsuites/gtplab-sysmo2025/tunend: Initial eupf setup ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: (adding +1 since my comments are just about cosmetics) -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: I82ebaa785c67fc7a28a0e71eac55fe31a21d13d5 Gerrit-Change-Number: 39590 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Feb 2025 10:07:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months, 2 weeks

1
0
0 0

[M] Change in upf-benchmark[master]: testsuites/gtplab-sysmo2025/tunend: Initial eupf setup

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39590?usp=email ) Change subject: testsuites/gtplab-sysmo2025/tunend: Initial eupf setup ...................................................................... Patch Set 1: (3 comments) File doc/manuals/chapters/eupf_setup.adoc: https://gerrit.osmocom.org/c/upf-benchmark/+/39590/comment/60d3391f_4dac0bd… : PS1, Line 7: #Install eupf dependencies: Looks like the # is not on purpose? https://gerrit.osmocom.org/c/upf-benchmark/+/39590/comment/efe65162_83f8862… : PS1, Line 9: sudo apt install wget git clang llvm gcc-multilib libbpf-dev using $ / # infront or not is inconsistent throughout this file File testsuites/gtplab-sysmo2025/tunend/upf/eupf/configure.sh: https://gerrit.osmocom.org/c/upf-benchmark/+/39590/comment/9fcd6302_d4fa400… : PS1, Line 39: sudo ip neigh del "$(printf "172.16.32.%02u" "$i")" lladdr ec:0d:9a:8a:27:52 nud permanent dev $IFACE_RAN || true; ; is not needed at the end of these lines (same below) -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: I82ebaa785c67fc7a28a0e71eac55fe31a21d13d5 Gerrit-Change-Number: 39590 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Feb 2025 10:07:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 2 weeks

1
0
0 0

[XS] Change in upf-benchmark[master]: osmo-upf-load-gen: Introduce hashtable to look up session by CP SEID

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39576?usp=email ) Change subject: osmo-upf-load-gen: Introduce hashtable to look up session by CP SEID ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: Icab511fa1c136c75403e7469f63d91004e75dab4 Gerrit-Change-Number: 39576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Feb 2025 10:02:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025