February 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: asp: Make sure asp->fi is set to NULL when freeing the object

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39633?usp=email ) Change subject: asp: Make sure asp->fi is set to NULL when freeing the object ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39633?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1e6a25f6db695a16bd05ae4ec481df6e14cf65b5 Gerrit-Change-Number: 39633 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Feb 2025 16:19:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: xua_rkm: Fix dynamic AS destroyed when multiple ASPs are associated

by pespin

Attention is currently required from: daniel, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39630?usp=email ) Change subject: xua_rkm: Fix dynamic AS destroyed when multiple ASPs are associated ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > Yes, I'm currently adding some tests to validate dynamic ASP/AS/RKM in osmo-stp. […] Test which can be used to get to the scenario submitted here: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39647 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39630?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I986044944282cea9a13ed59424f2220fee6fe567 Gerrit-Change-Number: 39630 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Feb 2025 16:18:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Introduce tests TC_dyn_(2)asp_as_rkm_permitted

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39647?usp=email ) Change subject: stp: Introduce tests TC_dyn_(2)asp_as_rkm_permitted ...................................................................... stp: Introduce tests TC_dyn_(2)asp_as_rkm_permitted These tests allows testing behavior of scenarios related to dynamic ASP/AS/RKM improved/fixed in libosmo-sigtran.git Change-Ids: I986044944282cea9a13ed59424f2220fee6fe567 I85948ab98623a8a53521eb2d2e84244011b39a93 I3dffa2e9c554f03c7c721b757ff33a89961665b5 Change-Id: Ic3116cbe63832003876ae19b31491275aebb41a9 --- M stp/STP_Tests_M3UA.ttcn M stp/expected-results.xml 2 files changed, 109 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/47/39647/1 diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 674097a..c3598d3 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -815,6 +815,109 @@ f_clear_m3ua(); } +/* RFC 4666 5.1.1.2 "Single ASP in Application Server ("1+0" Sparing), Dynamic Registration" */ +testcase TC_dyn_asp_as_rkm_permitted() runs on RAW_M3UA_CT { + /* Pick ports not configured in osmo-stp for any ASP: */ + var M3uaConfigs m3ua_configs := { + { + use_tcp := false, + remote_port := 2905, + local_port := 2222, + point_code := 22, + routing_ctx := 220 + } + }; + var OCT4 rctx0 := int2oct(m3ua_configs[0].routing_ctx, 4); + f_init_common(); + f_vty_config2(VTY, {"cs7 instance 0"}, "xua rkm routing-key-allocation dynamic-permitted"); + f_init_m3ua(m3ua_configs := m3ua_configs, m3ua_num_clients := 1, m3ua_num_servers := 0); + + /* ASPUP + ACK */ + f_M3UA_asp_up(0); + + /* REG REQ + RESP */ + f_M3UA_send(0, ts_M3UA_REG_REQ({ts_M3UA_rkey(id:='00000001'O, + dpc:=int2oct(m3ua_configs[0].point_code, 3), + tmt := c_M3UA_TMT_loadshare, + rctx := rctx0)})); + f_M3UA_exp(0, tr_M3UA_REG_RSP({tr_M3UA_reg_res(id:='00000001'O, status:=c_M3UA_REGSTS_SUCCESS, + rctx:=rctx0)})); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_INACTIVE, *)); + + /* ASPAC + ACK */ + f_M3UA_asp_act(0, c_M3UA_TMT_loadshare, rctx0); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, *)); + + f_vty_config2(VTY, {"cs7 instance 0"}, "xua rkm routing-key-allocation static-only"); + f_clear_m3ua(); +} + +/* RFC 4666 5.1.3 "Two ASPs in an Application Server ("1+1" Sparing, Loadsharing Case)" */ +testcase TC_dyn_2asp_as_rkm_permitted() runs on RAW_M3UA_CT { + /* Pick ports not configured in osmo-stp for any ASP: */ + var M3uaConfigs m3ua_configs := { + { + use_tcp := false, + remote_port := 2905, + local_port := 2222, + point_code := 22, + routing_ctx := 220 + }, { + use_tcp := false, + remote_port := 2905, + local_port := 2223, + point_code := 22, + routing_ctx := 220 + } + }; + var OCT4 rctx0 := int2oct(m3ua_configs[0].routing_ctx, 4); + var OCT4 rctx1 := int2oct(m3ua_configs[0].routing_ctx, 4); + f_init_common(); + f_vty_config2(VTY, {"cs7 instance 0"}, "xua rkm routing-key-allocation dynamic-permitted"); + f_init_m3ua(m3ua_configs := m3ua_configs, m3ua_num_clients := 2, m3ua_num_servers := 0); + + ///////// ASP 0 ///////////// + /* ASPUP + ACK */ + f_M3UA_asp_up(0); + + /* REG REQ + RESP */ + f_M3UA_send(0, ts_M3UA_REG_REQ({ts_M3UA_rkey(id:='00000001'O, + dpc:=int2oct(m3ua_configs[0].point_code, 3), + tmt := c_M3UA_TMT_loadshare, + rctx := rctx0)})); + f_M3UA_exp(0, tr_M3UA_REG_RSP({tr_M3UA_reg_res(id:='00000001'O, status:=c_M3UA_REGSTS_SUCCESS, + rctx:=rctx0)})); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_INACTIVE, *)); + + /* ASPAC + ACK */ + f_M3UA_asp_act(0, c_M3UA_TMT_loadshare, rctx0); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, *)); + + ///////// ASP 1 ///////////// + /* ASPUP + ACK */ + f_M3UA_asp_up(1); + + /* REG REQ + RESP */ + f_M3UA_send(1, ts_M3UA_REG_REQ({ts_M3UA_rkey(id:='00000001'O, + dpc:=int2oct(m3ua_configs[1].point_code, 3), + tmt := c_M3UA_TMT_loadshare, + rctx := rctx1)})); + f_M3UA_exp(1, tr_M3UA_REG_RSP({tr_M3UA_reg_res(id:='00000001'O, status:=c_M3UA_REGSTS_SUCCESS, + rctx:=rctx1)})); + /* See RFC4666 4.3.4.5: There's a NOTIFY sent to this ASP after + * ASPUP+ASPUP-ACK to let it know AS state. */ + f_M3UA_exp(1, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, *)); + + /* ASPAC + ACK */ + f_M3UA_asp_act(1, c_M3UA_TMT_loadshare, rctx1); + /* See RFC 4666 5.1.4: No NOTIFY is sent because there's no state change. + * f_M3UA_exp(1, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, *)); + */ + + f_vty_config2(VTY, {"cs7 instance 0"}, "xua rkm routing-key-allocation static-only"); + f_clear_m3ua(); +} + /*********************************************************************** * Test the STP in M3UA ASP role (we are SG) ***********************************************************************/ @@ -1333,6 +1436,10 @@ /* TODO: register/unregister multiple routing contexts in one message; including mixed success/failure situations */ + /* test dynamic ASP & AS with dynamic RKM */ + execute( TC_dyn_asp_as_rkm_permitted() ); + execute( TC_dyn_2asp_as_rkm_permitted() ); + /* Test STP as SCTP client + M3UA ASP role */ execute( TC_clnt_connect_asp_up() ); execute( TC_clnt_asp_act() ); diff --git a/stp/expected-results.xml b/stp/expected-results.xml index fdb4e44..bc9c861 100644 --- a/stp/expected-results.xml +++ b/stp/expected-results.xml @@ -22,6 +22,8 @@ <testcase classname='STP_Tests_M3UA' name='TC_rkm_unreg_invalid' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_rkm_unreg_registered' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_rkm_unreg_active' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_dyn_asp_as_rkm_permitted' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_dyn_2asp_as_rkm_permitted' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_clnt_connect_asp_up' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_clnt_asp_act' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_clnt_sg_to_asp' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39647?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic3116cbe63832003876ae19b31491275aebb41a9 Gerrit-Change-Number: 39647 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: stp: NOTIFY expectancy fixes

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646?usp=email ) Change subject: stp: NOTIFY expectancy fixes ...................................................................... stp: NOTIFY expectancy fixes Fix expected behavior of STP according to specs (RFC 4666 4.3.4.5), after osmo-stp got several related fixes in libosmo-sigtran.git Change-Id I85948ab98623a8a53521eb2d2e84244011b39a93 and Change-Id I3dffa2e9c554f03c7c721b757ff33a89961665b5. Change-Id: I3a56b4fcb8c119a31815f3175db2d7899fbfddd7 --- M stp/STP_Tests_M3UA.ttcn 1 file changed, 33 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/46/39646/1 diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 57aede4..674097a 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -564,8 +564,10 @@ /* verify traffic is routed from sender to [sole] receiver */ f_test_traffic(0, rctx_sender, pc_sender, 1, rctx_receiver, pc_receiver); - /* activate the second 'receiver' side ASP (no NOTIFY as AS state doesn't change) */ - f_M3UA_asp_up_act(2, c_M3UA_TMT_override, rctx_receiver, omit, omit); + /* activate the second 'receiver' side ASP: + * Expect NOTIFY always after ASPUP (RFC4666 4.3.4.5), don't expect + * NOTIFY after ACTIVE as AS state doesn't change) */ + f_M3UA_asp_up_act(2, c_M3UA_TMT_override, rctx_receiver, c_M3UA_ST_I_AS_ACTIVE, omit); /* we expect a NOTIFY to the *other* ASP Other/Alternat-ASP-Active */ f_M3UA_exp(1, tr_M3UA_NOTIFY(c_M3UA_ST_T_OTHER, c_M3UA_ST_I_ALTERNATE_ASP, *)); @@ -608,7 +610,7 @@ } /* activate the second 'receiver' side ASP (no NOTIFY) */ - f_M3UA_asp_up_act(2, c_M3UA_TMT_loadshare, omit, omit, omit); // TODO: rctx + f_M3UA_asp_up_act(2, c_M3UA_TMT_loadshare, omit, c_M3UA_ST_I_AS_ACTIVE, omit); // TODO: rctx /* verify traffic is routed from sender to new receiver */ const integer iter_per_asp := 5; @@ -665,7 +667,7 @@ } /* activate the second 'receiver' side ASP */ - f_M3UA_asp_up_act(2, c_M3UA_TMT_broadcast, omit, omit, omit); // TODO: rctx + f_M3UA_asp_up_act(2, c_M3UA_TMT_broadcast, omit, c_M3UA_ST_I_AS_ACTIVE, omit); // TODO: rctx /* verify traffic is routed from sender to new receiver */ for (i := 0; i < 10; i := i+1) { @@ -685,11 +687,16 @@ } private function f_M3UA_rkm_register(integer idx, OCT4 local_id, OCT3 dpc, OCT4 rctx, - template (present) OCT4 exp_status := c_M3UA_REGSTS_SUCCESS) + template (present) OCT4 exp_status := c_M3UA_REGSTS_SUCCESS, + template (omit) OCT2 ntfy_after_reg := c_M3UA_ST_I_AS_INACTIVE +) runs on RAW_M3UA_CT { f_M3UA_send(idx, ts_M3UA_REG_REQ({ts_M3UA_rkey(id:=local_id, dpc:=dpc, rctx:=rctx)})); f_M3UA_exp(idx, tr_M3UA_REG_RSP({tr_M3UA_reg_res(id:=local_id, status:=exp_status, rctx:=rctx)})); + if (not istemplatekind(ntfy_after_reg, "omit")) { + f_M3UA_exp(idx, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, ntfy_after_reg, *)); + } } /* Send RKM registration; expect -EPERM as RCTX doesn't match config and dynamic not permitted */ @@ -759,7 +766,7 @@ f_init_m3ua(); /* first register the routing key */ - f_M3UA_rkm_register(0, local_id:='30000099'O, dpc:=dpc, rctx:=rctx); + f_M3UA_rkm_register(0, local_id:='30000099'O, dpc:=dpc, rctx:=rctx, ntfy_after_reg := omit); /* then try to de-register */ f_M3UA_send(0, ts_M3UA_DEREG_REQ(ts_M3UA_routing_ctx(rctx))); @@ -771,31 +778,37 @@ /* try to de-register a routing key for an active ASP -> ERROR */ testcase TC_rkm_unreg_active() runs on RAW_M3UA_CT { - var OCT3 dpc := int2oct(123, 3); - var OCT4 rctx := int2oct(1234, 4); - f_init_common(); f_vty_config2(VTY, {"cs7 instance 0"}, "xua rkm routing-key-allocation dynamic-permitted"); f_init_m3ua(); - /* first register the routing key */ - f_M3UA_rkm_register(0, local_id:='30000099'O, dpc:=dpc, rctx:=rctx); + var OCT3 dpc := int2oct(123, 3); + var OCT4 rctxA := int2oct(1234, 4); + var OCT4 rctxB := int2oct(f_m3ua_cli_config(0).routing_ctx, 4); // must match config - /* then activate the ASP */ - f_M3UA_asp_up_act(0); - f_M3UA_exp(0, tr_M3UA_DAVA({*}, rctx)); - f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, *)); - f_M3UA_exp(0, tr_M3UA_DAVA({*}, *)); + /* first register the routing key */ + f_M3UA_rkm_register(0, local_id:='30000099'O, dpc:=dpc, rctx:=rctxA, ntfy_after_reg := omit); + + /* then activate the ASP, this turns the 2 AS (one for each rctx, 1234 and default 1023) + * INACTIVE, handle the 2 NOTIFY manually afterwards: */ + f_M3UA_asp_up(0, omit); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_INACTIVE, (rctxA, rctxB))); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_INACTIVE, (rctxA, rctxB))); + f_M3UA_asp_act(0, omit, rctxB); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, rctxB)); + f_M3UA_exp(0, tr_M3UA_DAVA({*}, rctxA)); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, rctxA)); + f_M3UA_exp(0, tr_M3UA_DAVA({*}, rctxB)); /* then try to de-register -> ERR_ASP_ACTIVE */ - f_M3UA_send(0, ts_M3UA_DEREG_REQ(ts_M3UA_routing_ctx(rctx))); + f_M3UA_send(0, ts_M3UA_DEREG_REQ(ts_M3UA_routing_ctx(rctxA))); f_M3UA_exp(0, tr_M3UA_DEREG_RSP({tr_M3UA_dereg_res(?,c_m3UA_DEREGSTS_ERR_ASP_ACTIVE)})); /* deactivate ASP and properly de-register to clean up */ f_M3UA_asp_inact(0); - f_M3UA_send(0, ts_M3UA_DEREG_REQ(ts_M3UA_routing_ctx(rctx))); - f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_PENDING, *)); - f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_PENDING, *)); + f_M3UA_send(0, ts_M3UA_DEREG_REQ(ts_M3UA_routing_ctx(rctxA))); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_PENDING, (rctxA, rctxB))); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_PENDING, (rctxA, rctxB))); f_M3UA_exp(0, tr_M3UA_DEREG_RSP({tr_M3UA_dereg_res(?,c_m3UA_DEREGSTS_SUCCESS)})); f_vty_config2(VTY, {"cs7 instance 0"}, "xua rkm routing-key-allocation static-only"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3a56b4fcb8c119a31815f3175db2d7899fbfddd7 Gerrit-Change-Number: 39646 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: TRAU encode: fix handling of OSMO_TRAU16_FT_IDLE

by falconia

falconia has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39643?usp=email ) Change subject: TRAU encode: fix handling of OSMO_TRAU16_FT_IDLE ...................................................................... TRAU encode: fix handling of OSMO_TRAU16_FT_IDLE GSM 08.60 sections 3.4 and 3.5.5 (renumbered to 5.4 and 5.5.5 in 3GPP TS 48.060) define a special frame type called Idle Speech Frame. It is not clear if any historical BSS vendor actually implemented these special frames - Nokia documentation explicitly mentions how they were deemed unnecessary and omitted from implementation - but libosmotrau includes support for this frame type. Looking at the referenced spec sections, we can see the designers' intent: the idle speech frame is just like FRv1 speech frames, but with different UL/DL frame type codes in C1..C5 and with all Dn bits replaced with constant-1 filler. Following this design intent on the part of GSM spec authors, the philophically correct behavior for osmo_trau_frame_encode() with regard to this frame type should be to handle it exactly the same as OSMO_TRAU16_FT_FR (support both DL and UL output, timing alignment in DL, possibility of changing C6..C21 and T-bits), but don't look at fr->d_bits[], fill constant 1s in their place instead. However, the behavior of the encoding function for this frame type prior to the present change was not like this at all: instead it would emit a constant (once and for all) frame of 320 bits that was always for DL no matter which direction was requested, would not allow time alignment, and would not allow any C-bits to be controlled by upper layers. At the present time there is no code anywhere in Osmocom that feeds OSMO_TRAU16_FT_IDLE to osmo_trau_frame_encode() - thus we don't have to maintain backward bug compatibility, and we can fix this design bug. Change-Id: Ibcc9e8628a56c6f089264c9d6b0dd27a1d5a7b60 --- M src/trau/trau_frame.c 1 file changed, 23 insertions(+), 44 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index fb98247..74f4526 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -522,52 +522,31 @@ return 0; } -static struct osmo_trau_frame fr_idle_frame = { - .type = OSMO_TRAU16_FT_IDLE, - .dir = OSMO_TRAU_DIR_DL, - .t_bits = { 1, 1, 1, 1 }, -}; -#define TRAU_FRAME_BITS (40*8) -static ubit_t encoded_idle_frame[TRAU_FRAME_BITS]; -static int dbits_initted = 0; - -/*! \brief return pointer to global buffer containing a TRAU idle frame */ -static ubit_t *trau_idle_frame(void) -{ - /* only initialize during the first call */ - if (!dbits_initted) { - /* set all D-bits to 1 */ - memset(&fr_idle_frame.d_bits, 0x01, 260); - - memset(&fr_idle_frame.c_bits, 0x01, 25); /* spare are set to 1 */ - /* set Downlink Idle Speech Frame pattern */ - fr_idle_frame.c_bits[0] = 0; /* C1 */ - fr_idle_frame.c_bits[1] = 1; /* C2 */ - fr_idle_frame.c_bits[2] = 1; /* C3 */ - fr_idle_frame.c_bits[3] = 1; /* C4 */ - fr_idle_frame.c_bits[4] = 0; /* C5 */ - /* set no Time Alignment pattern */ - fr_idle_frame.c_bits[5] = 0; /* C6 */ - fr_idle_frame.c_bits[6] = 0; /* C7 */ - fr_idle_frame.c_bits[7] = 0; /* C8 */ - fr_idle_frame.c_bits[8] = 0; /* C9 */ - fr_idle_frame.c_bits[9] = 0; /* C10 */ - fr_idle_frame.c_bits[10] = 0; /* C11 */ - /* already set to 1, but maybe we need to modify it in the future */ - fr_idle_frame.c_bits[11] = 1; /* C12 (UFE), good frame */ - fr_idle_frame.c_bits[15] = 1; /* C16 (SP), no DTX */ - - encode16_fr(encoded_idle_frame, &fr_idle_frame, false); - dbits_initted = 1; /* set it to 1 to not call it again */ - } - return encoded_idle_frame; -} - /* TS 08.60 Section 3.4 */ static int encode16_idle(ubit_t *trau_bits, const struct osmo_trau_frame *fr) { - memcpy(trau_bits, trau_idle_frame(), 40*8); - return 40 * 8; + const ubit_t *cbits5; + + if (fr->dir == OSMO_TRAU_DIR_UL) + cbits5 = ft_idle_up_bits; + else + cbits5 = ft_idle_down_bits; + + encode_sync16(trau_bits); + + /* C1 .. C5 */ + memcpy(trau_bits + 17, cbits5 + 0, 5); + /* C6 .. C15 */ + memcpy(trau_bits + 17 + 5, fr->c_bits + 5, 15 - 5); + /* all 1s in the place of D-bits */ + memset(trau_bits + 32, 1, 310 - 32); + /* C16 .. C21 */ + memcpy(trau_bits + 310, fr->c_bits + 15, 6); + /* T1 .. T4 */ + memcpy(trau_bits + 316, fr->t_bits, 4); + + /* handle timing adjustment */ + return encode16_handle_ta(trau_bits, fr); } /* TS 08.60 Section 3.3.1 */ @@ -1276,12 +1255,12 @@ case OSMO_TRAU16_FT_EFR: case OSMO_TRAU16_FT_HR: case OSMO_TRAU16_FT_AMR: + case OSMO_TRAU16_FT_IDLE: /* timing alignment may happen: increased space requirement */ if (n_bits < 2 * 40 * 8 - 1) return -ENOSPC; break; case OSMO_TRAU16_FT_OAM: - case OSMO_TRAU16_FT_IDLE: case OSMO_TRAU16_FT_DATA_HR: case OSMO_TRAU16_FT_DATA: case OSMO_TRAU16_FT_D145_SYNC: -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39643?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ibcc9e8628a56c6f089264c9d6b0dd27a1d5a7b60 Gerrit-Change-Number: 39643 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: rtp2trau HR: bring TRAU-16k support into alignment with TRAU-8k

by falconia

falconia has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39642?usp=email ) Change subject: rtp2trau HR: bring TRAU-16k support into alignment with TRAU-8k ...................................................................... rtp2trau HR: bring TRAU-16k support into alignment with TRAU-8k GSM 08.61 defines two TRAU frame formats for HRv1 codec, using either 16 kbit/s or 8 kbit/s submultiplexing. The 8k format is the one actually implemented in legacy E1 BTS hardware, and is also needed for global interoperability in TFO - whereas HR-16k TRAU frame format appears to be a paper-only spec that was never implemented in any hardware. Despite the lack of hardware implementations, support for TRAU-16k format for GSM-HR is already present in libosmotrau, originally implemented along with FR and EFR. Removing this support from Osmocom would look bad (there is always that off-chance that perhaps some BSS vendor did implement this format after all), hence let us do the next best thing: bring TRAU-16k support into alignment with the actually working TRAU-8k support for the same codec. Thanks to previous clean-up patches in this area, rtp2trau support for GSM-HR TRAU-DL output was already fully consistent between 16k and 8k formats, but TRAU-UL output code was wildly inconsistent. TRAU-8k-UL output code is new, takes TW-TS-002 input and can be used to implement TFO (primary intended use) or emulate an E1 BTS. However, previous TRAU-16k-UL output code dates back to the initial creation of TRAU<->RTP code in 2020, has never been updated until now, and is woefully inadequate for the task of emulating an E1 BTS. (Because TFO always uses 8k format for HRv1, software emulation of an E1 BTS is the only remaining plausible application for GSM-HR TRAU-16k-UL output.) With the present patch, the behavior of osmo_rtp2trau() for OSMO_TRAU16_FT_HR UL changes drastically: TS 101 318 input is no longer accepted, RFC 5993 input is still accepted but is not functionally complete, and the proper/expected input format becomes TW-TS-002, of which RFC 5993 is a subset. However, the detailed behavior of osmo_rtp2trau() for HRv1 codec is now exactly the same between 8k and 16k formats, in both DL and UL directions. Change-Id: I1c19592967e7c6becc710990f512da5dee5043d2 --- M src/trau/trau_rtp_conv.c 1 file changed, 128 insertions(+), 47 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index d5ac1fa..867a4e4 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -676,7 +676,7 @@ return 0; } -static int rtp2trau_hr16(struct osmo_trau_frame *tf, const uint8_t *data, size_t data_len) +static int rtp2trau_hr16_dl(struct osmo_trau_frame *tf, const uint8_t *data, size_t data_len) { /* accept both TS 101 318 and RFC 5993 payloads */ switch (data_len) { @@ -695,57 +695,26 @@ tf->type = OSMO_TRAU16_FT_HR; - if (tf->dir == OSMO_TRAU_DIR_UL) { - /* C1 .. C5 */ - tf->c_bits[0] = 0; - tf->c_bits[1] = 0; - tf->c_bits[2] = 0; - tf->c_bits[3] = 1; - tf->c_bits[4] = 1; - } else { - /* C1 .. C5 */ - tf->c_bits[0] = 1; - tf->c_bits[1] = 1; - tf->c_bits[2] = 1; - tf->c_bits[3] = 0; - tf->c_bits[4] = 1; - } + /* C1 .. C5 */ + tf->c_bits[0] = 1; + tf->c_bits[1] = 1; + tf->c_bits[2] = 1; + tf->c_bits[3] = 0; + tf->c_bits[4] = 1; /* C6.. C11: Time Alignment */ memset(tf->c_bits + 5, 0, 6); - if (tf->dir == OSMO_TRAU_DIR_UL) { - /* BFI */ - if (data_len == 0) - tf->c_bits[11] = 1; - else - tf->c_bits[11] = 0; - if (osmo_hr_check_sid(data, data_len)) { - /* SID=2 is a valid SID frame */ - tf->c_bits[12] = 1; - tf->c_bits[13] = 0; - } else { - tf->c_bits[12] = 0; - tf->c_bits[13] = 0; - } - /* FIXME: C15: TAF */ + tf->c_bits[11] = 1; /* C12: UFE */ + tf->c_bits[12] = 1; /* C13: spare */ + tf->c_bits[13] = 1; /* C14: spare */ + tf->c_bits[14] = 1; /* C15: spare */ + if (osmo_hr_check_sid(data, data_len)) tf->c_bits[15] = 0; /* C16: SP */ - tf->c_bits[16] = 0; /* C17: DTXd shall not be applied */ - } else { - tf->c_bits[11] = 1; /* C12: UFE */ - tf->c_bits[12] = 1; /* C13: spare */ - tf->c_bits[13] = 1; /* C14: spare */ - tf->c_bits[14] = 1; /* C15: spare */ - if (osmo_hr_check_sid(data, data_len)) - tf->c_bits[15] = 0; /* C16: SP */ - else - tf->c_bits[15] = 1; /* C16: SP */ - tf->c_bits[16] = 1; /* C17: spare */ - } + else + tf->c_bits[15] = 1; /* C16: SP */ + tf->c_bits[16] = 1; /* C17: spare */ memset(tf->c_bits+17, 1, 4); /* C18..C21: spare */ memset(&tf->t_bits[0], 1, 4); - if (tf->dir == OSMO_TRAU_DIR_UL) - tf->ufi = 0; - else - tf->ufi = 1; + tf->ufi = 1; /* spare bit in TRAU-DL */ if (data_len) osmo_pbit2ubit(tf->d_bits, data, GSM_HR_BYTES * 8); else @@ -756,6 +725,118 @@ return 0; } +static int rtp2trau_hr16_ul(struct osmo_trau_frame *tf, const uint8_t *data, size_t data_len) +{ + uint8_t ft; + enum osmo_gsm631_sid_class sidc; + bool data_bits_req, bfi; + + /* In TRAU-UL direction we require/expect TW-TS-002 RTP payload format; + * RFC 5993 is also accepted because it is a subset of TW-TS-002. + * TS 101 318 input is not supported for TRAU-UL output! */ + if (data_len < 1) + return -EINVAL; + ft = data[0] >> 4; + switch (ft) { + case FT_GOOD_SPEECH: + bfi = false; + sidc = OSMO_GSM631_SID_CLASS_SPEECH; + data_bits_req = true; + break; + case FT_INVALID_SID: + /* There are 3 possible BFI/SID combinations in TRAU-16k-UL + * format for GSM-HR that all collapse to the same + * "invalid SID" code in TRAU-8k-UL and TW-TS-002 formats. + * Here we arbitrarily choose BFI=1 SID=1: compared to the + * other two options, this one has the greatest Hamming + * distance (in C-bits) to good speech or valid SID codes. + */ + bfi = true; + sidc = OSMO_GSM631_SID_CLASS_INVALID; + data_bits_req = false; + break; + case FT_GOOD_SID: + bfi = false; + sidc = OSMO_GSM631_SID_CLASS_VALID; + data_bits_req = true; + break; + case FT_BFI_WITH_DATA: + bfi = true; + sidc = OSMO_GSM631_SID_CLASS_SPEECH; + data_bits_req = true; + break; + case FT_NO_DATA: + bfi = true; + sidc = OSMO_GSM631_SID_CLASS_SPEECH; + data_bits_req = false; + break; + default: + return -EINVAL; + } + /* If the frame type is one that includes data bits, the payload length + * per RFC 5993 and TW-TS-002 is 15 bytes. If the frame type is one + * that does not include data bits, then the payload length per the + * same specs is only 1 byte - but we also accept 15-byte payloads + * in this case to make life easier for applications that pass the + * content of a buffer. + * + * When we make a TRAU-UL frame from FT=1 or FT=7, we fill all Dn bits + * with zeros if we got a short (1 byte) payload. However, if the + * application passed us a long (15 byte) payload despite FT being + * 1 or 7, we fill Dn bits with application-provided payload. + */ + switch (data_len) { + case GSM_HR_BYTES_RTP_RFC5993: + break; + case 1: + if (data_bits_req) + return -EINVAL; + break; + default: + return -EINVAL; + } + + tf->type = OSMO_TRAU16_FT_HR; + + /* C1 .. C5 */ + tf->c_bits[0] = 0; + tf->c_bits[1] = 0; + tf->c_bits[2] = 0; + tf->c_bits[3] = 1; + tf->c_bits[4] = 1; + /* C6.. C11: Time Alignment */ + memset(tf->c_bits + 5, 0, 6); + tf->c_bits[11] = bfi; /* C12: BFI */ + tf->c_bits[12] = (sidc >> 1) & 1; /* C13: SID msb */ + tf->c_bits[13] = (sidc >> 0) & 1; /* C14: SID lsb */ + tf->c_bits[14] = data[0] & 0x01; /* C15: TAF */ + tf->c_bits[15] = 1; /* C16: spare */ + tf->c_bits[16] = (data[0] & 0x08) >> 3; /* C17: DTXd */ + memset(tf->c_bits+17, 1, 4); /* C18..C21: spare */ + memset(&tf->t_bits[0], 1, 4); + tf->ufi = (data[0] & 0x02) >> 1; + if (data_len > 1) + osmo_pbit2ubit(tf->d_bits, data + 1, GSM_HR_BYTES * 8); + else + memset(tf->d_bits, 0, GSM_HR_BYTES * 8); + /* CRC is *not* computed by TRAU frame encoder - we have to do it */ + osmo_crc8gen_set_bits(&gsm0860_efr_crc3, tf->d_bits, 44, tf->crc_bits); + + return 0; +} + +static int rtp2trau_hr16(struct osmo_trau_frame *tf, const uint8_t *data, size_t data_len) +{ + switch (tf->dir) { + case OSMO_TRAU_DIR_DL: + return rtp2trau_hr16_dl(tf, data, data_len); + case OSMO_TRAU_DIR_UL: + return rtp2trau_hr16_ul(tf, data, data_len); + default: + return -EINVAL; + } +} + static int rtp2trau_hr8_dl(struct osmo_trau_frame *tf, const uint8_t *data, size_t data_len) { /* accept both TS 101 318 and RFC 5993 payloads */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I1c19592967e7c6becc710990f512da5dee5043d2 Gerrit-Change-Number: 39642 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[M] Change in libosmo-sigtran[master]: Make sure to NOTIFY current state to peer after ASP UP ACK / REG RESP

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39640?usp=email ) Change subject: Make sure to NOTIFY current state to peer after ASP UP ACK / REG RESP ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39640?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3dffa2e9c554f03c7c721b757ff33a89961665b5 Gerrit-Change-Number: 39640 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 28 Feb 2025 16:07:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 month, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: Use fork of titan.ProtocolModules.M3UA containing fix

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39645?usp=email ) Change subject: Use fork of titan.ProtocolModules.M3UA containing fix ...................................................................... Use fork of titan.ProtocolModules.M3UA containing fix Use a fork of the repository until the M3UA_NOTIFY decoding bug gets its fix merged, currently submitted upstream in [1]. [1] https://gitlab.eclipse.org/eclipse/titan/titan.ProtocolModules.M3UA/-/merge… Change-Id: I9ac3dcad88cd13c1b45fb70bdcd2a474d084a652 --- M deps/Makefile 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/39645/1 diff --git a/deps/Makefile b/deps/Makefile index d57e37a..61daa48 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -34,7 +34,6 @@ titan.ProtocolModules.JSON_v07_2006 \ titan.ProtocolModules.L2TP \ titan.ProtocolModules.LLC_v7.1.0 \ - titan.ProtocolModules.M3UA \ titan.ProtocolModules.MobileL3_v13.4.0 \ titan.ProtocolModules.SMPP \ titan.ProtocolModules.TCP \ @@ -66,7 +65,8 @@ OSMOGITHUB_REPOS= titan.TestPorts.SCTPasp \ titan.TestPorts.MTP3asp \ titan.ProtocolEmulations.SCCP \ - titan.ProtocolModules.BSSGP_v13.0.0 + titan.ProtocolModules.BSSGP_v13.0.0 \ + titan.ProtocolModules.M3UA OSMOGERRIT_REPOS= osmo-uecups @@ -104,7 +104,7 @@ titan.ProtocolModules.LLC_v7.1.0_commit= 09817f113255d7fb56f1d45d3dd629a093d9248d titan.ProtocolModules.MAP_commit= R.2.A-1-g79c6a3d titan.ProtocolModules.M2PA_commit= R.2.A-5-ga75b589 -titan.ProtocolModules.M3UA_commit= c496d298876fed55c2b730278b7ee77982555563 +titan.ProtocolModules.M3UA_commit= 509fb5d3074d643024e691116d3df7ba42ef9587 titan.ProtocolModules.MobileL3_v13.4.0_commit= b6602eb357673f097ea1a1d22edd568ecd239da1 titan.ProtocolModules.NAS_EPS_15.2.0.1_commit= R.1.A-2-g2ba853c titan.ProtocolModules.NS_v7.3.0_commit= R.2.A-6-gf73f195 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ac3dcad88cd13c1b45fb70bdcd2a474d084a652 Gerrit-Change-Number: 39645 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Pass M3UA conn idx to f_M3UA_rkm_register()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39644?usp=email ) Change subject: stp: Pass M3UA conn idx to f_M3UA_rkm_register() ...................................................................... stp: Pass M3UA conn idx to f_M3UA_rkm_register() Change-Id: I9295a2c3518f82e8c82625fb573e414b1d634146 --- M stp/STP_Tests_M3UA.ttcn 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/39644/1 diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 195ce81..57aede4 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -684,12 +684,12 @@ f_clear_m3ua(); } -private function f_M3UA_rkm_register(OCT4 id, OCT3 dpc, OCT4 rctx, +private function f_M3UA_rkm_register(integer idx, OCT4 local_id, OCT3 dpc, OCT4 rctx, template (present) OCT4 exp_status := c_M3UA_REGSTS_SUCCESS) runs on RAW_M3UA_CT { - f_M3UA_send(0, ts_M3UA_REG_REQ({ts_M3UA_rkey(id:=id, dpc:=dpc, rctx:=rctx)})); - f_M3UA_exp(0, tr_M3UA_REG_RSP({tr_M3UA_reg_res(id:=id, status:=exp_status, rctx:=rctx)})); + f_M3UA_send(idx, ts_M3UA_REG_REQ({ts_M3UA_rkey(id:=local_id, dpc:=dpc, rctx:=rctx)})); + f_M3UA_exp(idx, tr_M3UA_REG_RSP({tr_M3UA_reg_res(id:=local_id, status:=exp_status, rctx:=rctx)})); } /* Send RKM registration; expect -EPERM as RCTX doesn't match config and dynamic not permitted */ @@ -759,7 +759,7 @@ f_init_m3ua(); /* first register the routing key */ - f_M3UA_rkm_register(id:='30000099'O, dpc:=dpc, rctx:=rctx); + f_M3UA_rkm_register(0, local_id:='30000099'O, dpc:=dpc, rctx:=rctx); /* then try to de-register */ f_M3UA_send(0, ts_M3UA_DEREG_REQ(ts_M3UA_routing_ctx(rctx))); @@ -779,7 +779,7 @@ f_init_m3ua(); /* first register the routing key */ - f_M3UA_rkm_register(id:='30000099'O, dpc:=dpc, rctx:=rctx); + f_M3UA_rkm_register(0, local_id:='30000099'O, dpc:=dpc, rctx:=rctx); /* then activate the ASP */ f_M3UA_asp_up_act(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9295a2c3518f82e8c82625fb573e414b1d634146 Gerrit-Change-Number: 39644 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[M] Change in libosmo-sigtran[master]: asp: Refactor osmo_ss7_asp_restart() into smaller chunks

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39634?usp=email ) Change subject: asp: Refactor osmo_ss7_asp_restart() into smaller chunks ...................................................................... Patch Set 1: (1 comment) File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39634/comment/06297305_d2942… : PS1, Line 689: /* First tear down previous state if existing: */ > Now, I did it on purpose, I think it helps in both contexts. Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39634?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5c3461b724924f528b46f7fe815f017a5b4a1ff5 Gerrit-Change-Number: 39634 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Feb 2025 12:34:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2025