January 2025 - gerrit-log - lists.osmocom.org

[L] Change in osmo-pcap[master]: client: Introduce osmo_pcap_file to prepare support for pcapng

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39288?usp=email ) Change subject: client: Introduce osmo_pcap_file to prepare support for pcapng ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ifd389a2a32897e101c62fd280ddca984d485d373 Gerrit-Change-Number: 39288 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Jan 2025 19:09:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in osmo-msc[master]: vlr: on subscriber disconnect, check if LU & Auth FSM are even valid

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, daniel, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/38487?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: vlr: on subscriber disconnect, check if LU & Auth FSM are even valid ...................................................................... vlr: on subscriber disconnect, check if LU & Auth FSM are even valid Those fsm can be NULL. Change-Id: Iaea7d37cfa439fd1adea7440409f6248aef947ef --- M src/libvlr/vlr.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/87/38487/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38487?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaea7d37cfa439fd1adea7440409f6248aef947ef Gerrit-Change-Number: 38487 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

5 months, 1 week

1
0
0 0

[M] Change in osmo-msc[master]: vlr: Add support for CS and PS timers

by lynxis lazus

Attention is currently required from: daniel, lynxis lazus, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: vlr: Add support for CS and PS timers ...................................................................... vlr: Add support for CS and PS timers To prepare for PS support, add related PS timers and try to keep the code simple to support both domains. Use osmo_tdef_fsm_inst_state_chg() where possible because this way we can have a t_def pointer which we set at the start. Change-Id: I364973b8d9e277ec5963343c0a83061e81a5baba --- M include/osmocom/vlr/vlr.h M src/libmsc/msc_vty.c M src/libvlr/vlr.c M src/libvlr/vlr_access_req_fsm.c M src/libvlr/vlr_access_req_fsm.h M src/libvlr/vlr_auth_fsm.c M src/libvlr/vlr_auth_fsm.h M src/libvlr/vlr_lu_fsm.c M src/libvlr/vlr_lu_fsm.h M tests/msc_vlr/msc_vlr_test_no_authen.c 10 files changed, 131 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/86/38486/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I364973b8d9e277ec5963343c0a83061e81a5baba Gerrit-Change-Number: 38486 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

5 months, 1 week

1
0
0 0

[M] Change in osmo-msc[master]: vlr: add PS support

by lynxis lazus

Attention is currently required from: laforge, lynxis lazus. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: vlr: add PS support ...................................................................... vlr: add PS support Add vlr_ra_update() similar to vlr_lu_update(). Implement resending of GMM PDUs. While CS has a reliable connection between the MS and MSC, the MS and SGSN doesn't have such connection. The PDU is resend N times before the LU fsm is failing. Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 --- M src/libvlr/vlr.c M src/libvlr/vlr_lu_fsm.c 2 files changed, 214 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/90/38490/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

5 months, 1 week

1
0
0 0

[L] Change in osmo-msc[master]: fix tests

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/39306?usp=email ) Change subject: fix tests ...................................................................... fix tests Change-Id: I727253cc5a13c73464c632533beea0d841d67544 --- M tests/msc_vlr/msc_vlr_test_authen_reuse.err M tests/msc_vlr/msc_vlr_test_call.err M tests/msc_vlr/msc_vlr_test_gsm_authen.err A tests/msc_vlr/msc_vlr_test_gsm_authen.err.err M tests/msc_vlr/msc_vlr_test_gsm_ciph.err M tests/msc_vlr/msc_vlr_test_hlr_reject.err M tests/msc_vlr/msc_vlr_test_hlr_timeout.err M tests/msc_vlr/msc_vlr_test_ms_timeout.err M tests/msc_vlr/msc_vlr_test_no_authen.err M tests/msc_vlr/msc_vlr_test_reject_concurrency.err M tests/msc_vlr/msc_vlr_test_rest.err M tests/msc_vlr/msc_vlr_test_ss.err M tests/msc_vlr/msc_vlr_test_umts_authen.err 13 files changed, 363 insertions(+), 362 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/06/39306/1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39306?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I727253cc5a13c73464c632533beea0d841d67544 Gerrit-Change-Number: 39306 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

5 months, 1 week

1
0
0 0

[S] Change in osmo-pcap[master]: server: Avoid lseek syscall on every packet write to pcap file

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39303?usp=email ) Change subject: server: Avoid lseek syscall on every packet write to pcap file ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I437eaca982d65d0f06e7d24863875f85267f0e44 Gerrit-Change-Number: 39303 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Jan 2025 19:09:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[M] Change in osmo-pcap[master]: server: Move osmo_pcap_server_alloc() to osmo_server_core.c

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39305?usp=email ) Change subject: server: Move osmo_pcap_server_alloc() to osmo_server_core.c ...................................................................... server: Move osmo_pcap_server_alloc() to osmo_server_core.c Change-Id: I5456e66820cec5bd5acf3cb732b47c42dae7a21e --- M include/osmo-pcap/osmo_pcap_server.h M src/osmo_server_core.c M src/osmo_server_main.c 3 files changed, 32 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/05/39305/1 diff --git a/include/osmo-pcap/osmo_pcap_server.h b/include/osmo-pcap/osmo_pcap_server.h index 5d21c64..8bd1dee 100644 --- a/include/osmo-pcap/osmo_pcap_server.h +++ b/include/osmo-pcap/osmo_pcap_server.h @@ -116,6 +116,15 @@ struct osmo_tls_session tls_session; }; +void osmo_pcap_conn_free(struct osmo_pcap_conn *conn); +void vty_server_init(void); +void osmo_pcap_conn_close(struct osmo_pcap_conn *conn); +int osmo_pcap_conn_process_data(struct osmo_pcap_conn *conn, const uint8_t *data, size_t len); +void osmo_pcap_conn_restart_trace(struct osmo_pcap_conn *conn); +void osmo_pcap_conn_close_trace(struct osmo_pcap_conn *conn); +void osmo_pcap_conn_event(struct osmo_pcap_conn *conn, + const char *event, const char *data); + struct osmo_pcap_server { struct llist_head conn; @@ -163,16 +172,9 @@ extern struct osmo_pcap_server *pcap_server; extern const struct rate_ctr_group_desc pcap_peer_group_desc; extern const struct rate_ctr_group_desc pcap_server_group_desc; +struct osmo_pcap_server *osmo_pcap_server_alloc(void *ctx); void osmo_pcap_server_reopen(struct osmo_pcap_server *server); int osmo_pcap_server_listen(struct osmo_pcap_server *server); struct osmo_pcap_conn *osmo_pcap_server_find_or_create(struct osmo_pcap_server *ser, const char *name); -void osmo_pcap_conn_free(struct osmo_pcap_conn *conn); -void vty_server_init(void); -void osmo_pcap_conn_close(struct osmo_pcap_conn *conn); -int osmo_pcap_conn_process_data(struct osmo_pcap_conn *conn, const uint8_t *data, size_t len); -void osmo_pcap_conn_restart_trace(struct osmo_pcap_conn *conn); -void osmo_pcap_conn_close_trace(struct osmo_pcap_conn *conn); -void osmo_pcap_conn_event(struct osmo_pcap_conn *conn, - const char *event, const char *data); diff --git a/src/osmo_server_core.c b/src/osmo_server_core.c index cc834a2..56f4ac1 100644 --- a/src/osmo_server_core.c +++ b/src/osmo_server_core.c @@ -579,3 +579,25 @@ update_last_write(conn, now, rc); return 0; } + +struct osmo_pcap_server *osmo_pcap_server_alloc(void *ctx) +{ + struct osmo_pcap_server *psrv = talloc_zero(ctx, struct osmo_pcap_server); + OSMO_ASSERT(psrv); + + psrv->ctrg = rate_ctr_group_alloc(psrv, &pcap_server_group_desc, 0); + OSMO_ASSERT(psrv->ctrg); + + INIT_LLIST_HEAD(&psrv->conn); + psrv->base_path = talloc_strdup(psrv, "./"); + OSMO_ASSERT(psrv->base_path); + psrv->permission_mask = 0440; + psrv->max_size = 1073741824; /* 1024^3, 1GB **/ + psrv->max_size_enabled = true; + psrv->max_snaplen = DEFAULT_SNAPLEN; + /* By default rotate daily: */ + psrv->rotate_localtime.enabled = true; + psrv->rotate_localtime.intv = TIME_INTERVAL_DAY; + psrv->rotate_localtime.modulus = 1; + return psrv; +} diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c index 74d2727..49ee449 100644 --- a/src/osmo_server_main.c +++ b/src/osmo_server_main.c @@ -204,28 +204,6 @@ msgb_talloc_ctx_init(tall_srv_ctx, 0); } -static struct osmo_pcap_server *osmo_pcap_server_alloc(void *ctx) -{ - struct osmo_pcap_server *psrv = talloc_zero(ctx, struct osmo_pcap_server); - OSMO_ASSERT(psrv); - - psrv->ctrg = rate_ctr_group_alloc(psrv, &pcap_server_group_desc, 0); - OSMO_ASSERT(psrv->ctrg); - - INIT_LLIST_HEAD(&psrv->conn); - psrv->base_path = talloc_strdup(psrv, "./"); - OSMO_ASSERT(psrv->base_path); - psrv->permission_mask = 0440; - psrv->max_size = 1073741824; /* 1024^3, 1GB **/ - psrv->max_size_enabled = true; - psrv->max_snaplen = DEFAULT_SNAPLEN; - /* By default rotate daily: */ - psrv->rotate_localtime.enabled = true; - psrv->rotate_localtime.intv = TIME_INTERVAL_DAY; - psrv->rotate_localtime.modulus = 1; - return psrv; -} - int main(int argc, char **argv) { int rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39305?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I5456e66820cec5bd5acf3cb732b47c42dae7a21e Gerrit-Change-Number: 39305 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: introduce hopping control for Nokia *Site

by csaba.sipos

Attention is currently required from: fixeria, laforge, pespin. csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email ) Change subject: nokia_site: introduce hopping control for Nokia *Site ...................................................................... Patch Set 8: (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/0653e85e_47556b05?usp… : PS6, Line 470: nokia_hopping > Unless that 0|1 numbering is a well know thing from nokia, I'd also favour to have proper string lit […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06 Gerrit-Change-Number: 39290 Gerrit-PatchSet: 8 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Jan 2025 19:06:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: csaba.sipos <metro4(a)freemail.hu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: introduce hopping control for Nokia *Site

by csaba.sipos

Attention is currently required from: csaba.sipos, fixeria, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: nokia_site: introduce hopping control for Nokia *Site ...................................................................... nokia_site: introduce hopping control for Nokia *Site nokia_site hopping-mode baseband nokia_site hopping-mode synthesizer Signed-off-by: csaba.sipos <metro4(a)freemail.hu> Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06 --- A doc/examples/osmo-bsc/nokia/osmo-bsc.metrosite.RF-hopping.2TRX.cfg M include/osmocom/bsc/bts.h M src/osmo-bsc/bts_nokia_site.c M src/osmo-bsc/bts_vty.c 4 files changed, 212 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/90/39290/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06 Gerrit-Change-Number: 39290 Gerrit-PatchSet: 8 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in osmo-pcap[master]: cosmetic: osmo_tls: Fix indentation whitespace

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39304?usp=email ) Change subject: cosmetic: osmo_tls: Fix indentation whitespace ...................................................................... cosmetic: osmo_tls: Fix indentation whitespace Change-Id: I27e6d6ce64178384acbd0b8ee88d6f7ef6b2a61b --- M src/osmo_tls.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/04/39304/1 diff --git a/src/osmo_tls.c b/src/osmo_tls.c index f1f08ca..8524ee3 100644 --- a/src/osmo_tls.c +++ b/src/osmo_tls.c @@ -170,7 +170,7 @@ int rc; rc = gnutls_global_init(); CHECK_RC(rc, "init failed"); - gnutls_global_set_log_function(tls_log_func); + gnutls_global_set_log_function(tls_log_func); } void osmo_tls_server_init(struct osmo_pcap_server *server) @@ -483,7 +483,7 @@ sess->anon_alloc = true; /* x509 certificate handling */ - rc = gnutls_certificate_allocate_credentials(&sess->cert_cred); + rc = gnutls_certificate_allocate_credentials(&sess->cert_cred); if (rc != GNUTLS_E_SUCCESS) { LOGP(DTLS, LOGL_ERROR, "Failed to allocate x509 cred rc=%d\n", rc); osmo_tls_release(sess); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I27e6d6ce64178384acbd0b8ee88d6f7ef6b2a61b Gerrit-Change-Number: 39304 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025