September 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: jobs/osmo-gsm-tester_gerrit: disable

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38190?usp=email ) Change subject: jobs/osmo-gsm-tester_gerrit: disable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf5dd17ca24e9589ef9175de42b5102c79285a7d Gerrit-Change-Number: 38190 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Sep 2024 15:14:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/osmo-gsm-tester-runner: include-raw -> include-raw-expand

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38189?usp=email ) Change subject: jobs/osmo-gsm-tester-runner: include-raw -> include-raw-expand ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ieceeb87fea88fb5f9591153d424cd25569763a31 Gerrit-Change-Number: 38189 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Sep 2024 15:14:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/osmo-gsm-tester-runner: fix syntax errors

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38188?usp=email ) Change subject: jobs/osmo-gsm-tester-runner: fix syntax errors ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5401d75ac40b8267b59443792079249f00b02111 Gerrit-Change-Number: 38188 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Sep 2024 15:14:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/osmo-gsm-tester_gerrit: disable

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38190?usp=email ) Change subject: jobs/osmo-gsm-tester_gerrit: disable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf5dd17ca24e9589ef9175de42b5102c79285a7d Gerrit-Change-Number: 38190 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Sep 2024 14:25:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/osmo-gsm-tester-runner: include-raw -> include-raw-expand

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38189?usp=email ) Change subject: jobs/osmo-gsm-tester-runner: include-raw -> include-raw-expand ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ieceeb87fea88fb5f9591153d424cd25569763a31 Gerrit-Change-Number: 38189 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Sep 2024 14:25:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/osmo-gsm-tester-runner: fix syntax errors

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38188?usp=email ) Change subject: jobs/osmo-gsm-tester-runner: fix syntax errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5401d75ac40b8267b59443792079249f00b02111 Gerrit-Change-Number: 38188 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Sep 2024 14:25:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/osmo-gsm-tester-runner: include-raw -> include-raw-expand

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38189?usp=email ) Change subject: jobs/osmo-gsm-tester-runner: include-raw -> include-raw-expand ...................................................................... jobs/osmo-gsm-tester-runner: include-raw -> include-raw-expand Fix for: UserWarning: Tag '!include-raw:' is deprecated, switch to using '!include-raw-expand:' Change-Id: Ieceeb87fea88fb5f9591153d424cd25569763a31 --- M jobs/osmo-gsm-tester-runner.yml 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/89/38189/1 diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index 259436c..b45d537 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -137,7 +137,7 @@ - osmo-gsm-tester_build-srslte builders: - copy_artifact_all - - shell: !include-raw: osmo-gsm-tester_run-{stage}.sh + - shell: !include-raw-expand: osmo-gsm-tester_run-{stage}.sh publishers: - archive: artifacts: '*-run.tgz, *-bin.tgz' @@ -175,7 +175,7 @@ # make sure no test results/bin artifacts from a previous run remain rm -rf trial-* *.tgz *.md5 - copy_artifact_all - - shell: !include-raw: osmo-gsm-tester_run-gerrit.sh + - shell: !include-raw-expand: osmo-gsm-tester_run-gerrit.sh publishers: - archive: artifacts: '*-run.tgz, *-bin.tgz' @@ -200,7 +200,7 @@ - copy_artifact_all - copy_artifact: repo: osmo-gsm-tester_build-osmocom-bb - - shell: !include-raw: osmo-gsm-tester_ttcn3.sh + - shell: !include-raw-expand: osmo-gsm-tester_ttcn3.sh publishers: - archive: artifacts: '*-run.tgz, *-bin.tgz' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ieceeb87fea88fb5f9591153d424cd25569763a31 Gerrit-Change-Number: 38189 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

11 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/osmo-gsm-tester-runner: fix syntax errors

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38188?usp=email ) Change subject: jobs/osmo-gsm-tester-runner: fix syntax errors ...................................................................... jobs/osmo-gsm-tester-runner: fix syntax errors Fix the syntax of this file, so it is compatible with Jenkins Job Builder 6.3.0. * In shell blocks, {{ and }} needs to be used instead of { and } if the string in brackets does not refer to a JJB variable. * "${OSMO_GSM_TESTER_BRANCH}" would refer to a non-existing JJB var, instead we want the shell variable here (that jenkins sets), so omit the {}. Change-Id: I5401d75ac40b8267b59443792079249f00b02111 --- M jobs/osmo-gsm-tester-runner.yml 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/88/38188/1 diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index 4909fe7..259436c 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -34,7 +34,7 @@ - git: url: https://gerrit.osmocom.org/osmo-gsm-tester branches: - - ${OSMO_GSM_TESTER_BRANCH} + - '$OSMO_GSM_TESTER_BRANCH' wipe-workspace: false skip-tag: true basedir: osmo-gsm-tester @@ -227,14 +227,14 @@ repo: osmo-gsm-tester_build-osmocom-bb - shell: | # Set a trap to fix workspace permissions / kill the docker container on exit - clean_up() { + clean_up() {{ docker kill "osmo-gsm-tester-virtual" || true docker run --rm \ -v "$WORKSPACE":/workspace \ debian:bullseye \ chmod -R a+rwX /workspace/ - } - clean_up_trap() { + }} + clean_up_trap() {{ set +x echo echo "### Clean up ###" @@ -243,7 +243,7 @@ trap - EXIT INT TERM 0 clean_up - } + }} trap clean_up_trap EXIT INT TERM 0 # Make sure no test results from a previous run remain @@ -281,7 +281,7 @@ --name=osmo-gsm-tester-virtual \ --cap-add=sys_nice \ $USER/osmo-gsm-tester \ - /bin/bash -c 'LANG="en_US.utf8" LC_ALL="en_US.UTF-8" LC_LANG="en_US.UTF-8" PATH="$PWD/osmo-gsm-tester/src:${PATH}" ./osmo-gsm-tester/contrib/jenkins-run.sh' + /bin/bash -c 'LANG="en_US.utf8" LC_ALL="en_US.UTF-8" LC_LANG="en_US.UTF-8" PATH="$PWD/osmo-gsm-tester/src:${{PATH}}" ./osmo-gsm-tester/contrib/jenkins-run.sh' publishers: - archive: artifacts: '*-run.tgz, *-bin.tgz' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5401d75ac40b8267b59443792079249f00b02111 Gerrit-Change-Number: 38188 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

11 months

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/osmo-gsm-tester_gerrit: disable

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38190?usp=email ) Change subject: jobs/osmo-gsm-tester_gerrit: disable ...................................................................... jobs/osmo-gsm-tester_gerrit: disable Disable it, as currently the osmo-gsm-tester jenkins nodes are offline and starting such a job just leads to a job that is stuck in the jenkins queue. Change-Id: Idf5dd17ca24e9589ef9175de42b5102c79285a7d --- M jobs/osmo-gsm-tester-runner.yml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/90/38190/1 diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index b45d537..5bc7140 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -154,6 +154,7 @@ # gerrit job - job: name: 'osmo-gsm-tester_gerrit' + disabled: true # osmo-gsm-tester nodes are currently offline defaults: runner scm: - 'osmo-gsm-tester-gerrit' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf5dd17ca24e9589ef9175de42b5102c79285a7d Gerrit-Change-Number: 38190 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

11 months

1
0
0 0

[XS] Change in ...pyosmocom[master]: osmocom.construct: Don't forget context when calling sizeof in Rpad

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38186?usp=email ) Change subject: osmocom.construct: Don't forget context when calling sizeof in Rpad ...................................................................... osmocom.construct: Don't forget context when calling sizeof in Rpad When calling the self.sizeof() method, we must pass in the context in order to make expressions like 'this._.total_len' work. Change-Id: I97e4b8fffcccba0b9d0ecb18c76a2a30fd990fd2 --- M src/osmocom/construct.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: dexter: Looks good to me, approved; Verified Jenkins Builder: Verified diff --git a/src/osmocom/construct.py b/src/osmocom/construct.py index 753b5de..8f01f3c 100644 --- a/src/osmocom/construct.py +++ b/src/osmocom/construct.py @@ -341,7 +341,7 @@ return obj.rstrip(self.pattern) def _encode(self, obj, context, path): - target_size = self.sizeof() * self.num_per_byte + target_size = self.sizeof(**context) * self.num_per_byte if len(obj) > target_size: raise SizeofError("Input ({}) exceeds target size ({})".format( len(obj), target_size)) -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I97e4b8fffcccba0b9d0ecb18c76a2a30fd990fd2 Gerrit-Change-Number: 38186 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024