September 2024 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: requirements: require at least construct version 2.10.70

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38198?usp=email ) Change subject: requirements: require at least construct version 2.10.70 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If59dc708a7194649d1f42c4cf33f6328edcb80d2 Gerrit-Change-Number: 38198 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Sep 2024 16:43:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months

1
0
0 0

[S] Change in pysim[master]: pySim-shell: improve command "desc"

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38194?usp=email ) Change subject: pySim-shell: improve command "desc" ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I98e139ba2bf35df5524245cdd96f5c52cf09b986 Gerrit-Change-Number: 38194 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Sep 2024 16:42:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months

1
0
0 0

[XS] Change in pysim[master]: ts_102_221: se _test_de_encode instead of _test_decode in EF.DIR unit...

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38201?usp=email ) Change subject: ts_102_221: se _test_de_encode instead of _test_decode in EF.DIR unittest ...................................................................... ts_102_221: se _test_de_encode instead of _test_decode in EF.DIR unittest The unittest for EF.DIR only runs with _test_decode, but it also runs with _test_de_encode without any problems Related: OS#5714 Change-Id: If459073c6ff927c1cc1790d506e3979243b1fb4c --- M pySim/ts_102_221.py 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/01/38201/1 diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index f09b1e3..35fed28 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -637,8 +637,7 @@ # TS 102 221 Section 13.1 class EF_DIR(LinFixedEF): - # FIXME: re-encode failure when changing to _test_de_encode - _test_decode = [ + _test_de_encode = [ ( '61294f10a0000000871002ffffffff890709000050055553696d31730ea00c80011781025f608203454150', { "application_template": [ { "application_id": h2b("a0000000871002ffffffff8907090000") }, { "application_label": "USim1" }, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38201?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If459073c6ff927c1cc1790d506e3979243b1fb4c Gerrit-Change-Number: 38201 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

11 months

1
0
0 0

[XS] Change in pysim[master]: ts_51_011: fix unittest for EF.ADN

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38199?usp=email ) Change subject: ts_51_011: fix unittest for EF.ADN ...................................................................... ts_51_011: fix unittest for EF.ADN The unittest for EF.ADN can run with _test_de_encode. However, the original test vectors seem to be from a card with a slightly larger record size, so they need a bit of re-alignment Related: OS#5714 Change-Id: I241792e66ee6167be6ddc076453344b6307d6265 --- M pySim/ts_51_011.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/99/38199/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 65195fd..69e20e4 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -131,13 +131,13 @@ # TS 51.011 Section 10.5.1 class EF_ADN(LinFixedEF): - _test_decode = [ - ( '42204841203120536963ffffffff06810628560810ffffffffffffff', + _test_de_encode = [ + ( '42204841203120536963FFFFFFFFFFFF06810628560810FFFFFFFFFFFFFF', { "alpha_id": "B HA 1 Sic", "len_of_bcd": 6, "ton_npi": { "ext": True, "type_of_number": "unknown", "numbering_plan_id": "isdn_e164" }, "dialing_nr": "6082658001", "cap_conf_id": 255, "ext1_record_id": 255 }), - ( '4B756E64656E626574726575756E67FFFFFF0791947112122721ffffffffffff', + ( '4B756E64656E626574726575756E67FF0791947112122721ffffffffffff', {"alpha_id": "Kundenbetreuung", "len_of_bcd": 7, "ton_npi": {"ext": True, "type_of_number": "international", "numbering_plan_id": "isdn_e164"}, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I241792e66ee6167be6ddc076453344b6307d6265 Gerrit-Change-Number: 38199 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

11 months

1
0
0 0

[XS] Change in pysim[master]: ts_51_011: use _test_de_encode instead of _test_decode in EF.CFIS uni...

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38200?usp=email ) Change subject: ts_51_011: use _test_de_encode instead of _test_decode in EF.CFIS unittest ...................................................................... ts_51_011: use _test_de_encode instead of _test_decode in EF.CFIS unittest The unittest for EF.CFIS only runs with _test_decode, but it also runs with _test_de_encode without any problems Related: OS#5714 Change-Id: Ib876fd799f871fe64ced2a7b64847ffd09e16ed9 --- M pySim/ts_51_011.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/00/38200/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 69e20e4..2dac55e 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -812,7 +812,7 @@ # TS 51.011 Section 10.3.46 class EF_CFIS(LinFixedEF): - _test_decode = [ + _test_de_encode = [ ( '0100ffffffffffffffffffffffffffff', {"msp_number": 1, "cfu_indicator_status": { "voice": False, "fax": False, "data": False, "rfu": 0 }, "len_of_bcd": 255, "ton_npi": {"ext": True, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib876fd799f871fe64ced2a7b64847ffd09e16ed9 Gerrit-Change-Number: 38200 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

11 months

1
0
0 0

[M] Change in pysim[master]: utils: get rid of enc_msisdn and dec_msisdn

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38118?usp=email ) Change subject: utils: get rid of enc_msisdn and dec_msisdn ...................................................................... Patch Set 8: (1 comment) Patchset: PS1: > do we really want to continue to use those functions if we have proper construct encoder/decoder in […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38118?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I19ec8ba14551ec282fc0cc12ae2f6d528bdfc527 Gerrit-Change-Number: 38118 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 18 Sep 2024 14:59:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

11 months

1
0
0 0

[S] Change in pysim[master]: ts_51_011: replace encoding of EF.MSISDN with construct model

by dexter

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38117?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ts_51_011: replace encoding of EF.MSISDN with construct model ...................................................................... ts_51_011: replace encoding of EF.MSISDN with construct model The encoding of EF.MSISDN is currently done with enc_msisdn and dec_msisdn from utils.py. Let's replace this with a construct based model, similar to the one we already use with EF.ADN Related: OS#5714 Change-Id: I647f5c63f7f87902a86c0c5d8e92fdc7f4350a5a --- M pySim/ts_51_011.py M tests/pySim-trace_test/pySim-trace_test_gsmtap.pcapng.ok 2 files changed, 20 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/17/38117/7 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38117?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I647f5c63f7f87902a86c0c5d8e92fdc7f4350a5a Gerrit-Change-Number: 38117 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

11 months

1
0
0 0

[M] Change in pysim[master]: utils: get rid of enc_msisdn and dec_msisdn

by dexter

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38118?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: utils: get rid of enc_msisdn and dec_msisdn ...................................................................... utils: get rid of enc_msisdn and dec_msisdn We now have a construct based encoder/decoder for the record content of EF.MSISDN. This means we can now replace enc/dec_msisdn, which is still used by pySim-read and pySim-prog with with that encoder/decoder. Related: OS#5714 Change-Id: I19ec8ba14551ec282fc0cc12ae2f6d528bdfc527 --- M pySim-read.py M pySim/legacy/cards.py M pySim/utils.py M tests/unittests/test_utils.py 4 files changed, 37 insertions(+), 120 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/18/38118/8 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38118?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I19ec8ba14551ec282fc0cc12ae2f6d528bdfc527 Gerrit-Change-Number: 38118 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

11 months

1
0
0 0

[S] Change in osmo-msc[master]: Remove speech codec list from bearer_cap for phase 1 mobile station

by pespin

Attention is currently required from: jolly, neels, nt2mku. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38197?usp=email ) Change subject: Remove speech codec list from bearer_cap for phase 1 mobile station ...................................................................... Patch Set 1: (8 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/8d2c09cf_0f3c80c0?usp… : PS1, Line 929: /* Remove codecs in bearer_cap that are unsupported by phase 1 mobile stations. It probably makes sense to move this to a helper function, eg bearer_cap_filter_rev_lev(sutrct gsm_mncc_bearer_cap *bearer_cap, unsigned rev_len); https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/58108fe0_9e5d3c8d?usp… : PS1, Line 990: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations. octets https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/851005b8_8b6e2404?usp… : PS1, Line 992: if (trans->vsub->classmark.classmark1.rev_lev == 0) I guess you could do this in the GSM48_BCAP_ITCAP_SPEECH code path above? https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/e7bd8c28_e8d4e767?usp… : PS1, Line 1158: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations. octets https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/85b6308d_0c6a655a?usp… : PS1, Line 1878: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations. octets https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/be1dd5a7_f750d7c7?usp… : PS1, Line 1930: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations. octets https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/3eeed32e_c0886c4f?usp… : PS1, Line 1988: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations. octets https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/262c1abf_059b30de?usp… : PS1, Line 1991: modify->bearer_cap.speech_ver[0] = -1; I see this being done in lots of places, it may make sense to move the logic to a helper function to have it once so it can easily be identified when this logic is used. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idd267dad0ade18cee7d5be813a57e1ee3168e2db Gerrit-Change-Number: 38197 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: nt2mku <degrunert.web(a)googlemail.com> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Comment-Date: Wed, 18 Sep 2024 13:34:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

11 months

1
0
0 0

[M] Change in pysim[master]: utils: support alpha identifier in enc/dec_msisdn

by dexter

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38118?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: utils: support alpha identifier in enc/dec_msisdn ...................................................................... utils: support alpha identifier in enc/dec_msisdn The functions enc_msisdn and dec_msisdn do not support encoding and decoding of the alpha identifier. Let's extend the functions accordingly. Related: OS#5714 Change-Id: I19ec8ba14551ec282fc0cc12ae2f6d528bdfc527 --- M pySim-read.py M pySim/utils.py M tests/unittests/test_utils.py 3 files changed, 43 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/18/38118/7 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38118?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I19ec8ba14551ec282fc0cc12ae2f6d528bdfc527 Gerrit-Change-Number: 38118 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024