September 2024 - gerrit-log - lists.osmocom.org

[XS] Change in docker-playground[master]: debian-bookworm-titan: chown 1000 for deps

by laforge

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/38227?usp=email ) Change subject: debian-bookworm-titan: chown 1000 for deps ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id51885d0929f4966b1a4a181b3453c06d7956b53 Gerrit-Change-Number: 38227 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 12:11:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months

1
0
0 0

[XS] Change in pysim[master]: requirements: require at least construct version 2.10.70

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38198?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: requirements: require at least construct version 2.10.70 ...................................................................... requirements: require at least construct version 2.10.70 Older construct versions seem to have problems, in particular with evaluating COptional() correctly. With 2.10.70 no such problems were observed. Related: OS#5714 Change-Id: If59dc708a7194649d1f42c4cf33f6328edcb80d2 --- M requirements.txt M setup.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/requirements.txt b/requirements.txt index 25e3654..2251a0a 100644 --- a/requirements.txt +++ b/requirements.txt @@ -3,7 +3,7 @@ pytlv cmd2>=1.5 jsonpath-ng -construct>=2.9.51 +construct>=2.10.70 bidict pyosmocom>=0.0.3 pyyaml>=5.1 diff --git a/setup.py b/setup.py index 10500d3..aa92f17 100644 --- a/setup.py +++ b/setup.py @@ -22,7 +22,7 @@ "pytlv", "cmd2 >= 1.5.0", "jsonpath-ng", - "construct >= 2.9.51", + "construct >= 2.10.70", "bidict", "pyosmocom >= 0.0.3", "pyyaml >= 5.1", -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If59dc708a7194649d1f42c4cf33f6328edcb80d2 Gerrit-Change-Number: 38198 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

11 months

1
0
0 0

[XS] Change in docker-playground[master]: debian-bookworm-titan: chown 1000 for deps

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/38227?usp=email ) Change subject: debian-bookworm-titan: chown 1000 for deps ...................................................................... Patch Set 1: (1 comment) File debian-bookworm-titan/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/38227/comment/ae53eb5f_1de… : PS1, Line 82: chown -R 1000:1000 /osmo-ttcn3-hacks/deps > I think a comment here (or above) explaining why this line is needed here would be welcome (ie. […] Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id51885d0929f4966b1a4a181b3453c06d7956b53 Gerrit-Change-Number: 38227 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 12:08:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

11 months

1
0
0 0

[XS] Change in docker-playground[master]: debian-bookworm-titan: chown 1000 for deps

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/38227?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: debian-bookworm-titan: chown 1000 for deps ...................................................................... debian-bookworm-titan: chown 1000 for deps Change the ownership of the "deps" directory to a not yet created user with the ID 1000. This user gets created when the gerrit verifications use the container for building. Changing the ownership of the deps directory allows using them and updating them as needed (e.g. if the patch in review changes a commit of one of the deps). Chowning here once results in faster jobs, compared to if we did it every time the gerrit verifications job ran. Creating the user here would result in conflicts with other containers depending on debian-bookworm-titan that may create their own user with the same UID. Related: osmo-ci I4bea336097e8180b19b3afa41c0b984d93c21bd1 Change-Id: Id51885d0929f4966b1a4a181b3453c06d7956b53 --- M debian-bookworm-titan/Dockerfile 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/27/38227/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id51885d0929f4966b1a4a181b3453c06d7956b53 Gerrit-Change-Number: 38227 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: deps: make output readable

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38221?usp=email ) Change subject: deps: make output readable ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38221?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0231488b02fdb5aa19b864e51864682ebbb3b0c6 Gerrit-Change-Number: 38221 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 11:56:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/gerrit: osmo-ttcn3-hacks: drop chown

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38228?usp=email ) Change subject: jobs/gerrit: osmo-ttcn3-hacks: drop chown ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4bea336097e8180b19b3afa41c0b984d93c21bd1 Gerrit-Change-Number: 38228 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 11:56:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months

1
0
0 0

[XS] Change in docker-playground[master]: debian-bookworm-titan: chown 1000 for deps

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/38227?usp=email ) Change subject: debian-bookworm-titan: chown 1000 for deps ...................................................................... Patch Set 1: (1 comment) File debian-bookworm-titan/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/38227/comment/8a00f19a_da5… : PS1, Line 82: chown -R 1000:1000 /osmo-ttcn3-hacks/deps I think a comment here (or above) explaining why this line is needed here would be welcome (ie. explain Dockerfiles inheriting this one will need access to the files.) -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id51885d0929f4966b1a4a181b3453c06d7956b53 Gerrit-Change-Number: 38227 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 11:56:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: deps: make output readable

by osmith

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38221?usp=email to look at the new patch set (#3). Change subject: deps: make output readable ...................................................................... deps: make output readable Instead of having a silent fetch and commits printed to stdout without information about the repository they belong to, change the output to have one line per git action and to include the repository name in each of them. Example output: [titan.ProtocolEmulations.M3UA] Checking out b58f92046e48a7b1ed531e243a2319ebca53bf4c [titan.ProtocolModules.IP] Checking out 1be86705f39ae38f3c04b2109806ee20d25e91d0 [titan.ProtocolModules.GTP_v13.5.0] Checking out 6b769f985eb91bf5a4332f29faa4a043b23ce62e [titan.ProtocolModules.ICMP] Checking out e49d9fb9f7de637b4bf4803dc6b6e911a8661640 [osmo-uecups] Initial git clone [titan.ProtocolModules.DIAMETER_ProtocolModule_Generator] Checking out ffd939595a08da1b8c8176aaa1f8578bfe02a912 [titan.ProtocolModules.L2TP] Checking out 17e76d3662bd0bb815158e8a9de1ec413f21b530 [titan.ProtocolModules.ICMPv6] Checking out 46f4d9b6e1e3c794294a92588401a81e4881dd27 [titan.ProtocolModules.LLC_v7.1.0] Checking out 09817f113255d7fb56f1d45d3dd629a093d9248d [titan.ProtocolModules.M3UA] Checking out c496d298876fed55c2b730278b7ee77982555563 [titan.ProtocolModules.PFCP_v15.1.0] Checking out d550ad9ddb6f9c823c9a555254cd76cf0e738d18 [titan.ProtocolModules.MobileL3_v13.4.0] Checking out b6602eb357673f097ea1a1d22edd568ecd239da1 [titan.TestPorts.TELNETasp] Checking out 873fe539642542cd9a901c208f1ec11c6d2f5387 [titan.TestPorts.SIPmsg] Checking out 78bf0daf8c599d374089d97a054914d8439d133a [titan.TestPorts.UDPasp] Checking out 54176e95850654e5e8b0ffa2f1b5f35c412b949c [titan.ProtocolModules.BSSGP_v13.0.0] Checking out e97d92a8b66bec399babea52f593771b76cb175a [titan.ProtocolModules.BSSMAP] Checking out 4acb6ab5f058477f0b90c2da182d52054e3614b0 [osmo-uecups] Updating URL to https://gerrit.osmocom.org/osmo-uecups [osmo-uecups] Checking out 8362efef7c6fa341eb947a75786878e0685767b7 Change-Id: I0231488b02fdb5aa19b864e51864682ebbb3b0c6 --- M deps/Makefile M deps/update.sh 2 files changed, 9 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/38221/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38221?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0231488b02fdb5aa19b864e51864682ebbb3b0c6 Gerrit-Change-Number: 38221 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: deps: make output readable

by osmith

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38221?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: deps: make output readable ...................................................................... deps: make output readable Instead of having a silent fetch and commits printed to stdout without information about the repository they belong to, change the output to have one line per git action and to include the repository name in each of them. Example output: [titan.ProtocolEmulations.M3UA] Checking out b58f92046e48a7b1ed531e243a2319ebca53bf4c [titan.ProtocolModules.IP] Checking out 1be86705f39ae38f3c04b2109806ee20d25e91d0 [titan.ProtocolModules.GTP_v13.5.0] Checking out 6b769f985eb91bf5a4332f29faa4a043b23ce62e [titan.ProtocolModules.ICMP] Checking out e49d9fb9f7de637b4bf4803dc6b6e911a8661640 [osmo-uecups] Initial git clone [titan.ProtocolModules.DIAMETER_ProtocolModule_Generator] Checking out ffd939595a08da1b8c8176aaa1f8578bfe02a912 [titan.ProtocolModules.L2TP] Checking out 17e76d3662bd0bb815158e8a9de1ec413f21b530 [titan.ProtocolModules.ICMPv6] Checking out 46f4d9b6e1e3c794294a92588401a81e4881dd27 [titan.ProtocolModules.LLC_v7.1.0] Checking out 09817f113255d7fb56f1d45d3dd629a093d9248d [titan.ProtocolModules.M3UA] Checking out c496d298876fed55c2b730278b7ee77982555563 [titan.ProtocolModules.PFCP_v15.1.0] Checking out d550ad9ddb6f9c823c9a555254cd76cf0e738d18 [titan.ProtocolModules.MobileL3_v13.4.0] Checking out b6602eb357673f097ea1a1d22edd568ecd239da1 [titan.TestPorts.TELNETasp] Checking out 873fe539642542cd9a901c208f1ec11c6d2f5387 [titan.TestPorts.SIPmsg] Checking out 78bf0daf8c599d374089d97a054914d8439d133a [titan.TestPorts.UDPasp] Checking out 54176e95850654e5e8b0ffa2f1b5f35c412b949c [titan.ProtocolModules.BSSGP_v13.0.0] Checking out e97d92a8b66bec399babea52f593771b76cb175a [titan.ProtocolModules.BSSMAP] Checking out 4acb6ab5f058477f0b90c2da182d52054e3614b0 [osmo-uecups] Updating URL to https://gerrit.osmocom.org/osmo-uecups [osmo-uecups] Checking out 8362efef7c6fa341eb947a75786878e0685767b7 Change-Id: I0231488b02fdb5aa19b864e51864682ebbb3b0c6 --- M deps/Makefile A deps/deps M deps/update.sh 3 files changed, 10 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/38221/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38221?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0231488b02fdb5aa19b864e51864682ebbb3b0c6 Gerrit-Change-Number: 38221 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

11 months

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/gerrit: osmo-ttcn3-hacks: drop chown

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38228?usp=email ) Change subject: jobs/gerrit: osmo-ttcn3-hacks: drop chown ...................................................................... jobs/gerrit: osmo-ttcn3-hacks: drop chown The chown takes some time, do it once when building the docker image instead of doing it for every gerrit verification run. Depends: docker-playground Id51885d0929f4966b1a4a181b3453c06d7956b53 Change-Id: I4bea336097e8180b19b3afa41c0b984d93c21bd1 --- M jobs/gerrit-verifications.yml 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/28/38228/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index f98eac9..73d66ca 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -444,7 +444,6 @@ {timeout_cmd} \ sh -e -x -c ' useradd --uid=1000 build - chown -R build:build /osmo-ttcn3-hacks/deps for i in /osmo-ttcn3-hacks/deps/*/; do if ! [ -e /build/deps/"$(basename "$i")" ]; then ln -s "$i" /build/deps/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4bea336097e8180b19b3afa41c0b984d93c21bd1 Gerrit-Change-Number: 38228 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024