fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38245?usp=email )
Change subject: gen_links.sh.inc: 'set -e' to abort on error
......................................................................
gen_links.sh.inc: 'set -e' to abort on error
We should not tolerate errors in '*/gen_links.sh' files.
Change-Id: Id9367e4c45c84dcbf1c308581360be73242c0d38
---
M gen_links.sh.inc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/38245/1
diff --git a/gen_links.sh.inc b/gen_links.sh.inc
index c21bcd6..f134427 100644
--- a/gen_links.sh.inc
+++ b/gen_links.sh.inc
@@ -16,6 +16,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+set -e
+
rm -f .gitignore
gen_link() {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38245?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id9367e4c45c84dcbf1c308581360be73242c0d38
Gerrit-Change-Number: 38245
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38244?usp=email )
Change subject: {bsc-nat,selftest,sysinfo}/gen_links.sh: use bash, not sh
......................................................................
{bsc-nat,selftest,sysinfo}/gen_links.sh: use bash, not sh
This fixes the following error:
./gen_links.sh: 40: shopt: not found
which is printed when compiling the above-mentioned testsuites.
Change-Id: I994e241efb73f6f8b78803cf4ecdfb057b210a3b
---
M bsc-nat/gen_links.sh
M selftest/gen_links.sh
M sysinfo/gen_links.sh
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/38244/1
diff --git a/bsc-nat/gen_links.sh b/bsc-nat/gen_links.sh
index 395f50e..550aa45 100755
--- a/bsc-nat/gen_links.sh
+++ b/bsc-nat/gen_links.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
BASEDIR=../deps
diff --git a/selftest/gen_links.sh b/selftest/gen_links.sh
index 1a3bbe1..d5ffe6d 100755
--- a/selftest/gen_links.sh
+++ b/selftest/gen_links.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
BASEDIR=../deps
diff --git a/sysinfo/gen_links.sh b/sysinfo/gen_links.sh
index c8a3ee3..538fff2 100755
--- a/sysinfo/gen_links.sh
+++ b/sysinfo/gen_links.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
BASEDIR=../deps
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38244?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I994e241efb73f6f8b78803cf4ecdfb057b210a3b
Gerrit-Change-Number: 38244
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38213?usp=email )
Change subject: s1gw: add multi-eNB variants of TC_e_rab_setup
......................................................................
Patch Set 5:
(1 comment)
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38213/comment/99bb5a0e_5596… :
PS4, Line 83: vc_mutex_disp := f_MutexDisp_start();
> Having more stuff startd and stopped running and logging into the logs files. […]
I am not going to spend time optimizing this, sorry. There are still many more things to implement and many things to test, and an additional background process generating a few more lines in logging is the least thing I would care about.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38213?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9e2eb25a7ae78ff623b94802d881af4894d0cacd
Gerrit-Change-Number: 38213
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 21 Sep 2024 09:55:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>