September 2024 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: contrib/jenkins.sh: Install dependencies before calling pylint

by fixeria

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37966?usp=email ) Change subject: contrib/jenkins.sh: Install dependencies before calling pylint ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37966?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I29582aa3d7f9ace9ce832d5b907420aaf14881fb Gerrit-Change-Number: 37966 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 19:13:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: esim.saip.templates: Fix expand_default_value_pattern for length==0

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38016?usp=email ) Change subject: esim.saip.templates: Fix expand_default_value_pattern for length==0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38016?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I39fa1e2b1b9d6d1c671ea37bdbec1d6f97e8a5e7 Gerrit-Change-Number: 38016 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 03 Sep 2024 19:01:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: commands: avoid double lchan patching, get rid of cla_byte getter+set...

by laforge

Attention is currently required from: fixeria, laforge. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37937?usp=email ) Change subject: commands: avoid double lchan patching, get rid of cla_byte getter+setter methods ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I420f8a5f7ff8d9e5ef94d6519fb3716d6c7caf64 Gerrit-Change-Number: 37937 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 19:00:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

9 months, 3 weeks

1
0
0 0

[S] Change in osmo-upf[master]: pfcp-tool: n-sessions [3/4]: add poll arg to pfcp_tool_mainloop()

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37759?usp=email ) Change subject: pfcp-tool: n-sessions [3/4]: add poll arg to pfcp_tool_mainloop() ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: luckily the main loop is never going to want to call poll() directly, so its fine to shadow that global symbol name.. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37759?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I20bb2803b28681face18ee665d8a1aad06d58091 Gerrit-Change-Number: 37759 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 17:50:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[M] Change in osmo-upf[master]: pfcp-tool: n-sessions [2/4]: generalize function args

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37758?usp=email ) Change subject: pfcp-tool: n-sessions [2/4]: generalize function args ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/osmo-pfcp-tool/pfcp_tool.c: https://gerrit.osmocom.org/c/osmo-upf/+/37758/comment/17fe2fac_68bb804f?usp… : PS3, Line 182: LOGP(DLPFCP, LOGL_ERROR, "Failed to transmit PFCP: %s\n", strerror(-rc)); > since this program is used for load testing and may potentially switch to being multithread, it may […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37758?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I112206049e704b7adad7072b1f7953f7ee4f18ca Gerrit-Change-Number: 37758 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 17:48:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[S] Change in osmo-upf[master]: pfcp-tool: n-sessions [1/4]: add generators for TEID and UE IP

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37757?usp=email ) Change subject: pfcp-tool: n-sessions [1/4]: add generators for TEID and UE IP ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo-pfcp-tool/pfcp_tool.h: https://gerrit.osmocom.org/c/osmo-upf/+/37757/comment/e0cf8b46_9a7e9266?usp… : PS2, Line 124: uint32_t pfcp_tool_new_teid(void); > the field above is named next. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37757?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Iec164a222782d382aefe8d0342f398ebba1eac05 Gerrit-Change-Number: 37757 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 17:48:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[M] Change in osmo-upf[master]: nft: batch nftables commands

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37762?usp=email ) Change subject: nft: batch nftables commands ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37762?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib0a8e86b29bab1559d94fc55a89daa00ec670318 Gerrit-Change-Number: 37762 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 17:46:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: Rename s/g_pars/g__pars

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38018?usp=email ) Change subject: HTTP_Adapter: Rename s/g_pars/g__pars ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'd go for g_http_pars, that way its clear and extensible, so the next component doesn't have to use […] Fine with it, I'll do the change as requested. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38018?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia07cf8717593073a71632e247d7fe0775e66eb13 Gerrit-Change-Number: 38018 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 03 Sep 2024 17:44:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

9 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: Rename s/g_pars/g__pars

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38018?usp=email ) Change subject: HTTP_Adapter: Rename s/g_pars/g__pars ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'd go for g_http_pars, that way its clear and extensible, so the next component doesn't have to use g_____pars at some point (exaggerating) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38018?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia07cf8717593073a71632e247d7fe0775e66eb13 Gerrit-Change-Number: 38018 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 17:43:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: Rename s/g_pars/g__pars

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38018?usp=email ) Change subject: HTTP_Adapter: Rename s/g_pars/g__pars ...................................................................... HTTP_Adapter: Rename s/g_pars/g__pars The HTTP_Adapter component is a probable candidate to end up as part of another component extending it, like the Prometheus_Checker coming up soon. Since the fields in HTTP_Adapter are available to subclass components, that means they cannot use the usual "g_pars". Rename the self-enclosed "g_pars" in HTTP_Adapter to let subclasses use it. Change-Id: Ia07cf8717593073a71632e247d7fe0775e66eb13 --- M library/HTTP_Adapter.ttcn 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/18/38018/1 diff --git a/library/HTTP_Adapter.ttcn b/library/HTTP_Adapter.ttcn index 97233e5..bba0216 100644 --- a/library/HTTP_Adapter.ttcn +++ b/library/HTTP_Adapter.ttcn @@ -19,7 +19,8 @@ type component http_CT { port HTTPmsg_PT HTTP; - var HTTP_Adapter_Params g_pars; + /* double underscore to have "g_pars" available on components extending this one: */ + var HTTP_Adapter_Params g__pars; }; type record HTTP_Adapter_Params { @@ -30,7 +31,7 @@ function f_http_init(HTTP_Adapter_Params pars) runs on http_CT { map(self:HTTP, system:HTTP); - g_pars := pars; + g__pars := pars; } template (value) Connect ts_HTTP_Connect(template (value) charstring hostname, @@ -187,7 +188,7 @@ /* In case the caller didn't specify a client_id, we will create a new connection. */ if (istemplatekind(client_id, "omit")) { - HTTP.send(ts_HTTP_Connect(g_pars.http_host, g_pars.http_port, g_pars.use_ssl)); + HTTP.send(ts_HTTP_Connect(g__pars.http_host, g__pars.http_port, g__pars.use_ssl)); T.start; alt { [] HTTP.receive(Connect_result:?) -> value rc; @@ -207,16 +208,16 @@ if (not istemplatekind(body, "omit") and istemplatekind(binary_body, "omit")) { /* HTTP message with ASCII content */ - HTTP.send(ts_HTTP_Req(url, method, body, host := g_pars.http_host & ":" & int2str(g_pars.http_port), + HTTP.send(ts_HTTP_Req(url, method, body, host := g__pars.http_host & ":" & int2str(g__pars.http_port), custom_hdr := custom_hdr, client_id := use_client_id)); } else if (not istemplatekind(binary_body, "omit") and istemplatekind(body, "omit")) { /* HTTP message with binary content */ HTTP.send(ts_HTTP_Req_Bin(url, method, binary_body, - host := g_pars.http_host & ":" & int2str(g_pars.http_port), + host := g__pars.http_host & ":" & int2str(g__pars.http_port), custom_hdr := custom_hdr, client_id := use_client_id)); } else if (istemplatekind(binary_body, "omit") and istemplatekind(body, "omit")) { /* HTTP message without content (e.g. a GET request) */ - HTTP.send(ts_HTTP_Req(url, method, host := g_pars.http_host & ":" & int2str(g_pars.http_port), + HTTP.send(ts_HTTP_Req(url, method, host := g__pars.http_host & ":" & int2str(g__pars.http_port), custom_hdr := custom_hdr, client_id := use_client_id)); } else { setverdict(fail, "either binary_body or body must be used (a request can contain either ASCII data or binary data, not both!"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38018?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia07cf8717593073a71632e247d7fe0775e66eb13 Gerrit-Change-Number: 38018 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024