Attention is currently required from: neels, pespin. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37758?usp=email ) Change subject: pfcp-tool: n-sessions [2/4]: generalize function args ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/osmo-pfcp-tool/pfcp_tool.c: https://gerrit.osmocom.org/c/osmo-upf/+/37758/comment/17fe2fac_68bb804f?usp=... : PS3, Line 182: LOGP(DLPFCP, LOGL_ERROR, "Failed to transmit PFCP: %s\n", strerror(-rc));

since this program is used for load testing and may potentially switch to being multithread, it may […] Acknowledged

-- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37758?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I112206049e704b7adad7072b1f7953f7ee4f18ca Gerrit-Change-Number: 37758 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 17:48:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin@sysmocom.de>