August 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-upf[master]: osmo-upf: add VTY 'gtp-echo' command

by laforge

Attention is currently required from: fixeria, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37830?usp=email ) Change subject: osmo-upf: add VTY 'gtp-echo' command ...................................................................... Patch Set 3: (1 comment) File src/osmo-upf/upf_vty.c: https://gerrit.osmocom.org/c/osmo-upf/+/37830/comment/0fb42bf1_25e6b834?usp… : PS1, Line 491: tx to > I would write "[(a|b) ARG]" but it's a limitation of VTY that we need to write "[(a|b)] [ARG]"... […] AFAICT, the latest version of the patch still doesn't use VTY_IPV46_CMD but re-defines this in every command. This is not how we do it in other places where we encounter the same situation (gb2, libosmo-sigtran, ...) -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I970dccd7a27b098eea9e660822e24e2c4b059fc6 Gerrit-Change-Number: 37830 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Aug 2024 06:37:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

10 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: ctrl, hnbgw: access rate counter groups by given ID instead of index

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email ) Change subject: ctrl, hnbgw: access rate counter groups by given ID instead of index ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > This extra level of indirection having to specify a map makes stuff too complex for no reason imho. […] I see this was resolved but there was no fedbac? I also couldn't see ant changes in the code? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I70e74e7554482df67aa1d90bc04314124dea444f Gerrit-Change-Number: 37882 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Aug 2024 06:34:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

10 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: fixup: initialize g_hnbp_ctr_id = 0

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37880?usp=email ) Change subject: fixup: initialize g_hnbp_ctr_id = 0 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > that's news to me -- does that mean whenever I have hit bugs of uninitialized variables, it was *alw […] heap allocations and static variables on the stack are not initialized. global static variables are in a different linker section (bss) which is cleared with zeroes at program start-up. This behaviour (not the unix/linux implementation detail of a "bss segment") is required by the C and C++ standards, AFAICT. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37880?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I353e026d6e3d2c3c8b13a0ca8bd4c09609632b84 Gerrit-Change-Number: 37880 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Aug 2024 06:32:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

10 months, 2 weeks

1
0
0 0

[L] Change in libosmocore[master]: tests: add unit test for osmo_fr_sid_classify()

by laforge

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/37912?usp=email ) Change subject: tests: add unit test for osmo_fr_sid_classify() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie3f5339cdfecf39e359d635d58864dd323f41fff Gerrit-Change-Number: 37912 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 23 Aug 2024 06:27:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 2 weeks

1
0
0 0

[L] Change in libosmocore[master]: tests: add unit test for osmo_fr_sid_classify()

by falconia

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/37912?usp=email ) Change subject: tests: add unit test for osmo_fr_sid_classify() ...................................................................... tests: add unit test for osmo_fr_sid_classify() The bit patterns used to construct this unit test have been generated here: https://www.freecalypso.org/hg/vband-misc/file/tip/fr-sid These test patterns have been used successfully to reveal an off-by-one bug in the implementation of FRv1 Rx SID classification in Nokia InSite BTS: https://osmocom.org/projects/retro-gsm/wiki/InSite_UL_captures The implementation in TI Calypso DSP has also been tested with these patterns and found to be correct per GSM 06.31 spec, unlike the Nokia BTS. Related: OS#6538 Change-Id: Ie3f5339cdfecf39e359d635d58864dd323f41fff --- M tests/Makefile.am A tests/codec/codec_fr_sid_test.c A tests/codec/codec_fr_sid_test.in A tests/codec/codec_fr_sid_test.ok M tests/testsuite.at 5 files changed, 469 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/12/37912/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index c82e924..48242c3 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -27,7 +27,7 @@ prbs/prbs_test gsm23003/gsm23003_test \ gsm23236/gsm23236_test \ codec/codec_ecu_fr_test codec/codec_efr_sid_test \ - codec/codec_hr_sid_test \ + codec/codec_fr_sid_test codec/codec_hr_sid_test \ timer/clk_override_test \ oap/oap_client_test gsm29205/gsm29205_test \ logging/logging_vty_test \ @@ -270,6 +270,9 @@ codec_codec_efr_sid_test_SOURCES = codec/codec_efr_sid_test.c codec_codec_efr_sid_test_LDADD = $(top_builddir)/src/codec/libosmocodec.la $(LDADD) +codec_codec_fr_sid_test_SOURCES = codec/codec_fr_sid_test.c +codec_codec_fr_sid_test_LDADD = $(top_builddir)/src/codec/libosmocodec.la $(LDADD) + codec_codec_hr_sid_test_SOURCES = codec/codec_hr_sid_test.c codec_codec_hr_sid_test_LDADD = $(top_builddir)/src/codec/libosmocodec.la $(LDADD) @@ -447,6 +450,7 @@ codec/codec_test.ok \ codec/codec_ecu_fr_test.ok \ codec/codec_efr_sid_test.ok codec/codec_efr_sid_test.in \ + codec/codec_fr_sid_test.ok codec/codec_fr_sid_test.in \ codec/codec_hr_sid_test.ok codec/codec_hr_sid_test.in \ vty/vty_test.ok vty/vty_test.err \ vty/fail_not_de-indented.cfg \ @@ -610,6 +614,8 @@ >$(srcdir)/codec/codec_ecu_fr_test.ok codec/codec_efr_sid_test $(srcdir)/codec/codec_efr_sid_test.in \ >$(srcdir)/codec/codec_efr_sid_test.ok + codec/codec_fr_sid_test $(srcdir)/codec/codec_fr_sid_test.in \ + >$(srcdir)/codec/codec_fr_sid_test.ok codec/codec_hr_sid_test $(srcdir)/codec/codec_hr_sid_test.in \ >$(srcdir)/codec/codec_hr_sid_test.ok if ENABLE_GB diff --git a/tests/codec/codec_fr_sid_test.c b/tests/codec/codec_fr_sid_test.c new file mode 100644 index 0000000..25c1b3f --- /dev/null +++ b/tests/codec/codec_fr_sid_test.c @@ -0,0 +1,97 @@ +/* + * This program is a test for osmo_fr_sid_classify(). It reads a set of + * FRv1 codec frames in hex format (TS 101 318 RTP format represented in hex, + * each frame as its own hex line) and feeds each test frame to + * osmo_fr_sid_classify(). It then prints the output next to each input. + * + * Author: Mychaela N. Falconia <falcon(a)freecalypso.org>, 2024 - however, + * Mother Mychaela's contributions are NOT subject to copyright. + * No rights reserved, all rights relinquished. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <ctype.h> +#include <stdio.h> +#include <stdint.h> +#include <stdbool.h> +#include <stdlib.h> +#include <string.h> + +#include <osmocom/core/utils.h> +#include <osmocom/codec/codec.h> + +static void process_record(const char *hex_str) +{ + uint8_t frame_bytes[GSM_FR_BYTES]; + enum osmo_gsm631_sid_class sidc; + + osmo_hexparse(hex_str, frame_bytes, GSM_FR_BYTES); + sidc = osmo_fr_sid_classify(frame_bytes); + printf("%s ==> %d\n", hex_str, (int) sidc); +} + +static void process_line(char *linebuf, const char *infname, int lineno) +{ + char *cp = linebuf, *hex_str; + int ndig; + + while (isspace(*cp)) + cp++; + if (*cp == '\0' || *cp == '#') + return; + /* expect string of 66 hex digits */ + hex_str = cp; + for (ndig = 0; ndig < GSM_FR_BYTES * 2; ndig++) { + if (!isxdigit(*cp)) + goto inv; + cp++; + } + if (*cp) { + if (!isspace(*cp)) + goto inv; + *cp++ = '\0'; + } + /* must be end of non-comment line */ + while (isspace(*cp)) + cp++; + if (*cp != '\0' && *cp != '#') + goto inv; + + process_record(hex_str); + return; + +inv: fprintf(stderr, "%s line %d: invalid syntax\n", infname, lineno); + exit(1); +} + +int main(int argc, char **argv) +{ + const char *infname; + FILE *inf; + char linebuf[128]; + int lineno; + + if (argc != 2) { + fprintf(stderr, "usage: %s input-file\n", argv[0]); + exit(1); + } + infname = argv[1]; + inf = fopen(infname, "r"); + if (!inf) { + perror(infname); + exit(1); + } + for (lineno = 1; fgets(linebuf, sizeof(linebuf), inf); lineno++) + process_line(linebuf, infname, lineno); + fclose(inf); + exit(0); +} diff --git a/tests/codec/codec_fr_sid_test.in b/tests/codec/codec_fr_sid_test.in new file mode 100644 index 0000000..d5930e2 --- /dev/null +++ b/tests/codec/codec_fr_sid_test.in @@ -0,0 +1,184 @@ +# This file is input for the FRv1 SID classifier test program. +# It has been generated here: +# +# https://www.freecalypso.org/hg/vband-misc/file/tip/fr-sid +# +# It is based on the same principle as the EFR version: +# +# https://www.freecalypso.org/hg/vband-misc/file/tip/efr-sid/Unit-test-desc + +DAE6DB659B00010000000000000100000000000001000000000000010000000000 +DAE6DB659B00014000000000000100000000000001000000000000010000000000 +DAE6DB659B00012000000000000100000000000001000000000000010000000000 +DAE6DB659B00010800000000000100000000000001000000000000010000000000 +DAE6DB659B00010400000000000100000000000001000000000000010000000000 +DAE6DB659B00010100000000000100000000000001000000000000010000000000 +DAE6DB659B00010080000000000100000000000001000000000000010000000000 +DAE6DB659B00010020000000000100000000000001000000000000010000000000 +DAE6DB659B00010010000000000100000000000001000000000000010000000000 +DAE6DB659B00010004000000000100000000000001000000000000010000000000 +DAE6DB659B00010002000000000100000000000001000000000000010000000000 +DAE6DB659B00010000800000000100000000000001000000000000010000000000 +DAE6DB659B00010000400000000100000000000001000000000000010000000000 +DAE6DB659B00010000100000000100000000000001000000000000010000000000 +DAE6DB659B00010000080000000100000000000001000000000000010000000000 +DAE6DB659B00010000020000000100000000000001000000000000010000000000 +DAE6DB659B00010000010000000100000000000001000000000000010000000000 +DAE6DB659B00010000004000000100000000000001000000000000010000000000 +DAE6DB659B00010000002000000100000000000001000000000000010000000000 +DAE6DB659B00010000000800000100000000000001000000000000010000000000 +DAE6DB659B00010000000400000100000000000001000000000000010000000000 +DAE6DB659B00010000000100000100000000000001000000000000010000000000 +DAE6DB659B00010000000080000100000000000001000000000000010000000000 +DAE6DB659B00010000000020000100000000000001000000000000010000000000 +DAE6DB659B00010000000010000100000000000001000000000000010000000000 +DAE6DB659B00010000000004000100000000000001000000000000010000000000 +DAE6DB659B00010000000002000100000000000001000000000000010000000000 +DAE6DB659B00010000000000000140000000000001000000000000010000000000 +DAE6DB659B00010000000000000120000000000001000000000000010000000000 +DAE6DB659B00010000000000000108000000000001000000000000010000000000 +DAE6DB659B00010000000000000104000000000001000000000000010000000000 +DAE6DB659B00010000000000000101000000000001000000000000010000000000 +DAE6DB659B00010000000000000100800000000001000000000000010000000000 +DAE6DB659B00010000000000000100200000000001000000000000010000000000 +DAE6DB659B00010000000000000100100000000001000000000000010000000000 +DAE6DB659B00010000000000000100040000000001000000000000010000000000 +DAE6DB659B00010000000000000100020000000001000000000000010000000000 +DAE6DB659B00010000000000000100008000000001000000000000010000000000 +DAE6DB659B00010000000000000100004000000001000000000000010000000000 +DAE6DB659B00010000000000000100001000000001000000000000010000000000 +DAE6DB659B00010000000000000100000800000001000000000000010000000000 +DAE6DB659B00010000000000000100000200000001000000000000010000000000 +DAE6DB659B00010000000000000100000100000001000000000000010000000000 +DAE6DB659B00010000000000000100000040000001000000000000010000000000 +DAE6DB659B00010000000000000100000020000001000000000000010000000000 +DAE6DB659B00010000000000000100000008000001000000000000010000000000 +DAE6DB659B00010000000000000100000004000001000000000000010000000000 +DAE6DB659B00010000000000000100000001000001000000000000010000000000 +DAE6DB659B00010000000000000100000000800001000000000000010000000000 +DAE6DB659B00010000000000000100000000200001000000000000010000000000 +DAE6DB659B00010000000000000100000000100001000000000000010000000000 +DAE6DB659B00010000000000000100000000040001000000000000010000000000 +DAE6DB659B00010000000000000100000000020001000000000000010000000000 +DAE6DB659B00010000000000000100000000000001400000000000010000000000 +DAE6DB659B00010000000000000100000000000001200000000000010000000000 +DAE6DB659B00010000000000000100000000000001080000000000010000000000 +DAE6DB659B00010000000000000100000000000001040000000000010000000000 +DAE6DB659B00010000000000000100000000000001010000000000010000000000 +DAE6DB659B00010000000000000100000000000001008000000000010000000000 +DAE6DB659B00010000000000000100000000000001002000000000010000000000 +DAE6DB659B00010000000000000100000000000001001000000000010000000000 +DAE6DB659B00010000000000000100000000000001000400000000010000000000 +DAE6DB659B00010000000000000100000000000001000200000000010000000000 +DAE6DB659B00010000000000000100000000000001000080000000010000000000 +DAE6DB659B00010000000000000100000000000001000040000000010000000000 +DAE6DB659B00010000000000000100000000000001000010000000010000000000 +DAE6DB659B00010000000000000100000000000001000008000000010000000000 +DAE6DB659B00010000000000000100000000000001000002000000010000000000 +DAE6DB659B00010000000000000100000000000001000001000000010000000000 +DAE6DB659B00010000000000000100000000000001000000400000010000000000 +DAE6DB659B00010000000000000100000000000001000000200000010000000000 +DAE6DB659B00010000000000000100000000000001000000080000010000000000 +DAE6DB659B00010000000000000100000000000001000000040000010000000000 +DAE6DB659B00010000000000000100000000000001000000010000010000000000 +DAE6DB659B00010000000000000100000000000001000000008000010000000000 +DAE6DB659B00010000000000000100000000000001000000002000010000000000 +DAE6DB659B00010000000000000100000000000001000000001000010000000000 +DAE6DB659B00010000000000000100000000000001000000000400010000000000 +DAE6DB659B00010000000000000100000000000001000000000200010000000000 +DAE6DB659B00010000000000000100000000000001000000000000014000000000 +DAE6DB659B00010000000000000100000000000001000000000000012000000000 +DAE6DB659B00010000000000000100000000000001000000000000010800000000 +DAE6DB659B00010000000000000100000000000001000000000000010400000000 +DAE6DB659B00010000000000000100000000000001000000000000010100000000 +DAE6DB659B00010000000000000100000000000001000000000000010080000000 +DAE6DB659B00010000000000000100000000000001000000000000010020000000 +DAE6DB659B00010000000000000100000000000001000000000000010010000000 +DAE6DB659B00010000000000000100000000000001000000000000010004000000 +DAE6DB659B00010000000000000100000000000001000000000000010000800000 +DAE6DB659B00010000000000000100000000000001000000000000010000100000 +DAE6DB659B00010000000000000100000000000001000000000000010000020000 +DAE6DB659B00010000000000000100000000000001000000000000010000004000 +DAE6DB659B00010000000000000100000000000001000000000000010000000800 +DAE6DB659B00010000000000000100000000000001000000000000010000000100 +DAE6DB659B00010000000000000100000000000001000000000000010000000020 +DAE6DB659B00010000000000000100000000000001000000000000010000000004 +DAE6DB659B00014000000000000100000000800001000000000000010000000000 +DAE6DB659B00012000000000000100000000200001000000000000010000000000 +DAE6DB659B00010800000000000100000000100001000000000000010000000000 +DAE6DB659B00010400000000000100000000040001000000000000010000000000 +DAE6DB659B00010100000000000100000000020001000000000000010000000000 +DAE6DB659B00010080000000000100000000000001400000000000010000000000 +DAE6DB659B00010020000000000100000000000001200000000000010000000000 +DAE6DB659B00010010000000000100000000000001080000000000010000000000 +DAE6DB659B00010004000000000100000000000001040000000000010000000000 +DAE6DB659B00010002000000000100000000000001010000000000010000000000 +DAE6DB659B00010000800000000100000000000001008000000000010000000000 +DAE6DB659B00010000400000000100000000000001002000000000010000000000 +DAE6DB659B00010000100000000100000000000001001000000000010000000000 +DAE6DB659B00010000080000000100000000000001000400000000010000000000 +DAE6DB659B00010000020000000100000000000001000200000000010000000000 +DAE6DB659B00010000010000000100000000000001000080000000010000000000 +DAE6DB659B00010000004000000100000000000001000040000000010000000000 +DAE6DB659B00010000002000000100000000000001000010000000010000000000 +DAE6DB659B00010000000800000100000000000001000008000000010000000000 +DAE6DB659B00010000000400000100000000000001000002000000010000000000 +DAE6DB659B00010000000100000100000000000001000001000000010000000000 +DAE6DB659B00010000000080000100000000000001000000400000010000000000 +DAE6DB659B00010000000020000100000000000001000000200000010000000000 +DAE6DB659B00010000000010000100000000000001000000080000010000000000 +DAE6DB659B00010000000004000100000000000001000000040000010000000000 +DAE6DB659B00010000000002000100000000000001000000010000010000000000 +DAE6DB659B00010000000000000140000000000001000000008000010000000000 +DAE6DB659B00010000000000000120000000000001000000002000010000000000 +DAE6DB659B00010000000000000108000000000001000000001000010000000000 +DAE6DB659B00010000000000000104000000000001000000000400010000000000 +DAE6DB659B00010000000000000101000000000001000000000200010000000000 +DAE6DB659B00010000000000000100800000000001000000000000014000000000 +DAE6DB659B00010000000000000100200000000001000000000000012000000000 +DAE6DB659B00010000000000000100100000000001000000000000010800000000 +DAE6DB659B00010000000000000100040000000001000000000000010400000000 +DAE6DB659B00010000000000000100020000000001000000000000010100000000 +DAE6DB659B00010000000000000100008000000001000000000000010080000000 +DAE6DB659B00010000000000000100004000000001000000000000010020000000 +DAE6DB659B00010000000000000100001000000001000000000000010010000000 +DAE6DB659B00010000000000000100000800000001000000000000010004000000 +DAE6DB659B00010000000000000100000200000001000000000000010000800000 +DAE6DB659B00010000000000000100000100000001000000000000010000100000 +DAE6DB659B00010000000000000100000040000001000000000000010000020000 +DAE6DB659B00010000000000000100000020000001000000000000010000004000 +DAE6DB659B00010000000000000100000008000001000000000000010000000800 +DAE6DB659B00010000000000000100000004000001000000000000010000000100 +DAE6DB659B00010000000000000100000001000001000000000000010000000020 +DAE6DB659B00010000000000000100000000800001000000000000010000000004 +DAE6DB659B00014020100804000101008040200001080402010000014020000000 +DAE6DB659B00012010080402000100804020100001040201008000012010000000 +DAE6DB659B00010804020100000140201008040001010080402000010804000000 +DAE6DB659B00010402010080000120100804020001008040201000010400800000 +DAE6DB659B00010100804020000108040201000001402010080400010100100000 +DAE6DB659B00010080402010000104020100800001201008040200010080020000 +DAE6DB659B00010020100804000101008040200001080402010000014020004000 +DAE6DB659B00010010080402000100804020100001040201008000012010000800 +DAE6DB659B00010004020100000140201008040001010080402000010804000100 +DAE6DB659B00010002010080000120100804020001008040201000010400800020 +DAE6DB659B00010000804020000108040201000001402010080400010100100004 +DAE6DB659B00014080810102000101020204040001040408081000010000000000 +DAE6DB659B00012020404080000140808101020001010202040400010000000000 +DAE6DB659B00010810102020000120204040800001408081010200010000000000 +DAE6DB659B00010404080810000108101020200001202040408000014000000000 +DAE6DB659B00010102020404000104040808100001081010202000012000000000 +DAE6DB659B00010080810102000101020204040001040408081000010800000000 +DAE6DB659B00010020404080000140808101020001010202040400010400000000 +DAE6DB659B00010010102020000120204040800001408081010200010100000000 +DAE6DB659B00010004080810000108101020200001202040408000014080000000 +DAE6DB659B00010002020404000104040808100001081010202000012020000000 +DAE6DB659B00010000810102000101020204040001040408081000010810000000 +DAE6DB659B00010000404080000140808101020001010202040400010404000000 +DAE6DB659B00010000102020000120204040800001408081010200010100800000 +DAE6DB659B00010000080810000108101020200001202040408000014080100000 +DAE6DB659B00010000020404000104040808100001081010202000012020020000 +DAE6DB659B00010000010102000101020204040001040408081000010810004000 +DAE6DB659B00010000004080000140808101020001010202040400010404000800 +DAE6DB659B00010000002020000120204040800001408081010200010100800100 +DAE6DB659B00010000000810000108101020200001202040408000014080100020 +DAE6DB659B00010000000404000104040808100001081010202000012020020004 diff --git a/tests/codec/codec_fr_sid_test.ok b/tests/codec/codec_fr_sid_test.ok new file mode 100644 index 0000000..8dcaa34 --- /dev/null +++ b/tests/codec/codec_fr_sid_test.ok @@ -0,0 +1,175 @@ +DAE6DB659B00010000000000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00014000000000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00012000000000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010800000000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010400000000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010100000000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010080000000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010020000000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010010000000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010004000000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010002000000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000800000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000400000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000100000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000080000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000020000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000010000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000004000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000002000000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000800000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000400000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000100000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000080000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000020000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000010000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000004000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000002000100000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000140000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000120000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000108000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000104000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000101000000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100800000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100200000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100100000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100040000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100020000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100008000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100004000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100001000000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000800000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000200000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000100000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000040000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000020000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000008000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000004000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000001000001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000800001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000200001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000100001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000040001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000020001000000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001400000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001200000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001080000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001040000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001010000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001008000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001002000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001001000000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000400000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000200000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000080000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000040000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000010000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000008000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000002000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000001000000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000400000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000200000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000080000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000040000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000010000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000008000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000002000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000001000010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000400010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000200010000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000014000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000012000000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000010800000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000010400000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000010100000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000010080000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000010020000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000010010000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000010004000000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000010000800000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000010000100000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000010000020000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000010000004000 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000010000000800 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000010000000100 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000010000000020 ==> 2 +DAE6DB659B00010000000000000100000000000001000000000000010000000004 ==> 2 +DAE6DB659B00014000000000000100000000800001000000000000010000000000 ==> 1 +DAE6DB659B00012000000000000100000000200001000000000000010000000000 ==> 1 +DAE6DB659B00010800000000000100000000100001000000000000010000000000 ==> 1 +DAE6DB659B00010400000000000100000000040001000000000000010000000000 ==> 1 +DAE6DB659B00010100000000000100000000020001000000000000010000000000 ==> 1 +DAE6DB659B00010080000000000100000000000001400000000000010000000000 ==> 1 +DAE6DB659B00010020000000000100000000000001200000000000010000000000 ==> 1 +DAE6DB659B00010010000000000100000000000001080000000000010000000000 ==> 1 +DAE6DB659B00010004000000000100000000000001040000000000010000000000 ==> 1 +DAE6DB659B00010002000000000100000000000001010000000000010000000000 ==> 1 +DAE6DB659B00010000800000000100000000000001008000000000010000000000 ==> 1 +DAE6DB659B00010000400000000100000000000001002000000000010000000000 ==> 1 +DAE6DB659B00010000100000000100000000000001001000000000010000000000 ==> 1 +DAE6DB659B00010000080000000100000000000001000400000000010000000000 ==> 1 +DAE6DB659B00010000020000000100000000000001000200000000010000000000 ==> 1 +DAE6DB659B00010000010000000100000000000001000080000000010000000000 ==> 1 +DAE6DB659B00010000004000000100000000000001000040000000010000000000 ==> 1 +DAE6DB659B00010000002000000100000000000001000010000000010000000000 ==> 1 +DAE6DB659B00010000000800000100000000000001000008000000010000000000 ==> 1 +DAE6DB659B00010000000400000100000000000001000002000000010000000000 ==> 1 +DAE6DB659B00010000000100000100000000000001000001000000010000000000 ==> 1 +DAE6DB659B00010000000080000100000000000001000000400000010000000000 ==> 1 +DAE6DB659B00010000000020000100000000000001000000200000010000000000 ==> 1 +DAE6DB659B00010000000010000100000000000001000000080000010000000000 ==> 1 +DAE6DB659B00010000000004000100000000000001000000040000010000000000 ==> 1 +DAE6DB659B00010000000002000100000000000001000000010000010000000000 ==> 1 +DAE6DB659B00010000000000000140000000000001000000008000010000000000 ==> 1 +DAE6DB659B00010000000000000120000000000001000000002000010000000000 ==> 1 +DAE6DB659B00010000000000000108000000000001000000001000010000000000 ==> 1 +DAE6DB659B00010000000000000104000000000001000000000400010000000000 ==> 1 +DAE6DB659B00010000000000000101000000000001000000000200010000000000 ==> 1 +DAE6DB659B00010000000000000100800000000001000000000000014000000000 ==> 1 +DAE6DB659B00010000000000000100200000000001000000000000012000000000 ==> 1 +DAE6DB659B00010000000000000100100000000001000000000000010800000000 ==> 1 +DAE6DB659B00010000000000000100040000000001000000000000010400000000 ==> 1 +DAE6DB659B00010000000000000100020000000001000000000000010100000000 ==> 1 +DAE6DB659B00010000000000000100008000000001000000000000010080000000 ==> 1 +DAE6DB659B00010000000000000100004000000001000000000000010020000000 ==> 1 +DAE6DB659B00010000000000000100001000000001000000000000010010000000 ==> 1 +DAE6DB659B00010000000000000100000800000001000000000000010004000000 ==> 1 +DAE6DB659B00010000000000000100000200000001000000000000010000800000 ==> 1 +DAE6DB659B00010000000000000100000100000001000000000000010000100000 ==> 1 +DAE6DB659B00010000000000000100000040000001000000000000010000020000 ==> 1 +DAE6DB659B00010000000000000100000020000001000000000000010000004000 ==> 1 +DAE6DB659B00010000000000000100000008000001000000000000010000000800 ==> 1 +DAE6DB659B00010000000000000100000004000001000000000000010000000100 ==> 1 +DAE6DB659B00010000000000000100000001000001000000000000010000000020 ==> 1 +DAE6DB659B00010000000000000100000000800001000000000000010000000004 ==> 1 +DAE6DB659B00014020100804000101008040200001080402010000014020000000 ==> 1 +DAE6DB659B00012010080402000100804020100001040201008000012010000000 ==> 1 +DAE6DB659B00010804020100000140201008040001010080402000010804000000 ==> 1 +DAE6DB659B00010402010080000120100804020001008040201000010400800000 ==> 1 +DAE6DB659B00010100804020000108040201000001402010080400010100100000 ==> 1 +DAE6DB659B00010080402010000104020100800001201008040200010080020000 ==> 1 +DAE6DB659B00010020100804000101008040200001080402010000014020004000 ==> 1 +DAE6DB659B00010010080402000100804020100001040201008000012010000800 ==> 1 +DAE6DB659B00010004020100000140201008040001010080402000010804000100 ==> 1 +DAE6DB659B00010002010080000120100804020001008040201000010400800020 ==> 1 +DAE6DB659B00010000804020000108040201000001402010080400010100100004 ==> 1 +DAE6DB659B00014080810102000101020204040001040408081000010000000000 ==> 0 +DAE6DB659B00012020404080000140808101020001010202040400010000000000 ==> 0 +DAE6DB659B00010810102020000120204040800001408081010200010000000000 ==> 0 +DAE6DB659B00010404080810000108101020200001202040408000014000000000 ==> 0 +DAE6DB659B00010102020404000104040808100001081010202000012000000000 ==> 0 +DAE6DB659B00010080810102000101020204040001040408081000010800000000 ==> 0 +DAE6DB659B00010020404080000140808101020001010202040400010400000000 ==> 0 +DAE6DB659B00010010102020000120204040800001408081010200010100000000 ==> 0 +DAE6DB659B00010004080810000108101020200001202040408000014080000000 ==> 0 +DAE6DB659B00010002020404000104040808100001081010202000012020000000 ==> 0 +DAE6DB659B00010000810102000101020204040001040408081000010810000000 ==> 0 +DAE6DB659B00010000404080000140808101020001010202040400010404000000 ==> 0 +DAE6DB659B00010000102020000120204040800001408081010200010100800000 ==> 0 +DAE6DB659B00010000080810000108101020200001202040408000014080100000 ==> 0 +DAE6DB659B00010000020404000104040808100001081010202000012020020000 ==> 0 +DAE6DB659B00010000010102000101020204040001040408081000010810004000 ==> 0 +DAE6DB659B00010000004080000140808101020001010202040400010404000800 ==> 0 +DAE6DB659B00010000002020000120204040800001408081010200010100800100 ==> 0 +DAE6DB659B00010000000810000108101020200001202040408000014080100020 ==> 0 +DAE6DB659B00010000000404000104040808100001081010202000012020020004 ==> 0 diff --git a/tests/testsuite.at b/tests/testsuite.at index acb3299..f22ca5a 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -224,6 +224,12 @@ AT_CHECK([$abs_top_builddir/tests/codec/codec_efr_sid_test $abs_srcdir/codec/codec_efr_sid_test.in], [0], [expout], [ignore]) AT_CLEANUP +AT_SETUP([codec_fr_sid]) +AT_KEYWORDS([codec_fr_sid]) +cat $abs_srcdir/codec/codec_fr_sid_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/codec/codec_fr_sid_test $abs_srcdir/codec/codec_fr_sid_test.in], [0], [expout], [ignore]) +AT_CLEANUP + AT_SETUP([codec_hr_sid]) AT_KEYWORDS([codec_hr_sid]) cat $abs_srcdir/codec/codec_hr_sid_test.ok > expout -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie3f5339cdfecf39e359d635d58864dd323f41fff Gerrit-Change-Number: 37912 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

10 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: fixup: initialize g_hnbp_ctr_id = 0

by neels

Attention is currently required from: laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37880?usp=email ) Change subject: fixup: initialize g_hnbp_ctr_id = 0 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > all static variables are always guaranteed to be initialized with 0. […] that's news to me -- does that mean whenever I have hit bugs of uninitialized variables, it was *always* due to dynamic allocation? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37880?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I353e026d6e3d2c3c8b13a0ca8bd4c09609632b84 Gerrit-Change-Number: 37880 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 23 Aug 2024 02:35:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

10 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: ctrl, hnbgw: access rate counter groups by given ID instead of index

by neels

Attention is currently required from: pespin. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email ) Change subject: ctrl, hnbgw: access rate counter groups by given ID instead of index ...................................................................... Patch Set 3: (1 comment) File library/Osmocom_CTRL_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882/comment/d4378a47_81ae… : PS2, Line 161: * cell ID instad, pass in a mapping of index to cell id, to use the name given by rate_ctr_group_set_name() > instead Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I70e74e7554482df67aa1d90bc04314124dea444f Gerrit-Change-Number: 37882 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Aug 2024 01:47:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

10 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: ctrl, hnbgw: access rate counter groups by given ID instead of index

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ctrl, hnbgw: access rate counter groups by given ID instead of index ...................................................................... ctrl, hnbgw: access rate counter groups by given ID instead of index Teach Osmocom_CTRL_Functions to retrieve rate counters by the ID that the program has set with rate_ctr_group_set_name() (e.g. a hNodeB's cell id). In our tests, the logic is firmly built on indexed arrays. For example, for CN pooling, the tests conveniently have an array of msc.0, msc.1 etc.. This clashes with objects where the indexes on the CTRL interface may vary dynamically. This patch allows the same indexed handling of rate counters even when using the ID names instead of the indexes: still keep the objects in an indexed array, and also provide a mapping from index to ID name. Specific motivation: Since osmo-hnbgw commit 61e278a452bf4fd240e45f1fe8c094a4b3795317 "hnb_persistent: Use incrementing counter for rate_ctr + stat_item index" the hnb rate counter index increments after a hnbp has expired. Instead, use the hNodeB's cell ID (which osmo-hnbgw sets on the counter group with rate_ctr_group_set_name()) to retrieve counters from the CTRL interface. Depends: libosmocore I841a12f76e6fcb2bd7aecb5f4b1707d9ec927137 Related: OS#6545 Change-Id: I70e74e7554482df67aa1d90bc04314124dea444f --- M hnbgw/HNBGW_Tests.ttcn M library/Osmocom_CTRL_Functions.ttcn 2 files changed, 55 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/37882/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I70e74e7554482df67aa1d90bc04314124dea444f Gerrit-Change-Number: 37882 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

10 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: ctrl: tweak errmsg for counter mismatch

by neels

Attention is currently required from: neels. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37883?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: ctrl: tweak errmsg for counter mismatch ...................................................................... ctrl: tweak errmsg for counter mismatch - instead of "-1", print "not present", so humans know what is happening. - the comma separated args in setverdict() create a lot of weird quotes. Use string concatenation to have only one set of quotes around the entire error message. Related: OS#6545 Change-Id: I672fcef819a6542a5b3bcfa0a6d9c84d34b468f3 --- M library/Osmocom_CTRL_Functions.ttcn 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/37883/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I672fcef819a6542a5b3bcfa0a6d9c84d34b468f3 Gerrit-Change-Number: 37883 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

10 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: ctrl, hnbgw: access rate counter groups by given ID instead of index

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ctrl, hnbgw: access rate counter groups by given ID instead of index ...................................................................... ctrl, hnbgw: access rate counter groups by given ID instead of index Teach Osmocom_CTRL_Functions to retrieve rate counters by the ID that the program has set with rate_ctr_group_set_name() (e.g. a hNodeB's cell id). In our tests, the logic is firmly built on indexed arrays. For example, for CN pooling, the tests conveniently have an array of msc.0, msc.1 etc.. This clashes with objects where the indexes on the CTRL interface may vary dynamically. This patch allows the same indexed handling of rate counters even when using the ID names instead of the indexes: still keep the objects in an indexed array, and also provide a mapping from index to ID name. Specific motivation: Since osmo-hnbgw commit 61e278a452bf4fd240e45f1fe8c094a4b3795317 "hnb_persistent: Use incrementing counter for rate_ctr + stat_item index" the hnb rate counter index increments after a hnbp has expired. Instead, use the hNodeB's cell ID (which osmo-hnbgw sets on the counter group with rate_ctr_group_set_name()) to retrieve counters from the CTRL interface. Depends: libosmocore I841a12f76e6fcb2bd7aecb5f4b1707d9ec927137 Related: OS#6545 Change-Id: I70e74e7554482df67aa1d90bc04314124dea444f --- M hnbgw/HNBGW_Tests.ttcn M library/Osmocom_CTRL_Functions.ttcn 2 files changed, 55 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/37882/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I70e74e7554482df67aa1d90bc04314124dea444f Gerrit-Change-Number: 37882 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

10 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024