July 2024 - gerrit-log - lists.osmocom.org

[L] Change in pysim[master]: es9p_client: Move code into a class; do common steps in constructor

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37498?usp=email ) Change subject: es9p_client: Move code into a class; do common steps in constructor ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5a165efcb97d9264369a9c6571cd92022cbcdfb0 Gerrit-Change-Number: 37498 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Jul 2024 15:58:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in docker-playground[master]: asterisk: extensions.conf: Allow extra MO call from SIP UA which HOLD...

by jolly

Attention is currently required from: Hoernchen, jolly, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37527?usp=email ) Change subject: asterisk: extensions.conf: Allow extra MO call from SIP UA which HOLDed previous call ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37527?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Idad9e613669466f3aac8b1c7b43f8d9b6e0494e6 Gerrit-Change-Number: 37527 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Jul 2024 14:54:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: osmo-smdpp + es9p_client: HTTP status 204 is used for handleNotification

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37511?usp=email ) Change subject: osmo-smdpp + es9p_client: HTTP status 204 is used for handleNotification ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > I have tried current master and this patchset in a real world setup and in both cases I see that if […] Also there may be the following situation: A notification may be send out of order through the Cancel Session Procedure for Indirect Profile Download (SGP.32, section 3.2.3.3). So it is possible that a notification arrives late for some reason. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37511?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I890bdbd3e1c4578d2d5f0367958fdce26e338cac Gerrit-Change-Number: 37511 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 17 Jul 2024 14:53:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in docker-playground[master]: asterisk: extensions.conf: Allow extra MO call from SIP UA which HOLD...

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/37527?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: asterisk: extensions.conf: Allow extra MO call from SIP UA which HOLDed previous call ...................................................................... asterisk: extensions.conf: Allow extra MO call from SIP UA which HOLDed previous call We need to keep track of the SIP UA using the IMS endpoint, so that when the IMS call is set on HOLD we can identidy that the same SIP UA can still initiate new calls on the IMS endpoint. Related: SYS#7003 Change-Id: Idad9e613669466f3aac8b1c7b43f8d9b6e0494e6 --- M ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf 1 file changed, 59 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/27/37527/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37527?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Idad9e613669466f3aac8b1c7b43f8d9b6e0494e6 Gerrit-Change-Number: 37527 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: osmo-smdpp + es9p_client: HTTP status 204 is used for handleNotification

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37511?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: osmo-smdpp + es9p_client: HTTP status 204 is used for handleNotification ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Patchset: PS3: I have tried current master and this patchset in a real world setup and in both cases I see that if the transactionId is unknown by osmo-smpdpp that 200 with an empty body is returned. I am still not sure what the problem really (the transactionId sould be known) is, but I think the combination of 200 + empty body should not occur in any case. File osmo-smdpp.py: https://gerrit.osmocom.org/c/pysim/+/37511/comment/d9b3f5c1_7df2805c PS3, Line 494: return I still see that osmo-smdpp.py is sending status 200 in case it does not find the transactionId here. I wonder if it makes sense to do the setResponseCode earlier? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37511?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I890bdbd3e1c4578d2d5f0367958fdce26e338cac Gerrit-Change-Number: 37511 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 17 Jul 2024 14:47:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in docker-playground[master]: WIP

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37527?usp=email ) Change subject: WIP ...................................................................... WIP Change-Id: Idad9e613669466f3aac8b1c7b43f8d9b6e0494e6 --- M ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/27/37527/1 diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf b/ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf index fdfae23..b873e06 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf @@ -1,3 +1,7 @@ +[globals] +IMS_PEER=none + + [get-valid-endpoints-500] ; usage: no arguments, returns DIALGROUP object of registered and valid 050x endpoints exten => s,1,Verbose(5, Entering get-valid-endpoints gosub.) @@ -31,8 +35,12 @@ same => n,Hangup(16) exten => _.!,1,Verbose(5,${EXTEN}: Call external number from ${CALLERID(num)}) + same => n,Verbose(5, PESPIN THE GROUP IS: ${GROUP()}, THE DEVICE_STATE IS: ${DEVICE_STATE(PJSIP/volte_ims)}) + same => n,Verbose(5, PESPIN CHANNELS: ${CHANNELS()}) + same => n,Verbose(5, PESPIN CHANNELS filtered: ${CHANNELS(PJSIP/${CALLERID(num)})}) + same => n,Verbose(5, PESPIN CHANNEL_EXISTS filtered: ${CHANNEL_EXISTS(PJSIP/${CALLERID(num)})}) + same => n,GotoIf($[$[${GROUP_COUNT(IMSgroup)} > 0] & $["${DEVICE_STATE(PJSIP/volte_ims)}" != "ONHOLD"]]?999) same => n,Set(GROUP()=IMSgroup) - same => n,GotoIf($[${GROUP_COUNT(IMSgroup)} > 1]?999) same => n,Dial(PJSIP/${EXTEN}@volte_ims) same => n,Hangup(16) same => 999,Verbose(1,${EXTEN}: VoLTE client already busy (${GROUP_COUNT(IMSgroup)}) rejecting call from SIP UA ${CALLERID(num)}) @@ -66,6 +74,7 @@ same => n,Gosub(get-valid-endpoints-from-volte-ims,s,1()) same => n,Set(DIALGROUP(CALL_EVERYONE_LIST)=${GOSUB_RETVAL}) same => n,WaitForPrecondition(10,2000) + same => n,Set(OUTBOUND_GROUP=IMSgroup) same => n,Dial(${DIALGROUP(CALL_EVERYONE_LIST)}) same => n,Hangup(16) same => 999,Verbose(1,${EXTEN}: VoLTE client already busy (${GROUP_COUNT(IMSgroup)}) rejecting call from IMS ${CALLERID(num)}) -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37527?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Idad9e613669466f3aac8b1c7b43f8d9b6e0494e6 Gerrit-Change-Number: 37527 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: osmo-smdpp: Make sure to return empty HTTP response in handleNotifica...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37497?usp=email ) Change subject: osmo-smdpp: Make sure to return empty HTTP response in handleNotification ...................................................................... osmo-smdpp: Make sure to return empty HTTP response in handleNotification SGP.22 is quite clear in that handleNotification shall return an empty HTTP response body. Let's make sure we comply to that and don't report a JSON response. Change-Id: I1cad539accbc3e7222bfd4780955b3b1ff694c5b --- M osmo-smdpp.py 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/osmo-smdpp.py b/osmo-smdpp.py index 6c275ac..390db18 100755 --- a/osmo-smdpp.py +++ b/osmo-smdpp.py @@ -186,7 +186,9 @@ print("Rx JSON: %s" % json.dumps(content)) set_headers(request) - output = func(self, request, content) or {} + output = func(self, request, content) + if output == None: + return '' build_resp_header(output) print("Tx JSON: %s" % json.dumps(output)) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37497?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1cad539accbc3e7222bfd4780955b3b1ff694c5b Gerrit-Change-Number: 37497 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: jobs/osmocom-build-tags…: fix workspace clean

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37520?usp=email ) Change subject: jobs/osmocom-build-tags…: fix workspace clean ...................................................................... jobs/osmocom-build-tags…: fix workspace clean As this job tries to archive the build logs after running, don't remove the entire workspace. Instead remove the paths that take up the most space, which are the one with the git clones and build artifacts (_deps) as well as the one with the temporary installation dirs (_temp/_inst*). Fixes: b20e8e8b ("jobs/various: clean workspace on success") Change-Id: Ied86ba80b38a9b10a7a96631e6dedee9f3762c3b --- M jobs/osmocom-build-tags-against-master.yml 1 file changed, 19 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/jobs/osmocom-build-tags-against-master.yml b/jobs/osmocom-build-tags-against-master.yml index 8ae4a63..b242103 100644 --- a/jobs/osmocom-build-tags-against-master.yml +++ b/jobs/osmocom-build-tags-against-master.yml @@ -33,8 +33,10 @@ "$USER/debian-bookworm-build" \ scripts/osmocom-build-old-tags-against-master.sh - # Remove workspace on success to free up space - rm -rf "$WORKSPACE" + # Remove git repos and build results on success to free up space + # Logs are kept + rm -rf "$WORKSPACE"/_deps + rm -rf "$WORKSPACE"/_temp/_inst* scm: - git: branches: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ied86ba80b38a9b10a7a96631e6dedee9f3762c3b Gerrit-Change-Number: 37520 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: jobs/osmocom-build-tags…: fix workspace clean

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37520?usp=email ) Change subject: jobs/osmocom-build-tags…: fix workspace clean ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ied86ba80b38a9b10a7a96631e6dedee9f3762c3b Gerrit-Change-Number: 37520 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Jul 2024 13:26:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: osmo-smdpp: Request enable/disable/delete notifications in metadata

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37509?usp=email ) Change subject: osmo-smdpp: Request enable/disable/delete notifications in metadata ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37509?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2861290864522b691b30b079c7c2e1466904df2d Gerrit-Change-Number: 37509 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 17 Jul 2024 13:23:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024