Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/37516?usp=email )
Change subject: doc/examples: set 'oml remote-ip' to '127.0.0.1'
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bts/+/37516/comment/b4a70a08_254bc513
PS1, Line 9: n a typical lab setup the BSC is co-located on the same host with
: the BTS process.
> that is only really true for osmo-bts-trx.
for lc15/sysmo/oc2g it is very unlikely that you'd have 127.0.0.1 for BTS+BSC.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/37516?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I41b8de14c19088ef614ce751c738e4fc5969f0da
Gerrit-Change-Number: 37516
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Jul 2024 16:39:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/37516?usp=email )
Change subject: doc/examples: set 'oml remote-ip' to '127.0.0.1'
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bts/+/37516/comment/aa643064_a0638ca6
PS1, Line 9: n a typical lab setup the BSC is co-located on the same host with
: the BTS process.
that is only really true for osmo-bts-trx.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/37516?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I41b8de14c19088ef614ce751c738e4fc5969f0da
Gerrit-Change-Number: 37516
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Jul 2024 16:38:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37511?usp=email )
Change subject: osmo-smdpp + es9p_client: HTTP status 204 is used for handleNotification
......................................................................
Patch Set 5:
(1 comment)
File osmo-smdpp.py:
https://gerrit.osmocom.org/c/pysim/+/37511/comment/1edbeec9_34510ea0
PS3, Line 494: return
> I still see that osmo-smdpp. […]
done. I forgot that 204 should also be sent in the erroneous case.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37511?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I890bdbd3e1c4578d2d5f0367958fdce26e338cac
Gerrit-Change-Number: 37511
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Jul 2024 16:37:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: dexter, laforge.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/37511?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by dexter, Verified+1 by Jenkins Builder
Change subject: osmo-smdpp + es9p_client: HTTP status 204 is used for handleNotification
......................................................................
osmo-smdpp + es9p_client: HTTP status 204 is used for handleNotification
As SGP.22 states, the handleNotification endpoint uses HTTP status 204,
not 200 (due to its empty body).
Change-Id: I890bdbd3e1c4578d2d5f0367958fdce26e338cac
---
M osmo-smdpp.py
M pySim/esim/es9p.py
2 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/11/37511/5
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37511?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I890bdbd3e1c4578d2d5f0367958fdce26e338cac
Gerrit-Change-Number: 37511
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Hello Jenkins Builder, dexter, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/37509?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: osmo-smdpp: Request enable/disable/delete notifications in metadata
......................................................................
osmo-smdpp: Request enable/disable/delete notifications in metadata
this way, the eUICC will send us notifications whenever our profiles are
enabled/disabled/deleted.
Change-Id: I2861290864522b691b30b079c7c2e1466904df2d
---
M osmo-smdpp.py
M pySim/esim/es8p.py
2 files changed, 27 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/09/37509/4
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37509?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2861290864522b691b30b079c7c2e1466904df2d
Gerrit-Change-Number: 37509
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/37523?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: pySim.ts_31_103: update to spec v18.1.0 Release 18
......................................................................
pySim.ts_31_103: update to spec v18.1.0 Release 18
This adds two new EFs and one new IST service.
Change-Id: Iced1700046b459399a3e8305e1387ec65eeb3536
---
M pySim/ts_31_103.py
M pysim-testdata/pySim-trace_test_gsmtap.pcapng.ok
2 files changed, 40 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/23/37523/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37523?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iced1700046b459399a3e8305e1387ec65eeb3536
Gerrit-Change-Number: 37523
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: dexter, fixeria.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/37499?usp=email
to look at the new patch set (#6).
Change subject: contrib/es9p_client: Add support for reporting notifications to SM-DP+
......................................................................
contrib/es9p_client: Add support for reporting notifications to SM-DP+
The ES9+ interface is not only used for downloading eSIM profiles, but
it is also used to report back the installation result as well as
profile management operations like enable/disable/delete.
Change-Id: Iefba7fa0471b34eae30700ed43531a515af0eb93
---
M contrib/es9p_client.py
M pySim/esim/__init__.py
2 files changed, 132 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/99/37499/6
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37499?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iefba7fa0471b34eae30700ed43531a515af0eb93
Gerrit-Change-Number: 37499
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: dexter, fixeria.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/37499?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: contrib/es9p_client: Add support for reporting notifications to SM-DP+
......................................................................
contrib/es9p_client: Add support for reporting notifications to SM-DP+
The ES9+ interface is not only used for downloading eSIM profiles, but
it is also used to report back the installation result as well as
profile management operations like enable/disable/delete.
Change-Id: Iefba7fa0471b34eae30700ed43531a515af0eb93
---
M contrib/es9p_client.py
M pySim/esim/__init__.py
2 files changed, 132 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/99/37499/5
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37499?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iefba7fa0471b34eae30700ed43531a515af0eb93
Gerrit-Change-Number: 37499
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37499?usp=email )
Change subject: contrib/es9p_client: Add support for reporting notifications to SM-DP+
......................................................................
Patch Set 4:
(4 comments)
File pySim/esim/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/37499/comment/f286c822_7f0588ae
PS3, Line 7: pmo4operation
> Looks like you want this to be an `enum.IntEnum`? […]
I just played a bit with the idea, but decided against it. First of all, I want lowercase string names as we use lowercase strings everywhere in our json (and all enum.Enum seems to use uppercase). Second, I'm not entirely sure how I can implement the bitstring-compatibility to it, as enum.Enum and derived classes seems to normally work with static/class members and not instances?
https://gerrit.osmocom.org/c/pysim/+/37499/comment/3e8ea6c0_b58e2ed3
PS3, Line 23: _num_bits
> FYI, this can be implemented as: […]
Thanks. Hoewever, I'm not sure I want to introduce python version checks... it's not performance critical.
https://gerrit.osmocom.org/c/pysim/+/37499/comment/3165eed2_4a32cdfe
PS3, Line 35: from_int
> If this class was an `enum.IntEnum`, this API would look like: […]
decided against enum
https://gerrit.osmocom.org/c/pysim/+/37499/comment/f6396316_770c3a44
PS3, Line 35: str
> `str` is not a valid type hint for this function, should be `-> 'PMO'` I think
Done
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37499?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iefba7fa0471b34eae30700ed43531a515af0eb93
Gerrit-Change-Number: 37499
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Jul 2024 16:04:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment